Re: [PATCH v2] loopback: Do not automaticaly replace existing loopback dev, error instead

2020-12-10 Thread Daniel Kiper
On Mon, Dec 07, 2020 at 10:52:16PM -0600, Glenn Washburn wrote: > On Fri, 4 Dec 2020 13:34:44 +0100 > Daniel Kiper wrote: > > > On Thu, Dec 03, 2020 at 07:57:11PM -0600, Glenn Washburn wrote: > > > If there is a loopback device with the same name as the one to be > > > created, instead of closing

Re: [PATCH 8/9] efi: Only register shim_lock verifier if shim_lock protocol is found and SB enabled

2020-12-10 Thread Daniel Kiper
On Tue, Dec 08, 2020 at 10:20:03AM +0800, Michael Chang via Grub-devel wrote: > On Thu, Dec 03, 2020 at 04:01:49PM +0100, Javier Martinez Canillas wrote: > > The shim_lock module registers a verifier to call shim's verify, but the > > handler is registered even when the shim_lock protocol was not i

Re: [PATCH v8 00/18] Cryptodisk fixes for v2.06 redux

2020-12-10 Thread Daniel Kiper
On Tue, Dec 08, 2020 at 04:45:31PM -0600, Glenn Washburn wrote: > This patch series, fixes issues with v7 series. Some of those patches had > changes applied to the wrong patch. The added structure member was renamed > again, this time to idx. And there is an added patch that renames some json > in

Re: [PATCH v8 16/18] mips: Enable __clzdi2()

2020-12-10 Thread Daniel Kiper
On Tue, Dec 08, 2020 at 04:45:47PM -0600, Glenn Washburn wrote: > This patch is similiar to commit 9dab2f51e (sparc: Enable __clzsi2() and > __clzdi2()) but for MIPS target and __clzdi2 only, __clzsi2 was already > enabled. > > Signed-off-by: Glenn Washburn > Suggested-by: Daniel Kiper Reviewed-

Re: [PATCH v8 14/18] luks2: Better error handling when setting up the cryptodisk

2020-12-10 Thread Daniel Kiper
On Tue, Dec 08, 2020 at 04:45:45PM -0600, Glenn Washburn wrote: > First, check to make sure that source disk has a known size. If not, print > debug message and return error. There are 4 cases where > GRUB_DISK_SIZE_UNKNOWN is set (biosdisk, obdisk, ofdisk, and uboot), and in > all those cases proc

Re: [PATCH v8 15/18] luks2: Error check segment.sector_size

2020-12-10 Thread Daniel Kiper
On Tue, Dec 08, 2020 at 04:45:46PM -0600, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v8 11/18] cryptodisk: Add macros GRUB_TYPE_U_MAX/MIN(type) to replace literals

2020-12-10 Thread Daniel Kiper
On Tue, Dec 08, 2020 at 04:45:42PM -0600, Glenn Washburn wrote: > Add GRUB_TYPE_U_MAX/MIN(type) macros to get the max/min values for an > unsigned number with size of type. > > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-d

Re: [PATCH] ieee1275: Avoiding many unecessary open/close

2020-12-10 Thread diegodo
Hello folks, any luck to advance with this patch? I would like to have a feedback in how we can implement this change on grub. Let me know if any work is needed from my side. Thanks ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.

[PATCH v7 5/6] cryptodisk: enable the backends to implement key files

2020-12-10 Thread Denis 'GNUtoo' Carikli
From: John Lane Signed-off-by: John Lane gnu...@cyberdimension.org: rebase, patch split, small fixes, commit message Signed-off-by: Denis 'GNUtoo' Carikli Reviewed-by: Patrick Steinhardt --- Changelog since v3: --- - Fixed the size formating with PRIuGRUB_SIZE - Added Reviewed-

[PATCH v7 4/6] cryptodisk: add support for LUKS1 detached headers

2020-12-10 Thread Denis 'GNUtoo' Carikli
From: John Lane cryptsetup supports having a detached header through the --header command line argument for both LUKS1 and LUKS2. This adds support for LUKS1 detached headers. Signed-off-by: John Lane gnu...@cyberdimension.org: rebase, small fixes, commit message Signed-off-by: Denis 'GNUtoo'

v7 for detached headers and key files

2020-12-10 Thread Denis 'GNUtoo' Carikli
Hi, I've addressed the issues found in the last round. Like the last time I also tested it on real hardware. I'm also sorry for the delay. Denis. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH v7 6/6] cryptodisk: Add support for LUKS1 key files

2020-12-10 Thread Denis 'GNUtoo' Carikli
cryptsetup supports key files thourh the --key-file --header command line argument for both LUKS1 and LUKS2. This adds support for LUKS1 key files. Signed-off-by: John Lane gnu...@cyberdimension.org: rebase, fixes, commit message Signed-off-by: Denis 'GNUtoo' Carikli Reviewed-by: Patrick Steinh

[PATCH v7 2/6] cryptodisk: geli: unify grub_cryptodisk_dev function names

2020-12-10 Thread Denis 'GNUtoo' Carikli
Signed-off-by: Denis 'GNUtoo' Carikli Reviewed-by: Patrick Steinhardt --- ChangeLog since v4: - Added Reviewed-by tag ChangeLog since v5: - No changes ChangeLog since v6: - No changes --- grub-core/disk/geli.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/grub-core

[PATCH v7 3/6] cryptodisk: enable the backends to implement detached headers

2020-12-10 Thread Denis 'GNUtoo' Carikli
From: John Lane Signed-off-by: John Lane gnu...@cyberdimension.org: rebase, patch split, small fixes, commit message Signed-off-by: Denis 'GNUtoo' Carikli Reviewed-by: Patrick Steinhardt --- ChangeLog since v4: - Added Reviewed-by tag ChangeLog since v5: - No changes ChangeLog since v6: Rebase

[PATCH v7 1/6] cryptodisk: luks: unify grub_cryptodisk_dev function names

2020-12-10 Thread Denis 'GNUtoo' Carikli
Signed-off-by: Denis 'GNUtoo' Carikli Reviewed-by: Patrick Steinhardt --- ChangeLog since v4: - Added Reviewed-by tag ChangeLog since v5: - No changes ChangeLog since v6: - No changes --- grub-core/disk/luks.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/grub-core/di