On Tue, Dec 08, 2020 at 10:20:03AM +0800, Michael Chang via Grub-devel wrote: > On Thu, Dec 03, 2020 at 04:01:49PM +0100, Javier Martinez Canillas wrote: > > The shim_lock module registers a verifier to call shim's verify, but the > > handler is registered even when the shim_lock protocol was not installed. > > > > This doesn't cause a NULL pointer dereference in shim_lock_write() because > > the shim_lock_init() function just returns GRUB_ERR_NONE if sl isn't set. > > > > But in that case there's no point to even register the shim_lock verifier > > since won't do anything. Additionally, it is only useful when Secure Boot > > is enabled. > > > > Finally, don't assume that the shim_lock protocol will always be present > > when the shim_lock_write() function is called, and check for it on every > > call to this function. > > > > Reported-by: Michael Chang <mch...@suse.com> > > To complete the information here, this fixed the problem I tried to > solve before, but in a more elegant way. :) > > https://www.mail-archive.com/grub-devel@gnu.org/msg30738.html > > Thank you to work on the patch.
You are welcome! May I add your Tested-by do this patch? Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
