Re: [PATCH] ia64: build fix in cache.h

2019-06-04 Thread Leif Lindholm
On Wed, Jun 05, 2019 at 12:11:00AM +0200, John Paul Adrian Glaubitz wrote: > On 6/4/19 8:51 PM, Leif Lindholm wrote: > > Add ia64 to the architectures excluding a declaration for > > grub_arch_sync_dma_caches. > > > > IA64 does not include any of the source files that require the function, > > but

Re: [PATCH] ia64: build fix in cache.h

2019-06-04 Thread John Paul Adrian Glaubitz
On 6/4/19 8:51 PM, Leif Lindholm wrote: > Add ia64 to the architectures excluding a declaration for > grub_arch_sync_dma_caches. > > IA64 does not include any of the source files that require the function, > but was overlooked for d8901e3ba115 ("cache: Fix compilation for ppc, > sparc and arm64").

[PATCH] ia64: build fix in cache.h

2019-06-04 Thread Leif Lindholm
Add ia64 to the architectures excluding a declaration for grub_arch_sync_dma_caches. IA64 does not include any of the source files that require the function, but was overlooked for d8901e3ba115 ("cache: Fix compilation for ppc, sparc and arm64"). Add it to the list of excluding architectures in o

Re: [PATCH v3 09/10] travis: Disable MIPS target

2019-06-04 Thread Leif Lindholm
On Tue, Jun 04, 2019 at 12:27:33PM +0200, Alexander Graf wrote: > The MIPS target currently does not compile due to the following error > message: > > configure: error: could not force big-endian > > If anyone cares enough about MIPS to fix it up, be my guest and revert > this commit afterwards

Re: [PATCH v3 10/10] travis: Disable IA64 target

2019-06-04 Thread Leif Lindholm
On Tue, Jun 04, 2019 at 03:37:39PM +0200, John Paul Adrian Glaubitz wrote: > On 6/4/19 3:34 PM, Leif Lindholm wrote: > > I am reasonably convinced this was simply neglected when d8901e3ba1 > > ("cache: Fix compilation for ppc, sparc and arm64") was pushed. > > (And I don't believe ia64 has been bui

Re: [PATCH v3 10/10] travis: Disable IA64 target

2019-06-04 Thread Alexander Graf
On 04.06.19 15:37, John Paul Adrian Glaubitz wrote: > On 6/4/19 3:34 PM, Leif Lindholm wrote: >> I am reasonably convinced this was simply neglected when d8901e3ba1 >> ("cache: Fix compilation for ppc, sparc and arm64") was pushed. >> (And I don't believe ia64 has been buildable since.) > *cross*

Re: [PATCH v3 10/10] travis: Disable IA64 target

2019-06-04 Thread John Paul Adrian Glaubitz
On 6/4/19 3:34 PM, Leif Lindholm wrote: > I am reasonably convinced this was simply neglected when d8901e3ba1 > ("cache: Fix compilation for ppc, sparc and arm64") was pushed. > (And I don't believe ia64 has been buildable since.) *cross*-buildable. It's build absolutely fine naively. Daniel expl

Re: [PATCH v3 10/10] travis: Disable IA64 target

2019-06-04 Thread Leif Lindholm
On Tue, Jun 04, 2019 at 12:27:34PM +0200, Alexander Graf wrote: > The IA64 target currently does not compile due to the following error > message: > > grub-mkimage: error: undefined symbol grub_arch_sync_dma_caches. > > If anyone cares enough about IA64 to fix it up, be my guest and revert > thi

Re: [PATCH v3 09/10] travis: Disable MIPS target

2019-06-04 Thread John Paul Adrian Glaubitz
On 6/4/19 2:07 PM, Alexander Graf wrote: > Yes, it does. I did try back when I first added the cross compiler > support, but for some reason did not manage to make use of the built-in > cross compilers. Maybe the versions in that Ubuntu version were just too > old? I really don't remember. Those c

Re: [PATCH v3 09/10] travis: Disable MIPS target

2019-06-04 Thread Alexander Graf
On 04.06.19 14:01, John Paul Adrian Glaubitz wrote: > On 6/4/19 1:47 PM, Alexander Graf wrote: >> Could you please just fix up the travis tests to succeed? I think the >> MIPS problem is definitely toolchain related. Maybe you can somehow >> convince that travis ubuntu container to use official D

Re: [PATCH v3 09/10] travis: Disable MIPS target

2019-06-04 Thread Daniel Kiper
On Tue, Jun 04, 2019 at 01:47:52PM +0200, Alexander Graf wrote: > > On 04.06.19 13:36, John Paul Adrian Glaubitz wrote: > > On 6/4/19 12:27 PM, Alexander Graf wrote: > >> The MIPS target currently does not compile due to the following error > >> message: > >> > >> configure: error: could not forc

Re: [PATCH v3 10/10] travis: Disable IA64 target

2019-06-04 Thread Alexander Graf
On 04.06.19 13:35, John Paul Adrian Glaubitz wrote: > On 6/4/19 12:27 PM, Alexander Graf wrote: >> The IA64 target currently does not compile due to the following error >> message: >> >> grub-mkimage: error: undefined symbol grub_arch_sync_dma_caches. >> >> If anyone cares enough about IA64 to

Re: [PATCH v3 09/10] travis: Disable MIPS target

2019-06-04 Thread John Paul Adrian Glaubitz
On 6/4/19 1:47 PM, Alexander Graf wrote: > Could you please just fix up the travis tests to succeed? I think the > MIPS problem is definitely toolchain related. Maybe you can somehow > convince that travis ubuntu container to use official Debian cross > compilers instead of the kernel.org ones that

Re: [PATCH] configure: disable arm movw/movt relocations for GCC

2019-06-04 Thread Alexander Graf
On 04.06.19 13:39, Leif Lindholm wrote: > When building for arm, we already disable movw/movt relocations for clang, > since they are incompatible with PE. > > When building with bare metal GCC toolchains (like the one used in the > travis ci scripts), we end up with these relocations again. So a

Re: [PATCH v3 10/10] travis: Disable IA64 target

2019-06-04 Thread John Paul Adrian Glaubitz
On 6/4/19 1:46 PM, Alexander Graf wrote: > Travis doesn't lie :). Maybe it's something about the toolchain used? > > https://travis-ci.org/agraf/grub/jobs/541099309 I don't lie either :P. Toolchain and kernel are recent: root@titanium:~# gcc -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_W

Re: [PATCH v3 09/10] travis: Disable MIPS target

2019-06-04 Thread Alexander Graf
On 04.06.19 13:36, John Paul Adrian Glaubitz wrote: > On 6/4/19 12:27 PM, Alexander Graf wrote: >> The MIPS target currently does not compile due to the following error >> message: >> >> configure: error: could not force big-endian >> >> If anyone cares enough about MIPS to fix it up, be my gue

Re: [PATCH v3 10/10] travis: Disable IA64 target

2019-06-04 Thread Alexander Graf
On 04.06.19 13:35, John Paul Adrian Glaubitz wrote: > On 6/4/19 12:27 PM, Alexander Graf wrote: >> The IA64 target currently does not compile due to the following error >> message: >> >> grub-mkimage: error: undefined symbol grub_arch_sync_dma_caches. >> >> If anyone cares enough about IA64 to

Re: [PATCH v3 06/10] travis: Add smoke tests for arm and aarch64

2019-06-04 Thread Leif Lindholm
On Tue, Jun 04, 2019 at 12:27:30PM +0200, Alexander Graf wrote: > We've had an arm regression in grub recently where grub would not even > be able to boot up anymore. So let's include arm and aarch64 in our > simple "hello world" smoke tests as well. > > For OVMF on ARM to work, we need a newer ve

[PATCH] configure: disable arm movw/movt relocations for GCC

2019-06-04 Thread Leif Lindholm
When building for arm, we already disable movw/movt relocations for clang, since they are incompatible with PE. When building with bare metal GCC toolchains (like the one used in the travis ci scripts), we end up with these relocations again. So add an additional test for the '-mword-relocations'

Re: [PATCH v3 09/10] travis: Disable MIPS target

2019-06-04 Thread John Paul Adrian Glaubitz
On 6/4/19 12:27 PM, Alexander Graf wrote: > The MIPS target currently does not compile due to the following error > message: > > configure: error: could not force big-endian > > If anyone cares enough about MIPS to fix it up, be my guest and revert > this commit afterwards. For now, we really n

Re: [PATCH v3 10/10] travis: Disable IA64 target

2019-06-04 Thread John Paul Adrian Glaubitz
On 6/4/19 12:27 PM, Alexander Graf wrote: > The IA64 target currently does not compile due to the following error > message: > > grub-mkimage: error: undefined symbol grub_arch_sync_dma_caches. > > If anyone cares enough about IA64 to fix it up, be my guest and revert > this commit afterwards.

[PATCH v3 08/10] travis: Test module loading from tftp as well

2019-06-04 Thread Alexander Graf
The travis test today only uses modules that are delivered with the grub.efi binary. Let's drop echo and reboot and see if grub can load them dynamically. For this, we need to ensure that all modules required to load additional modules are included in the grub binary. Some of these are target spec

[PATCH v3 06/10] travis: Add smoke tests for arm and aarch64

2019-06-04 Thread Alexander Graf
We've had an arm regression in grub recently where grub would not even be able to boot up anymore. So let's include arm and aarch64 in our simple "hello world" smoke tests as well. For OVMF on ARM to work, we need a newer version of QEMU, add a PPA dependency for it. Signed-off-by: Alexander Graf

[PATCH v3 10/10] travis: Disable IA64 target

2019-06-04 Thread Alexander Graf
The IA64 target currently does not compile due to the following error message: grub-mkimage: error: undefined symbol grub_arch_sync_dma_caches. If anyone cares enough about IA64 to fix it up, be my guest and revert this commit afterwards. For now, we really need to move forward with a fully suc

[PATCH v3 00/10] Travis fixes

2019-06-04 Thread Alexander Graf
This patch set collects a few fixes for Travis CI since the initial commit was applied: - catch up with the tree - fix targets that need a board specified - make mkimage loop more robust - add QEMU tests for ARM and AArch64 EFI targets - add ARM Thumb mode tests - verify that on demand

[PATCH v3 01/10] travis: Run bootstrap instead of autogen.sh

2019-06-04 Thread Alexander Graf
Commit 35b909062e7b3 ("gnulib: Upgrade Gnulib and switch to bootstrap tool") changed the build flow from running ./autogen.sh to running ./bootstrap but missed to update .travis.yml. Adapt it accordingly. Fixes: 35b909062e7b3 ("gnulib: Upgrade Gnulib and switch to bootstrap tool") Signed-off-by: A

[PATCH v3 09/10] travis: Disable MIPS target

2019-06-04 Thread Alexander Graf
The MIPS target currently does not compile due to the following error message: configure: error: could not force big-endian If anyone cares enough about MIPS to fix it up, be my guest and revert this commit afterwards. For now, we really need to move forward with a fully successful travis run t

[PATCH v3 05/10] arm coreboot: Use common directory path

2019-06-04 Thread Alexander Graf
The ARM coreboot target supports multiple boards, but they are all built using the same object path. The only difference in target boards is done in mkimage to determine the load address. Currently, mkimage is looking at a board specific path (/usr/lib/grub/arm-coreboot-vexpress) for modules while

[PATCH v3 02/10] travis: Fix sparc64 test

2019-06-04 Thread Alexander Graf
For sparc64, we were not selecting the correct mkimage output type. Just pick aout at random. Also, make sure the rest of the variable logic can deal with the 3rd element. Signed-off-by: Alexander Graf Reviewed-by: Daniel Kiper --- .travis.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 delet

[PATCH v3 04/10] travis: Fix arm coreboot test and make loop more robus

2019-06-04 Thread Alexander Graf
We missed the fact that the coreboot target did not succeed on mkimage. Properly abort the loop if we see a failure and fix the coreboot target to also indicate the board target. Signed-off-by: Alexander Graf Reviewed-by: Daniel Kiper --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v3 07/10] travis: Add ARM thumb target to tests

2019-06-04 Thread Alexander Graf
We hit an error case which only got triggered on ARM Thumb code. So let's make sure we test that combination as well. Due to popular request from Leif, let's also ensure that this actually tests thumb in armv7-a mode. Signed-off-by: Alexander Graf --- .travis.yml | 5 + 1 file changed, 5 in

[PATCH v3 03/10] travis: Fix mips QEMU target

2019-06-04 Thread Alexander Graf
The MIPS QEMU targets can be built as either elf binary or flash image. Build one each for BE/LE and make sure we pass the correct one into mkimage. Signed-off-by: Alexander Graf Reviewed-by: Daniel Kiper --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travi

Re: GRUB failed to install on Fujitsu M10-4

2019-06-04 Thread Steve McIntyre
On Tue, Jun 04, 2019 at 09:56:37AM +0200, John Paul Adrian Glaubitz wrote: >On 6/4/19 2:56 AM, Sonnie Hook wrote: >> Now I re-installed from cdrom. When installing GRUB on disk, I got this >> message: >> It seems that this computer is configured to boot via EFI, but maybe that >> configuration wil

Re: GRUB failed to install on Fujitsu M10-4

2019-06-04 Thread John Paul Adrian Glaubitz
On 6/4/19 2:56 AM, Sonnie Hook wrote: > Now I re-installed from cdrom. When installing GRUB on disk, I got this > message: > It seems that this computer is configured to boot via EFI, but maybe that > configuration will not work for booting from the hard drive. Some EFI > firmware implementations