On 04.06.19 13:35, John Paul Adrian Glaubitz wrote: > On 6/4/19 12:27 PM, Alexander Graf wrote: >> The IA64 target currently does not compile due to the following error >> message: >> >> grub-mkimage: error: undefined symbol grub_arch_sync_dma_caches. >> >> If anyone cares enough about IA64 to fix it up, be my guest and revert >> this commit afterwards. For now, we really need to move forward with >> a fully successful travis run to ensure that we catch regressions early >> on. > This can't be. GRUB builds just fine on ia64, I just tested that yesterday.
Actually, the IA64 error is not a build error but a runtime error. Mkimage fails. My main motivation with this patch set is to get us into green travis state. If that means we only cover 80% ground today, so be it. It's still much better than the 0% we have today. Going forward, I would *really* like to see a policy put into place that mandates every upstream merge to succeed in Travis. Any commit that breaks the CI should simply not land in master. That way we can guarantee that base functionality is always available. That also means that once you have time to enable MIPS and IA64, we have a good regression test in place to ensure that they won't break going forward from that point on :). Alex _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
