Re: [RFC 1/1] mkimage: revert "Align efi sections on 4k boundary"

2019-04-16 Thread Colin Watson
On Wed, Apr 17, 2019 at 07:50:09AM +0200, Heinrich Schuchardt wrote: > Since this commit a51f953f4ee8 ("mkimage: Align efi sections on 4k > boundary") grubarm.efi crashes. Let's revert it. > > a51f953f4ee8 ("mkimage: Align efi sections on 4k boundary") > Signed-off-by: Heinrich Schuchardt > --- >

Re: GRUB fails to load kernel on linux-sparc64

2019-04-16 Thread Colin Watson
On Tue, Apr 16, 2019 at 09:38:34PM +0200, John Paul Adrian Glaubitz wrote: > On 4/16/19 9:27 PM, Eric Snowberg wrote: > >> @Eric: Does GRUB 2.04~rc1 work fine for you on sparc64? > > > > I boot with an uncompressed kernel and do not see a problem. If I try with > > a compressed kernel I do see th

Re: GRUB fails to load kernel on linux-sparc64

2019-04-16 Thread Colin Watson
On Tue, Apr 16, 2019 at 09:51:07PM +0200, Didier Spaier wrote: > On 16/04/2019 21:38, John Paul Adrian Glaubitz wrote: > > That would indeed explain the problem. However, Debian's GRUB version > > does support compressed kernels on sparc64. I wonder whether we have > > a local modification that mak

[RFC 1/1] mkimage: revert "Align efi sections on 4k boundary"

2019-04-16 Thread Heinrich Schuchardt
Since this commit a51f953f4ee8 ("mkimage: Align efi sections on 4k boundary") grubarm.efi crashes. Let's revert it. a51f953f4ee8 ("mkimage: Align efi sections on 4k boundary") Signed-off-by: Heinrich Schuchardt --- As Alexander Graf pointed out in a private mail without his patch Qcom ARM noteboo

[PATCH 1/1] efi: avoid NULL dereference if FilePath is NULL

2019-04-16 Thread Heinrich Schuchardt
The UEFI specification allows LoadImage() to be called with a memory location only and without a device path. In this case FilePath will not be set in the EFI_LOADED_IMAGE_PROTOCOL. So in function grub_efi_get_filename() the device path argument may be NULL. As we cannot determine the device path

Re: GRUB fails to load kernel on linux-sparc64

2019-04-16 Thread Didier Spaier
On 16/04/2019 21:38, John Paul Adrian Glaubitz wrote: > That would indeed explain the problem. However, Debian's GRUB version > does support compressed kernels on sparc64. I wonder whether we have > a local modification that makes this possible. Which makes me ask this OT question: with the releas

Re: GRUB fails to load kernel on linux-sparc64

2019-04-16 Thread John Paul Adrian Glaubitz
Hi Eric! On 4/16/19 9:27 PM, Eric Snowberg wrote: >> @Eric: Does GRUB 2.04~rc1 work fine for you on sparc64? > > I boot with an uncompressed kernel and do not see a problem. If I try with a > compressed kernel I do see the error you have above. But this is a known > platform limitation: > htt

Re: GRUB fails to load kernel on linux-sparc64

2019-04-16 Thread Eric Snowberg
> On Apr 16, 2019, at 9:15 AM, John Paul Adrian Glaubitz > wrote: > > Hi! > > I have been doing some RC testing with GRUB 2.04~rc1 and actually > ran into a problem on sparc64 after updating from 2.02 (debian) > to 2.04~rc1. > > GRUB itself starts fine, but it fails to load the kernel with t

GRUB fails to load kernel on linux-sparc64

2019-04-16 Thread John Paul Adrian Glaubitz
Hi! I have been doing some RC testing with GRUB 2.04~rc1 and actually ran into a problem on sparc64 after updating from 2.02 (debian) to 2.04~rc1. GRUB itself starts fine, but it fails to load the kernel with the following error: Loading Linux 4.19.0-4-sparc64-smp ... error: premature end of fil