Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread Eric Snowberg
> On Mar 25, 2019, at 3:11 PM, John Paul Adrian Glaubitz > wrote: > > On 3/25/19 9:41 PM, Eric Snowberg wrote: >>> Is this on Solaris? I want to try reproducing it, so I can figure what >>> happened. >>> >> >> I’m using Oracle Linux for SPARC (6.9). > > Ok, so it can only be a matter of the

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread John Paul Adrian Glaubitz
On 3/25/19 9:41 PM, Eric Snowberg wrote: >> Is this on Solaris? I want to try reproducing it, so I can figure what >> happened. >> > > I’m using Oracle Linux for SPARC (6.9). Ok, so it can only be a matter of the older binutils version implicitly assuming the output format to be a.out. Could yo

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread Eric Snowberg
> On Mar 25, 2019, at 1:21 PM, John Paul Adrian Glaubitz > wrote: > > On 3/25/19 5:20 PM, Eric Snowberg wrote: >> I tried it out, but on my system it doesn’t fit in the 512 byte block? Am I >> missing something? >> >> Before the patch: >> >> $ grub-install --force --skip-fs-probe /dev/sdb1

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread John Paul Adrian Glaubitz
On 3/25/19 5:20 PM, Eric Snowberg wrote: > I tried it out, but on my system it doesn’t fit in the 512 byte block? Am I > missing something? > > Before the patch: > > $ grub-install --force --skip-fs-probe /dev/sdb1 > Installing for sparc64-ieee1275 platform. > grub-install: warning: Attempting

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread John Paul Adrian Glaubitz
On 3/25/19 6:22 PM, John Paul Adrian Glaubitz wrote: > I am not done testing yet but I just realized, 544 = 512 + 32, so it looks > like the a.out header is appended twice. Does an older binutils maybe default > to a.out when just passing binary as the output format? Just did another test build, t

[PATCH v2] msr: Rearrange return values.

2019-03-25 Thread Jesús Diéguez Fernández
Rearrange return values in the function declaration of rdmsr.h and wrmsr.h. Signed-off-by: Jesús Diéguez Fernández --- include/grub/i386/rdmsr.h | 3 ++- include/grub/i386/wrmsr.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/grub/i386/rdmsr.h b/include/grub/i38

[dki...@net-space.pl: Re: [PATCH] POTFILES: Don't include gnulib in grub.pot]

2019-03-25 Thread Daniel Kiper
- Forwarded message from Daniel Kiper - Date: Mon, 25 Mar 2019 15:29:55 +0100 From: Daniel Kiper To: Vladimir 'phcoder' Serbinenko Subject: Re: [PATCH] POTFILES: Don't include gnulib in grub.pot User-Agent: NeoMutt/20170113 (1.7.2) On Mon, Mar 25, 2019 at 03:22:21PM +0100, Vladimir 'ph

Re: [PATCH] efi/tpm.c: Add missing casts

2019-03-25 Thread Daniel Kiper
On Mon, Mar 25, 2019 at 03:27:11PM +0100, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Mar 25, 2019 at 1:09 PM Daniel Kiper wrote: > > > > On Fri, Mar 22, 2019 at 04:11:10PM +0100, Vladimir 'phcoder' Serbinenko > > wrote: > > > From 9443713c3d3403a21aac9b39de4bbd097a531dd4 Mon Sep 17 00:00:00 2

Re: [PATCH] Propagate GNU_PRINTF from gnulib vfprintf

2019-03-25 Thread Daniel Kiper
On Mon, Mar 25, 2019 at 04:07:32PM +0100, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Mar 25, 2019 at 1:24 PM Daniel Kiper wrote: > > On Fri, Mar 22, 2019 at 04:15:35PM +0100, Vladimir 'phcoder' Serbinenko > > wrote: > > > From ce156e3274e53089b7a9ba432262b8aab75d8ad0 Mon Sep 17 00:00:00 2001

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread John Paul Adrian Glaubitz
On 3/25/19 5:20 PM, Eric Snowberg wrote: > I tried it out, but on my system it doesn’t fit in the 512 byte block? Am I > missing something? > > Before the patch: > > $ grub-install --force --skip-fs-probe /dev/sdb1 > Installing for sparc64-ieee1275 platform. > grub-install: warning: Attempting

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread John Paul Adrian Glaubitz
On 3/25/19 6:17 PM, John Paul Adrian Glaubitz wrote: >> $ grub-install --force --skip-fs-probe /dev/sdb1 >> Installing for sparc64-ieee1275 platform. >> grub-install: error: the size of `/boot/grub/sparc64-ieee1275/boot.img' is >> not 512. >> >> $ ls -al /boot/grub/sparc64-ieee1275/boot.img >> -rw

Re: Fwd: [PATCH] POTFILES: Don't include gnulib in grub.pot

2019-03-25 Thread Colin Watson
On Mon, Mar 25, 2019 at 03:24:25PM +0100, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Mar 25, 2019 at 12:58 PM Daniel Kiper wrote: > > Sadly this patch does not look complete. ./grub-core/lib/gnulib is still > > included. And as Colin pointed out missing SOB. > > This directory still exists, a

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread Eric Snowberg
> On Mar 25, 2019, at 5:45 AM, Daniel Kiper wrote: > > On Fri, Mar 22, 2019 at 07:35:55AM +0100, John Paul Adrian Glaubitz wrote: >> Recent versions of binutils dropped support for the a.out and COFF >> formats on sparc64 targets. Since the boot loader on sparc64 is >> supposed to be an a.out bi

[PATCH] configure.ac: Use nostdlib when checking for nostdinc

2019-03-25 Thread Vladimir 'phcoder' Serbinenko
>From 3269baa84c370e22a1cbda9b8cdeed7906b42631 Mon Sep 17 00:00:00 2001 From: Vladimir Serbinenko Date: Mon, 25 Mar 2019 16:09:04 +0100 Subject: [PATCH] configure.ac: Use nostdlib when checking for nostdinc With clang nostdinc behaviour is influenced by nostdlib. Since we always add nostdlib, add

[PATCH] hostfs: #undef open and close.

2019-03-25 Thread Vladimir 'phcoder' Serbinenko
>From 0cfd6226d200cce722e99230f5564e1bd9e45eff Mon Sep 17 00:00:00 2001 From: Vladimir Serbinenko Date: Mon, 25 Mar 2019 16:14:54 +0100 Subject: [PATCH] hostfs: #undef open and close. Unlike in case of disks in this case it's just a single place, so it's easier to just #undef Signed-off-by: Vlad

[PATCH v2] POTFILES: Don't include gnulib in grub.pot

2019-03-25 Thread Vladimir 'phcoder' Serbinenko
>From 25923d90b80709b11969cd56baddd8e898d7b9b5 Mon Sep 17 00:00:00 2001 From: Vladimir Serbinenko Date: Fri, 22 Mar 2019 16:06:18 +0100 Subject: [PATCH] POTFILES: Don't include gnulib in grub.pot They're translated as a separate project, so we don't want to submit them again. Signed-off-by: Vlad

Fwd: [PATCH] POTFILES: Don't include gnulib in grub.pot

2019-03-25 Thread Vladimir 'phcoder' Serbinenko
-- Forwarded message - From: Vladimir 'phcoder' Serbinenko Date: Mon, Mar 25, 2019 at 3:22 PM Subject: Re: [PATCH] POTFILES: Don't include gnulib in grub.pot To: Daniel Kiper On Mon, Mar 25, 2019 at 12:58 PM Daniel Kiper wrote: > > Sadly this patch does not look complete. ./gru

Re: [PATCH] Propagate GNU_PRINTF from gnulib vfprintf

2019-03-25 Thread Vladimir 'phcoder' Serbinenko
On Mon, Mar 25, 2019 at 1:24 PM Daniel Kiper wrote: > > On Fri, Mar 22, 2019 at 04:15:35PM +0100, Vladimir 'phcoder' Serbinenko wrote: > > From ce156e3274e53089b7a9ba432262b8aab75d8ad0 Mon Sep 17 00:00:00 2001 > > From: Vladimir Serbinenko > > Date: Fri, 22 Mar 2019 16:13:11 +0100 > > Subject: [P

Re: [PATCH] efi/tpm.c: Add missing casts

2019-03-25 Thread Vladimir 'phcoder' Serbinenko
On Mon, Mar 25, 2019 at 1:09 PM Daniel Kiper wrote: > > On Fri, Mar 22, 2019 at 04:11:10PM +0100, Vladimir 'phcoder' Serbinenko wrote: > > From 9443713c3d3403a21aac9b39de4bbd097a531dd4 Mon Sep 17 00:00:00 2001 > > From: Vladimir Serbinenko > > Date: Fri, 22 Mar 2019 16:07:47 +0100 > > Subject: [P

Re: [PATCH] Support R_PPC_PLTREL24

2019-03-25 Thread Daniel Kiper
On Fri, Mar 22, 2019 at 09:29:01PM +0100, Vladimir 'phcoder' Serbinenko wrote: > From 1a12f50ba9a32d616bcf6d6f4091dc4adc7ee74a Mon Sep 17 00:00:00 2001 > From: Vladimir Serbinenko > Date: Fri, 22 Mar 2019 21:24:24 +0100 > Subject: [PATCH] Support R_PPC_PLTREL24 > > It's emitted by clang 7. It's th

Re: [PATCH] msr: Add missing prototypes.

2019-03-25 Thread Daniel Kiper
On Fri, Mar 22, 2019 at 10:26:44PM +0100, Jesús Diéguez Fernández wrote: > Add the missing prototypes to rdmsr.h and wrmsr.h. This does not make sense. Please drop them. > Rearrange return values in the function declaration. I am OK with that. Please repost the patch. Daniel __

Re: [PATCH] efi/tpm.h: Fix hash_log_extend_event definition

2019-03-25 Thread Daniel Kiper
On Fri, Mar 22, 2019 at 05:33:10PM +0100, Vladimir 'phcoder' Serbinenko wrote: > From 444dd09eb75b7c0f1625925a107e0f0bb17ecba4 Mon Sep 17 00:00:00 2001 > From: Vladimir Serbinenko > Date: Fri, 22 Mar 2019 17:12:57 +0100 > Subject: [PATCH 2/3] efi/tpm.h: Fix hash_log_extend_event definition. > > I

Re: [PATCH] kern/emu/misc.c: Don't include config-util.h when running as GRUB_BUILD

2019-03-25 Thread Daniel Kiper
On Fri, Mar 22, 2019 at 11:54:45PM +, Colin Watson wrote: > Ah, this explains some strangeness I was seeing. Thanks. > > Reviewed-by: Colin Watson Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.

Re: [PATCH] Rename grub_disk members

2019-03-25 Thread Daniel Kiper
On Fri, Mar 22, 2019 at 11:52:10PM +, Colin Watson wrote: > On Fri, Mar 22, 2019 at 05:30:56PM +0100, Vladimir 'phcoder' Serbinenko wrote: > > Otherwise it horribly clashes with gnulib when it's > > replacing open/write/read/close > > Oh, good point, thanks. > > > @@ -341,7 +341,7 @@ grub_disk_

Re: [PATCH] grub-mkimagexx: Fix RISCV error message

2019-03-25 Thread Daniel Kiper
On Fri, Mar 22, 2019 at 05:29:35PM +0100, Vladimir 'phcoder' Serbinenko wrote: > From d46dda6f8890400a28ed7681b9b23c238abd1dca Mon Sep 17 00:00:00 2001 > From: Vladimir Serbinenko > Date: Fri, 22 Mar 2019 17:11:14 +0100 > Subject: [PATCH 1/3] grub-mkimagexx: Fix RISCV error message > > Outputting

Re: Build fails with missing save-cwd.h header

2019-03-25 Thread John Paul Adrian Glaubitz
On 3/25/19 12:34 PM, Daniel Kiper wrote: >> Before digging through code myself, I was wondering whether I am missing >> something >> obvious, although it looks like we're missing the include path being passed >> to >> the compiler where save-cwd.h is sitting in the source tree. > > Could you clo

Re: [PATCH] Propagate GNU_PRINTF from gnulib vfprintf

2019-03-25 Thread Daniel Kiper
On Fri, Mar 22, 2019 at 04:15:35PM +0100, Vladimir 'phcoder' Serbinenko wrote: > From ce156e3274e53089b7a9ba432262b8aab75d8ad0 Mon Sep 17 00:00:00 2001 > From: Vladimir Serbinenko > Date: Fri, 22 Mar 2019 16:13:11 +0100 > Subject: [PATCH] Propagate GNU_PRINTF from gnulib vfprintf > > gnulib now re

Re: [PATCH] efi/tpm.c: Add missing casts

2019-03-25 Thread Daniel Kiper
On Fri, Mar 22, 2019 at 04:11:10PM +0100, Vladimir 'phcoder' Serbinenko wrote: > From 9443713c3d3403a21aac9b39de4bbd097a531dd4 Mon Sep 17 00:00:00 2001 > From: Vladimir Serbinenko > Date: Fri, 22 Mar 2019 16:07:47 +0100 > Subject: [PATCH 2/2] efi/tpm.c: Add missing casts Have you seen any warning

Re: Build fails with missing save-cwd.h header

2019-03-25 Thread Colin Watson
On Mon, Mar 25, 2019 at 12:34:49PM +0100, Daniel Kiper wrote: > On Mon, Mar 25, 2019 at 10:50:30AM +0100, John Paul Adrian Glaubitz wrote: > > grub-core/osdep/unix/getroot.c:117:10: fatal error: save-cwd.h: No such > > file or directory > > #include "save-cwd.h" > > ^~~~ > > > >

Re: [PATCH] POTFILES: Don't include gnulib in grub.pot

2019-03-25 Thread Daniel Kiper
Sadly this patch does not look complete. ./grub-core/lib/gnulib is still included. And as Colin pointed out missing SOB. Could you send the patches in the email body instead of the attachments? git send-email? Daniel ___ Grub-devel mailing list Grub-de

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread Daniel Kiper
On Fri, Mar 22, 2019 at 07:35:55AM +0100, John Paul Adrian Glaubitz wrote: > Recent versions of binutils dropped support for the a.out and COFF > formats on sparc64 targets. Since the boot loader on sparc64 is > supposed to be an a.out binary and the a.out header entries are > rather simple to calc

Re: Build fails with missing save-cwd.h header

2019-03-25 Thread Daniel Kiper
On Mon, Mar 25, 2019 at 10:50:30AM +0100, John Paul Adrian Glaubitz wrote: > Hi! > > I'm currently test-building GRUB on various architectures to make sure it > builds > fine when 2.04 is released. Currently, I am always running into an issue with > the "save-cwd.h" header missing: > > grub-core/o

Build fails with missing save-cwd.h header

2019-03-25 Thread John Paul Adrian Glaubitz
Hi! I'm currently test-building GRUB on various architectures to make sure it builds fine when 2.04 is released. Currently, I am always running into an issue with the "save-cwd.h" header missing: grub-core/osdep/unix/getroot.c:117:10: fatal error: save-cwd.h: No such file or directory #include