Re: [PATCH V10] Add support for BTRFS raid5/6 to GRUB

2018-10-22 Thread Nick Terrell
> On Oct 22, 2018, at 4:02 AM, Daniel Kiper wrote: > > On Thu, Oct 18, 2018 at 07:55:32PM +0200, Goffredo Baroncelli wrote: >> >> Hi All, >> >> the aim of this patches set is to provide support for a BTRFS raid5/6 >> filesystem in GRUB. >> >> The first patch, implements the basic support fo

[PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile.

2018-10-22 Thread Goffredo Baroncelli
From: Goffredo Baroncelli Signed-off-by: Goffredo Baroncelli Signed-off-by: Daniel Kiper Reviewed-by: Daniel Kiper --- grub-core/fs/btrfs.c | 73 1 file changed, 73 insertions(+) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c index be195

[PATCH 9/9] btrfs: Add RAID 6 recovery for a btrfs filesystem.

2018-10-22 Thread Goffredo Baroncelli
From: Goffredo Baroncelli Add the RAID 6 recovery, in order to use a RAID 6 filesystem even if some disks (up to two) are missing. This code use the md RAID 6 code already present in grub. Signed-off-by: Goffredo Baroncelli Reviewed-by: Daniel Kiper --- grub-core/fs/btrfs.c | 60 +

[PATCH 7/9] btrfs: Add support for recovery for a RAID 5 btrfs profiles.

2018-10-22 Thread Goffredo Baroncelli
From: Goffredo Baroncelli Add support for recovery for a RAID 5 btrfs profile. In addition it is added some code as preparatory work for RAID 6 recovery code. Signed-off-by: Goffredo Baroncelli Reviewed-by: Daniel Kiper --- grub-core/fs/btrfs.c | 159 +-

[PATCH 6/9] btrfs: Refactor the code that read from disk

2018-10-22 Thread Goffredo Baroncelli
From: Goffredo Baroncelli Move the code in charge to read the data from disk into a separate function. This helps to separate the error handling logic (which depends on the different raid profiles) from the read from disk logic. Refactoring this code increases the general readability too. This i

[PATCH 3/9] btrfs: Move the error logging from find_device() to its caller.

2018-10-22 Thread Goffredo Baroncelli
From: Goffredo Baroncelli The caller knows better if this error is fatal or not, i.e. another disk is available or not. This is a preparatory patch. Signed-off-by: Goffredo Baroncelli Reviewed-by: Daniel Kiper --- grub-core/fs/btrfs.c | 10 -- 1 file changed, 4 insertions(+), 6 delet

[PATCH 8/9] btrfs: Make more generic the code for RAID 6 rebuilding

2018-10-22 Thread Goffredo Baroncelli
From: Goffredo Baroncelli The original code which handles the recovery of a RAID 6 disks array assumes that all reads are multiple of 1 << GRUB_DISK_SECTOR_BITS and it assumes that all the I/O is done via the struct grub_diskfilter_segment. This is not true for the btrfs code. In order to reuse t

[PATCH 4/9] btrfs: Avoid a rescan for a device which was already not found.

2018-10-22 Thread Goffredo Baroncelli
From: Goffredo Baroncelli Currently read from missing device triggers rescan. However, it is never recorded that the device is missing. So, each read of a missing device triggers rescan again and again. This behavior causes a lot of unneeded rescans leading to huge slowdowns. This patch fixes ab

Re: [PATCH V10] Add support for BTRFS raid5/6 to GRUB

2018-10-22 Thread Goffredo Baroncelli
On 22/10/2018 13.02, Daniel Kiper wrote: > On Thu, Oct 18, 2018 at 07:55:32PM +0200, Goffredo Baroncelli wrote: >> >> Hi All, >> >> the aim of this patches set is to provide support for a BTRFS raid5/6 >> filesystem in GRUB. [...] > > In general whole patch series LGTM. +/- some nit picks includin

[PATCH 5/9] btrfs: Move logging code in grub_btrfs_read_logical()

2018-10-22 Thread Goffredo Baroncelli
From: Goffredo Baroncelli A portion of the logging code is moved outside of internal for(;;). The part that is left inside is the one which depends on the internal for(;;) index. This is a preparatory patch. The next one will refactor the code inside the for(;;) into an another function. Signed

[PATCH V11] Add support for BTRFS raid5/6 to GRUB

2018-10-22 Thread Goffredo Baroncelli
Hi All, the aim of this patches set is to provide support for a BTRFS raid5/6 filesystem in GRUB. The first patch, implements the basic support for raid5/6. I.e this works when all the disks are present. The next 5 patches, are preparatory ones. The 7th patch implements the raid5 recovery fo

[PATCH 2/9] btrfs: Add helper to check the btrfs header.

2018-10-22 Thread Goffredo Baroncelli
From: Goffredo Baroncelli This helper is used in a few places to help the debugging. As conservative approach the error is only logged. This does not impact the error handling. Signed-off-by: Goffredo Baroncelli Reviewed-by: Daniel Kiper --- grub-core/fs/btrfs.c | 24 +++-

Re: [PATCH v2 13/18] xen: init memory regions for PVH

2018-10-22 Thread Daniel Kiper
On Mon, Oct 22, 2018 at 01:43:53PM +0200, Juergen Gross wrote: > On 22/10/2018 13:31, Daniel Kiper wrote: > > On Tue, Oct 09, 2018 at 01:03:12PM +0200, Juergen Gross wrote: > >> Add all usable memory regions to grub memory management and add the > >> needed mmap iterate code. > > > > I am missing a

Re: [PATCH v2 18/18] xenpvh: add support to configure

2018-10-22 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:17PM +0200, Juergen Gross wrote: > Support platform i386/xenpvh in configure. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper +/- XENPVH/xenpvh play still Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mai

Re: [PATCH v2 17/18] xenpvh: support grub-install for xenpvh

2018-10-22 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:16PM +0200, Juergen Gross wrote: > Add xenpvh support to grub-install. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper +/- XENPVH play still Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub

Re: [PATCH v2 16/18] xenpvh: support building a standalone image

2018-10-22 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:15PM +0200, Juergen Gross wrote: > Support mkimage for xenpvh. > > In order to avoid using plain integers for the ELF notes use the > available Xen include instead. While at it replace the plain numbers > for Xen PV mode, too. > > Signed-off-by: Juergen Gross +/- XEN

Re: [PATCH v2 14/18] xenpvh: add build runes for grub-core

2018-10-22 Thread Juergen Gross
On 22/10/2018 13:41, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:13PM +0200, Juergen Gross wrote: >> Add the modifications to the build system needed to build a xenpvh >> grub. >> >> Signed-off-by: Juergen Gross >> Reviewed-by: Daniel Kiper >> --- >> gentpl.py | 4 ++--

Re: [PATCH v2 15/18] grub-module-verifier: Ignore all_video for xenpvh

2018-10-22 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:14PM +0200, Juergen Gross wrote: > From: Hans van Kranenburg > > This solves the build failing with "Error: no symbol table and no > .moddeps section" > > Also see: > - 6371e9c10433578bb236a8284ddb9ce9e201eb59 > - https://savannah.gnu.org/bugs/?49012 > > Signed-off-by

Re: [PATCH v2 13/18] xen: init memory regions for PVH

2018-10-22 Thread Juergen Gross
On 22/10/2018 13:31, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:12PM +0200, Juergen Gross wrote: >> Add all usable memory regions to grub memory management and add the >> needed mmap iterate code. > > I am missing a few words why this patch is needed. Especially why > grub_machine_mmap_it

Re: [PATCH v2 14/18] xenpvh: add build runes for grub-core

2018-10-22 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:13PM +0200, Juergen Gross wrote: > Add the modifications to the build system needed to build a xenpvh > grub. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel Kiper > --- > gentpl.py | 4 ++-- > grub-core/Makefile.am | 12

Re: [PATCH v2 13/18] xen: init memory regions for PVH

2018-10-22 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:12PM +0200, Juergen Gross wrote: > Add all usable memory regions to grub memory management and add the > needed mmap iterate code. I am missing a few words why this patch is needed. Especially why grub_machine_mmap_iterate() has to belong to this patch. However, I thi

Re: [Xen-devel] [PATCH v2 09/18] xen: add PVH boot entry code

2018-10-22 Thread Daniel Kiper
On Fri, Oct 19, 2018 at 04:50:25PM +0200, Juergen Gross wrote: > On 19/10/2018 14:17, Daniel Kiper wrote: > > On Tue, Oct 09, 2018 at 01:03:08PM +0200, Juergen Gross wrote: > >> Add the code for the Xen PVH mode boot entry. > >> > >> Signed-off-by: Juergen Gross > >> --- > >> grub-core/kern/i386/

Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-22 Thread Juergen Gross
On 22/10/2018 13:16, Daniel Kiper wrote: > On Fri, Oct 19, 2018 at 05:52:44PM +0200, Juergen Gross wrote: >> On 19/10/2018 17:33, Roger Pau Monné wrote: >>> On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: Add the hooks to current code needed for Xen PVH. Signed-off-by:

Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-22 Thread Daniel Kiper
On Fri, Oct 19, 2018 at 05:52:44PM +0200, Juergen Gross wrote: > On 19/10/2018 17:33, Roger Pau Monné wrote: > > On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: > >> Add the hooks to current code needed for Xen PVH. > >> > >> Signed-off-by: Juergen Gross > >> --- > >> grub-core/ker

Re: [PATCH V10] Add support for BTRFS raid5/6 to GRUB

2018-10-22 Thread Daniel Kiper
On Thu, Oct 18, 2018 at 07:55:32PM +0200, Goffredo Baroncelli wrote: > > Hi All, > > the aim of this patches set is to provide support for a BTRFS raid5/6 > filesystem in GRUB. > > The first patch, implements the basic support for raid5/6. I.e this works when > all the disks are present. > > The ne

Re: [PATCH 7/9] btrfs: Add support for recovery for a RAID 5 btrfs profiles.

2018-10-22 Thread Daniel Kiper
On Thu, Oct 18, 2018 at 07:55:39PM +0200, Goffredo Baroncelli wrote: > From: Goffredo Baroncelli > > Add support for recovery for a RAID 5 btrfs profile. In addition > it is added some code as preparatory work for RAID 6 recovery code. > > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/