[PATCH 0/1] grub-fs-tester: fix losetup race

2018-06-15 Thread Will Thompson
On a build server where other jobs are making use of loop devices, we occasionally see GRUB's filesystem tests failing with errors like: losetup: /tmp/tmp.uMgVEh1vvn/ext2_old_256_1024_1_0.img: failed to set up loop device: Device or resource busy This is because grub-fs-tester runs `losetup -

[PATCH 1/1] grub-fs-tester: fix losetup race

2018-06-15 Thread Will Thompson
If something else on the system is using loopback devices, then the device that's free at the call to `losetup -f` may not be free in the following call to try to use it. Instead, find and use the first free loopback device in a single call to losetup. --- tests/util/grub-fs-tester.in | 3 +-- 1 f

AW: Grub2 EFI: compatibility with wimboot

2018-06-15 Thread jame88fane
Okay, wimboot works in Grub2 Legacy for example: # Successfully boots menuentry "Windows 7" { set ISOpath="/img/windows_7.iso" loopback loop $ ISOpath linux16 /boot/wimboot/wimboot initrd16 \ newc:bootmgr:(loop)/bootmgr \ newc:bcd:(lo

Re: [PATCH v2] ieee1275: obdisk driver

2018-06-15 Thread Eric Snowberg
> On Jun 15, 2018, at 6:02 AM, Daniel Kiper wrote: > > On Wed, May 30, 2018 at 04:55:22PM -0700, Eric Snowberg wrote: >> Add a new disk driver called obdisk for IEEE1275 platforms. Currently >> the only platform using this disk driver is SPARC, however other IEEE1275 >> platforms could start us

Re: [PATCH v2] ieee1275: obdisk driver

2018-06-15 Thread Daniel Kiper
On Fri, Jun 15, 2018 at 02:05:32PM +0200, John Paul Adrian Glaubitz wrote: > On 06/15/2018 02:02 PM, Daniel Kiper wrote: > >> +static int disks_enumerated = 0; > >> +static struct disk_dev *disk_devs = NULL; > >> +static struct parent_dev *parent_devs = NULL; > > > > I would drop all these 0/NULL i

Re: Grub2 EFI: compatibility with wimboot

2018-06-15 Thread Daniel Kiper
Hi, On Tue, Jun 05, 2018 at 08:25:53PM +0200, jame88f...@gmx.de wrote: > Hello, > > I wanted to ask if it would be possible to make the compatibility with > wimboot in Grub2 EFI? currently only legacy works. > > http://ipxe.org/wimboot > > that would be really nice. We are happy to help but first

Re: [PATCH v2] ieee1275: obdisk driver

2018-06-15 Thread John Paul Adrian Glaubitz
On 06/15/2018 02:02 PM, Daniel Kiper wrote: >> +static int disks_enumerated = 0; >> +static struct disk_dev *disk_devs = NULL; >> +static struct parent_dev *parent_devs = NULL; > > I would drop all these 0/NULL initializations. > Compiler will do work for you. I asked about > that in earlier comme

Re: [PATCH v2] ieee1275: obdisk driver

2018-06-15 Thread Daniel Kiper
On Wed, May 30, 2018 at 04:55:22PM -0700, Eric Snowberg wrote: > Add a new disk driver called obdisk for IEEE1275 platforms. Currently > the only platform using this disk driver is SPARC, however other IEEE1275 > platforms could start using it if they so choose. While the functionality > within t

Re: [PATCH 0/2] efi/fdt: set #address-cells/#size-cells on empty tree

2018-06-15 Thread Daniel Kiper
On Thu, Jun 14, 2018 at 04:37:34PM +0100, Leif Lindholm wrote: > On Thu, Jun 14, 2018 at 03:38:13PM +0200, Daniel Kiper wrote: > > On Mon, Jun 11, 2018 at 05:24:57PM +0100, Leif Lindholm wrote: > > > Set #address-cells and #size-cells properties (to 2) for ARM*/UEFI > > > systems when creating an e