On 06/15/2018 02:02 PM, Daniel Kiper wrote:
>> +static int disks_enumerated = 0;
>> +static struct disk_dev *disk_devs = NULL;
>> +static struct parent_dev *parent_devs = NULL;
> 
> I would drop all these 0/NULL initializations.
> Compiler will do work for you. I asked about
> that in earlier comments.

Not sure about that though. I seem to remember that newer gcc versions
were quite nitpicky about that when building with -Werror and I had
to add a NULL initialization to get it to build.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to