Making TODO first

2018-05-14 Thread Inzo Abe
Good day, I am trying to improve grub. Coukd you pls help me. Thank you! Serik Almaty, KZ ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 7/8] Make more generic the code for raid6 rebuilding

2018-05-14 Thread Goffredo Baroncelli
On 05/14/2018 08:57 PM, Daniel Kiper wrote: > On Fri, May 11, 2018 at 09:24:45PM +0200, Goffredo Baroncelli wrote: [...] > >> +char *buf, grub_uint64_t sector, grub_size_t size, >> +raid_recover_read_t read_func, int layout) > > s/read_func/read_nod

[PATCH] mbi: use per segment a separate relocator chunk

2018-05-14 Thread Alexander Boettcher
-- Alexander Boettcher Genode Labs http://www.genode-labs.com - http://www.genode.org Genode Labs GmbH - Amtsgericht Dresden - HRB 28424 - Sitz Dresden Geschäftsführer: Dr.-Ing. Norman Feske, Christian Helmuth >From 8a0296d040a42950cd64e733f7997203975bc184 Mon Sep 17 00:00:00 2001 From: Alexand

xfsprogs 4.16.0 format change, GRUB error unknown filesystem

2018-05-14 Thread Chris Murphy
Hi, xfsprogs 4.16.0 defaults to enabling "sparse inode" which is not compatible with GRUB. Downstream bug in Fedora, grub-probe fails so grub-install can't work; and on systems with an already properly installed core.img with XFS support, it can't read an XFS file system with this feature set. ht

Re: [PATCH 7/8] Make more generic the code for raid6 rebuilding

2018-05-14 Thread Daniel Kiper
On Mon, May 14, 2018 at 08:57:10PM +0200, Daniel Kiper wrote: > On Fri, May 11, 2018 at 09:24:45PM +0200, Goffredo Baroncelli wrote: > > The original grub code which handles the recovery of a raid6 disks array > > assumes that all the read are multiple of 1 << GRUB_DISK_SECTOR_BITS and > > s/the re

Re: [PATCH 8/8] Add raid6 recovery for a btrfs filesystem.

2018-05-14 Thread Daniel Kiper
On Fri, May 11, 2018 at 09:24:46PM +0200, Goffredo Baroncelli wrote: > Add the raid6 recovery, in order to use a raid6 filesystem even if some > disks (up to two) are missing. > This code use the old md raid6 code already present in grub. Please fix the commit message formating. > Signed-off-by:

Re: [PATCH 7/8] Make more generic the code for raid6 rebuilding

2018-05-14 Thread Daniel Kiper
On Fri, May 11, 2018 at 09:24:45PM +0200, Goffredo Baroncelli wrote: > The original grub code which handles the recovery of a raid6 disks array > assumes that all the read are multiple of 1 << GRUB_DISK_SECTOR_BITS and s/the read/reads/ > it also assumes that all the I/O is done via the struct >

Re: [PATCH 5/8] Refactor the code that read from disk

2018-05-14 Thread Daniel Kiper
On Mon, May 14, 2018 at 08:26:40PM +0200, Daniel Kiper wrote: > It looks that patch 4 is missing in this series. > > On Fri, May 11, 2018 at 09:24:43PM +0200, Goffredo Baroncelli wrote: > > This is a preparatory patch, to help the adding of the raid5/6 recovery > > code. > > In case of availabilit

Re: [PATCH 6/8] Add support for recovery for a raid5 btrfs profiles.

2018-05-14 Thread Daniel Kiper
On Fri, May 11, 2018 at 09:24:44PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 178 +-- > 1 file changed, 173 insertions(+), 5 deletions(-) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.

Re: [PATCH 5/8] Refactor the code that read from disk

2018-05-14 Thread Daniel Kiper
It looks that patch 4 is missing in this series. On Fri, May 11, 2018 at 09:24:43PM +0200, Goffredo Baroncelli wrote: > This is a preparatory patch, to help the adding of the raid5/6 recovery code. > In case of availability of all disks, this code is good for all the RAID > profiles. However in ca

Re: [PATCH 3/8] Move the error logging logic from find_device() to the callee.

2018-05-14 Thread Daniel Kiper
On Fri, May 11, 2018 at 09:24:41PM +0200, Goffredo Baroncelli wrote: > This is a preparatory patch. The callee knows better if this > error is fatal, or if it exists another available disk. WRT the subject: s/Move the error logging logic from find_device() to the callee./ Move the error logg

Re: [PATCH 2/8] Add helper to check the btrfs header.

2018-05-14 Thread Daniel Kiper
On Fri, May 11, 2018 at 09:24:40PM +0200, Goffredo Baroncelli wrote: > This helper was used in few places to help the debugging. As conservative s/was/will be/? > approach, in case of error it is only logged. This because I was unaware s/This because I was unaware/This is because I am not sure/

Re: [PATCH 1/8] Add support for reading a filesystem with a raid5 or raid6 profile.

2018-05-14 Thread Daniel Kiper
On Fri, May 11, 2018 at 09:24:39PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 61 > 1 file changed, 61 insertions(+) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c > index be19544

Re: [PATCH] Enable /dev/mapper/dm-[0-9]-* scanning

2018-05-14 Thread Daniel Kiper
On Fri, May 11, 2018 at 02:32:48PM +0300, Oleg Solovyov wrote: > Thanks for review > New version is attached > > From 19e3f13632a20a0b1be12b6d6ff4c52ba4f3b4d6 Mon Sep 17 00:00:00 2001 > From: Oleg Solovyov > Date: Fri, 11 May 2018 13:55:46 +0300 > Subject: [PATCH] Don't skip /dev/mapper/dm-* devic