On Fri, May 11, 2018 at 09:24:41PM +0200, Goffredo Baroncelli wrote: > This is a preparatory patch. The callee knows better if this > error is fatal, or if it exists another available disk.
WRT the subject: s/Move the error logging logic from find_device() to the callee./ Move the error logging from find_device() to its caller/? And it seems to me that every email's subject should start with "btrfs: ", e.g. "btrfs: Move the error logging from find_device() to its caller". s/error is fatal, or if it exists another available disk/ error is fatal or not, i.e. another disk is available./ Otherwise LGTM. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel