Re: grub2-probe confused by double bind mount?

2017-08-07 Thread Chris Murphy
On Mon, Aug 7, 2017 at 9:09 AM, Vladimir 'phcoder' Serbinenko wrote: > Upstream doesn't use grub2 prefix. Please try with latest upstream and make > sure it's compiled with libdevmapper Same result with current git as of today. [chris@f26wnuc grub]$ ./configure --build=x86_64 --host=x86_64 --wi

Re: [PATCHv2 2/3] core: use GRUB_TERM_ definitions when handling term characters

2017-08-07 Thread Pete Batard
On 2017.08.07 18:29, Vladimir 'phcoder' Serbinenko wrote: In several places it was misused. I've thrown them away and committed the rest Looks good. Thanks. /Pete ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/

Re: [PATCHv2 3/3] io: add a GRUB_GZ prefix to gzio specific defines

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
Committed Le Mon, Aug 7, 2017 à 6:23 PM, Pete Batard a écrit : > As requested, this new proposal uses GRUB_GZ_ instead of GZ_ as the new > prefix. > > Regards, > > /Pete > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailm

Re: [PATCHv2 2/3] core: use GRUB_TERM_ definitions when handling term characters

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
Le Mon, Aug 7, 2017 à 6:22 PM, Pete Batard a écrit : > This is the updated proposal from the original "[PATCH 2/3] crypto: > switch nonstandard escape sequence to its hex value". > > Following up on Vladimir's comments, I decided to look up all the GRUB > sources where key/term entries were being

Re: [PATCH v2 14/14] efi: change heap allocation type to GRUB_EFI_LOADER_CODE

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
It means that the patch is fine but something else stops it from being committed. In this case I wanted to go through the whole stack first Le Mon, Aug 7, 2017 à 6:19 PM, Konrad Rzeszutek Wilk a écrit : > On Mon, Aug 07, 2017 at 02:11:16PM +, Vladimir 'phcoder' Serbinenko > wrote: > > LGTM >

Re: [PATCHv2 3/3] io: add a GRUB_GZ prefix to gzio specific defines

2017-08-07 Thread Pete Batard
As requested, this new proposal uses GRUB_GZ_ instead of GZ_ as the new prefix. Regards, /Pete From de3f6990c7705dd66b608684066b35ce3f0628e4 Mon Sep 17 00:00:00 2001 From: Pete Batard Date: Mon, 7 Aug 2017 16:23:12 +0100 Subject: [PATCH 3/3] io: add a GRUB_GZ prefix to gzio specific defines *

Re: [PATCHv2 2/3] core: use GRUB_TERM_ definitions when handling term characters

2017-08-07 Thread Pete Batard
This is the updated proposal from the original "[PATCH 2/3] crypto: switch nonstandard escape sequence to its hex value". Following up on Vladimir's comments, I decided to look up all the GRUB sources where key/term entries were being compared to '\e', and replaced those with GRUB_TERM_ESC, wi

Re: [PATCH v2 14/14] efi: change heap allocation type to GRUB_EFI_LOADER_CODE

2017-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 07, 2017 at 02:11:16PM +, Vladimir 'phcoder' Serbinenko wrote: > LGTM Is LGTM equivalant to Acked-by? > > Le Thu, Aug 3, 2017 à 12:09 PM, Leif Lindholm a > écrit : > > > With upcoming changes to EDK2, allocations of type EFI_LOADER_DATA may > > not return regions with execute a

Re: Writing support for Yubikey in Grub?

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
Le Mon, Jun 12, 2017 à 12:11 AM, Andrew Ross a écrit : > I'm contemplating an attempt at writing a module to enable use of the > challenge-response feature of the Yubikey to provide part of the > passphrase for a luks partition, using grub to do the initial > decryption. I'm after some advice on

Re: grub-mkrescue reacts vaguely on xorriso problems

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
Fixed both problems Le Sat, Jul 15, 2017 à 12:26 PM, Thomas Schmitt a écrit : > Hi, > > Ping. > > (Bug or feature ? If bug: what exactly would be the desirable behavior ?) > > -- > Date: Wed, 14 Jun 2017 11:37:11 +0200 > Fro

Re: [PATCH v2] * grub-core/fs/udf.c: Add support for UUID

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
Committed with few fixes. Thanks Le Thu, Jun 22, 2017 à 2:42 PM, Pali Rohár a écrit : > Use same algorithm as in libblkid from util-linux v2.30. > > 1. Take first 16 bytes from UTF-8 encoded string of VolumeSetIdentifier > 2. If all bytes are hexadecimal digits, convert to lowercase and use as >

Re: [PATCH] * grub-core/fs/udf.c: Fix reading label, lvd.ident is dstring

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
Committed with fixes and simplifications. The biggest problem was lack of check whether grub_malloc succeeded Le Thu, Jun 22, 2017 à 2:34 PM, Pali Rohár a écrit : > UDF dstring has stored length in the last byte of buffer. Therefore last > byte is not part of recorded characters. And empty strin

Re: grub2-probe confused by double bind mount?

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
Upstream doesn't use grub2 prefix. Please try with latest upstream and make sure it's compiled with libdevmapper On Mon, Aug 7, 2017, 08:57 Chris Murphy wrote: > It's not the double bind mount. I've removed it by eliminating the -o > subvol option and adjusted paths accordingly during assembly.

Re: [PATCH 1/3] zfs: remove size_t typedef and use grub_size_t instead

2017-08-07 Thread Pete Batard
Thanks. I'll submit a v2 for 2 & 3 shortly, as per your comments. Regards, /Pete On 2017.08.07 15:26, Vladimir 'phcoder' Serbinenko wrote: Committed, thanks Le Thu, Aug 3, 2017 à 6:12 PM, Pete Batard > a écrit : Regards, /Pete __

Re: [PATCH] ehci: fix build error of print format specifier

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
Fixed in 284afab081ef7ed7db2c59151853aa3c92d988f2 Le Tue, Jun 13, 2017 à 8:52 AM, Michael Chang a écrit : > It is introduced by commit e058df7b5a9cc7aaa9872eaa916b715544a8f9840, use > PRIxGRUB_ADDR as format specfier to fix the portability problem. > --- > grub-core/bus/usb/ehci.c | 4 ++-- > 1

Re: Decrypt AES(rijndael) file

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
Le Mon, Jul 10, 2017 à 8:38 PM, Rafael Machado < rafaelrodrigues.mach...@gmail.com> a écrit : > Hi everyone > > I need to find a way to decrypt a file at grub, and this file is encrypted > as AES256 (rijndael). > > This is far from being a complete task description. What do you want to do with dec

Re: [PATCH 3/3] io: add a GZ prefix to gzio specific defines

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
If you're already changing it could you used GRUB_GZ_ rather than GZ_ prefix? Le Thu, Aug 3, 2017 à 6:13 PM, Pete Batard a écrit : > Regards, > > /Pete > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-d

Re: [PATCH 1/3] zfs: remove size_t typedef and use grub_size_t instead

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
Committed, thanks Le Thu, Aug 3, 2017 à 6:12 PM, Pete Batard a écrit : > Regards, > > /Pete > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > ___ Grub-

Re: [PATCH 2/3] crypto: switch nonstandard escape sequence to its hex value

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
Please change this place to rather use GRUB_TERM_ESC and then change GRUB_TERM_ESC definition Le Thu, Aug 3, 2017 à 6:13 PM, Pete Batard a écrit : > Regards, > > /Pete > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman

Re: [tuellm...@kit.edu: Bug#866603: grub-common: enabling metadata_csum_seed feature on ext4 renders system unbootable]

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
Makes sense. Go ahead with ignoring this flag Le Fri, Jun 30, 2017 à 2:50 PM, Colin Watson a écrit : > On Fri, Jun 30, 2017 at 12:43:02PM +, Vladimir 'phcoder' Serbinenko > wrote: > > пт, 30 июн. 2017 г., 14:38 Colin Watson : > > > Could we possibly just ignore this feature for GRUB? For be

Re: [PATCH v2 14/14] efi: change heap allocation type to GRUB_EFI_LOADER_CODE

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
LGTM Le Thu, Aug 3, 2017 à 12:09 PM, Leif Lindholm a écrit : > With upcoming changes to EDK2, allocations of type EFI_LOADER_DATA may > not return regions with execute ability. Since modules are loaded onto > the heap, change the heap allocation type to GRUB_EFI_LOADER_CODE in > order to permit

Re: [PATCH v2 13/14] efi: restrict arm/arm64 linux loader initrd placement

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
LGTM Le Thu, Aug 3, 2017 à 12:15 PM, Leif Lindholm a écrit : > The 32-bit arm Linux kernel is built as a zImage, which self-decompresses > down to near start of RAM. In order for an initrd/initramfs to be > accessible, it needs to be placed within the first ~768MB of RAM. > The initrd loader bui

Re: [PATCH v2 12/14] arm: delete unused efi support from loader/arm

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
LGTM Le Thu, Aug 3, 2017 à 12:11 PM, Leif Lindholm a écrit : > The 32-bit arm efi port now shares the 64-bit linux loader, so delete > the now unused bits from the 32-bit linux loader. > > This in turn leaves the grub-core/kern/arm/efi/misc.c unused, so > delete that too. > > Signed-off-by: Leif

Re: [PATCH v2 11/14] arm/efi: switch to arm64 linux loader

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
Le Thu, Aug 3, 2017 à 12:10 PM, Leif Lindholm a écrit : > Switch over to the EFI-stub aware arm64 loader for 32-bit ARM platforms. > > Signed-off-by: Leif Lindholm > --- > grub-core/Makefile.core.def | 6 +++--- > grub-core/kern/efi/mm.c | 2 +- > include/grub/efi/efi.h | 2 -- > 3 fil

Re: [PATCH v2 10/14] loader: switch arm/linux to grub_linux_kernel_header struct

2017-08-07 Thread Vladimir 'phcoder' Serbinenko
Le Thu, Aug 3, 2017 à 12:15 PM, Leif Lindholm a écrit : > Use kernel header struct and generic magic definition to align with > arm64/linux loader. > > Signed-off-by: Leif Lindholm > --- > grub-core/loader/arm/linux.c | 11 +-- > include/grub/arm/linux.h | 15 --- > 2 fi

Re: grub2-probe confused by double bind mount?

2017-08-07 Thread Xen
Chris Murphy schreef op 07-08-2017 8:56: The non-working case looks like it starts failing after line 213, openat /proc/self/mountinfo as if whatever it finds there is not at all helpful. The only similar thing I ever experienced is when my system inside a chroot actually had a line filtering