Le Mon, Aug 7, 2017 à 6:22 PM, Pete Batard <p...@akeo.ie> a écrit :
> This is the updated proposal from the original "[PATCH 2/3] crypto: > switch nonstandard escape sequence to its hex value". > > Following up on Vladimir's comments, I decided to look up all the GRUB > sources where key/term entries were being compared to '\e', and replaced > those with GRUB_TERM_ESC, with GRUB_TERM_ESC changed to use a hex value. > > To be consistent, since we also have definitions for GRUB_TERM_BACKSPACE > and GRUB_TERM_TAB in term.h, this patch also replaces '\b' and '\t' > where appropriate (i.e. mostly for keypress validation, but not for > printed output). In several places it was misused. I've thrown them away and committed the rest > Obviously the result is that quite a few more files are > affected compared to the original patch. > > As per this proposal, the only files that are still being left with '\e' > sequences are argp-fmtstream.c in gnulib, since I'm not too sure of its > use and thought it better to leave it alone, as well as terminfo.c which > also contains a series of Escape sequences (e.g. "\e[H\e[J") that I'm > not too concerned about. > > The last thing I'll point out is that, because term.h is included as > part of normal.h, there wasn't any need to add new #include directives > for the GRUB_TERM_ defs. Of course, this patch was also validated to > confirm it doesn't break compilation. > > Regards, > > /Pete > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
