Re: [PATCH 1/3] push/pop errno in initrd read file path

2016-03-11 Thread Andrei Borzenkov
12.03.2016 01:00, Vladimir 'phcoder' Serbinenko пишет: > On Friday, March 11, 2016, Josef Bacik wrote: > >> On 03/11/2016 02:34 PM, Vladimir 'phcoder' Serbinenko wrote: >> >>> >>> >>> Le ven. 11 mars 2016 19:13, Josef Bacik >> > a écrit : >>> >>> On 03/11/2016 12:23 PM,

Re: [PATCH 3/3] pxenet: process transmit interrupts when out of resources

2016-03-11 Thread Andrei Borzenkov
11.03.2016 19:28, Josef Bacik пишет: > We were hitting a problem in production where our bios based machines would > sometimes timeout while pulling down either the kernel/initrd. It turned out > that sometimes we'd run out of transmit buffers and would then error out while > sending packets. Thi

Re: [PATCH 1/3] push/pop errno in initrd read file path

2016-03-11 Thread Vladimir 'phcoder' Serbinenko
On Friday, March 11, 2016, Josef Bacik wrote: > On 03/11/2016 02:34 PM, Vladimir 'phcoder' Serbinenko wrote: > >> >> >> Le ven. 11 mars 2016 19:13, Josef Bacik > > a écrit : >> >> On 03/11/2016 12:23 PM, Vladimir 'phcoder' Serbinenko wrote: >> > >> > >> >

Re: [GRUB2 PATCH v3 1/4] i386/relocator: Add grub_relocator64_efi relocator

2016-03-11 Thread Daniel Kiper
On Fri, Mar 11, 2016 at 04:42:27PM +0100, Vladimir 'phcoder' Serbinenko wrote: > On Friday, March 11, 2016, Daniel Kiper wrote: > > > On Thu, Mar 10, 2016 at 09:23:23PM +0100, Vladimir 'phcoder' Serbinenko > > wrote: > > > On Wednesday, March 2, 2016, Daniel Kiper > > wrote: > > > > > > > Add gru

Re: [GRUB2 PATCH v3 4/4] multiboot2: Add support for relocatable images

2016-03-11 Thread Daniel Kiper
On Thu, Mar 10, 2016 at 09:44:31PM +0100, Vladimir 'phcoder' Serbinenko wrote: > On Wednesday, March 2, 2016, Daniel Kiper wrote: > > > Currently multiboot2 protocol loads image exactly at address specified in > > ELF or multiboot2 header. This solution works quite well on legacy BIOS > > platform

Re: [GRUB2 PATCH v3 0/4] multiboot2: Add two extensions

2016-03-11 Thread Vladimir 'phcoder' Serbinenko
On Friday, March 11, 2016, Daniel Kiper wrote: > On Fri, Mar 11, 2016 at 01:27:32PM +0100, Vladimir 'phcoder' Serbinenko > wrote: > > On Wednesday, March 9, 2016, Daniel Kiper > wrote: > > > > > On Wed, Mar 02, 2016 at 05:51:36PM +0100, Daniel Kiper wrote: > > > > Hi, > > > > > > > > This patch

Re: [GRUB2 PATCH v3 0/4] multiboot2: Add two extensions

2016-03-11 Thread Daniel Kiper
On Fri, Mar 11, 2016 at 06:33:15PM +0100, Vladimir 'phcoder' Serbinenko wrote: > On Friday, March 11, 2016, Daniel Kiper wrote: > > > On Fri, Mar 11, 2016 at 04:44:00PM +0100, Vladimir 'phcoder' Serbinenko > > wrote: > > > > [...] > > > > > multiboot2 spec is a rolling update. > > > > OK. So, I th

Re: [GRUB2 PATCH v3 2/4] multiboot2: Add tags used to pass ImageHandle to loaded image

2016-03-11 Thread Vladimir 'phcoder' Serbinenko
On Friday, March 11, 2016, Daniel Kiper wrote: > On Thu, Mar 10, 2016 at 09:26:06PM +0100, Vladimir 'phcoder' Serbinenko > wrote: > > On Wednesday, March 2, 2016, Daniel Kiper > wrote: > > > > > Add tags used to pass ImageHandle to loaded image if requested. > > > It is used by at least ExitBoot

Re: [GRUB2 PATCH v3 4/4] multiboot2: Add support for relocatable images

2016-03-11 Thread Vladimir 'phcoder' Serbinenko
> > > > > + if (relocatable) > > > +{ > > > + if (base_addr > min_addr) > > > + grub_multiboot_payload_eip += base_addr - min_addr; > > > + else > > > + grub_multiboot_payload_eip -= min_addr - base_addr; > > > +} > > > + > > > > > Why is it relative to min_addr? Soun

Re: [GRUB2 PATCH v3 1/4] i386/relocator: Add grub_relocator64_efi relocator

2016-03-11 Thread Vladimir 'phcoder' Serbinenko
On Friday, March 11, 2016, Daniel Kiper wrote: > On Thu, Mar 10, 2016 at 09:23:23PM +0100, Vladimir 'phcoder' Serbinenko > wrote: > > On Wednesday, March 2, 2016, Daniel Kiper > wrote: > > > > > Add grub_relocator64_efi relocator. It will be used on EFI 64-bit > platforms > > > when multiboot2 c

Re: [GRUB2 PATCH v3 0/4] multiboot2: Add two extensions

2016-03-11 Thread Vladimir 'phcoder' Serbinenko
On Friday, March 11, 2016, Daniel Kiper wrote: > On Fri, Mar 11, 2016 at 04:44:00PM +0100, Vladimir 'phcoder' Serbinenko > wrote: > > [...] > > > multiboot2 spec is a rolling update. > > OK. So, I think that we should do this in that way: > - apply this patch series after polishing; > I hop

Re: [GRUB2 PATCH v3 4/4] multiboot2: Add support for relocatable images

2016-03-11 Thread Daniel Kiper
On Thu, Mar 10, 2016 at 09:41:26PM +0100, Vladimir 'phcoder' Serbinenko wrote: > On Wednesday, March 2, 2016, Daniel Kiper wrote: > > > Currently multiboot2 protocol loads image exactly at address specified in > > ELF or multiboot2 header. This solution works quite well on legacy BIOS > > platform

Re: [GRUB2 PATCH v3 1/4] i386/relocator: Add grub_relocator64_efi relocator

2016-03-11 Thread Vladimir 'phcoder' Serbinenko
On Friday, March 11, 2016, Daniel Kiper wrote: > On Thu, Mar 10, 2016 at 09:23:23PM +0100, Vladimir 'phcoder' Serbinenko > wrote: > > On Wednesday, March 2, 2016, Daniel Kiper > wrote: > > > > > Add grub_relocator64_efi relocator. It will be used on EFI 64-bit > platforms > > > when multiboot2 c

Re: [GRUB2 PATCH v3 0/4] multiboot2: Add two extensions

2016-03-11 Thread Daniel Kiper
On Fri, Mar 11, 2016 at 04:44:00PM +0100, Vladimir 'phcoder' Serbinenko wrote: [...] > multiboot2 spec is a rolling update. OK. So, I think that we should do this in that way: - apply this patch series after polishing; I hope that it will happen next week, - update multiboot2 doc, - ad

Re: [PATCH 1/3] push/pop errno in initrd read file path

2016-03-11 Thread Josef Bacik
On 03/11/2016 02:34 PM, Vladimir 'phcoder' Serbinenko wrote: Le ven. 11 mars 2016 19:13, Josef Bacik mailto:jba...@fb.com>> a écrit : On 03/11/2016 12:23 PM, Vladimir 'phcoder' Serbinenko wrote: > > > On Friday, March 11, 2016, Josef Bacik mailto:jba...@fb.com> >

Re: [PATCH 1/3] push/pop errno in initrd read file path

2016-03-11 Thread Vladimir 'phcoder' Serbinenko
Le ven. 11 mars 2016 19:13, Josef Bacik a écrit : > On 03/11/2016 12:23 PM, Vladimir 'phcoder' Serbinenko wrote: > > > > > > On Friday, March 11, 2016, Josef Bacik > > wrote: > > > > If you try to load an initrd from http and it errors out we will > > free the initr

Re: Bugs and tasks for 2.02[~rc1]

2016-03-11 Thread Andrei Borzenkov
09.03.2016 00:47, Peter Jones пишет: >>> > e704140 Move bash completion script (#922997) Well, this is obvious compatibility question. Is there any way to detect it at configure time? Does bash have pkg-config or similar? >>> >>> I don't see anything obviously like that, unfortun

Re: [PATCH 1/3] push/pop errno in initrd read file path

2016-03-11 Thread Josef Bacik
On 03/11/2016 12:23 PM, Vladimir 'phcoder' Serbinenko wrote: On Friday, March 11, 2016, Josef Bacik mailto:jba...@fb.com>> wrote: If you try to load an initrd from http and it errors out we will free the initrd context but continue on because net_tcp_socket_close() will reset t

Re: Bugs and tasks for 2.02[~rc1]

2016-03-11 Thread Andrei Borzenkov
08.03.2016 00:10, Peter Jones пишет: > On Mon, Mar 07, 2016 at 11:33:52PM +0300, Andrei Borzenkov wrote: >> 07.03.2016 22:57, Vladimir 'phcoder' Serbinenko пишет: >>> I would also appreciate if distros would tell which patches they would >>> carry if 2.02 was released as it is now. If

Re: Linux loader EFI handover

2016-03-11 Thread Andrei Borzenkov
10.03.2016 17:21, Matt Fleming пишет: > On Wed, 09 Mar, at 11:15:16PM, Andrei Borzenkov wrote: >> 09.03.2016 18:18, Matt Fleming пишет: >>> On Tue, 08 Mar, at 07:57:35AM, Andrei Borzenkov wrote: >> - 64-bit kernel on 32-bit platform like Baytrail can't work Do you mean "32 bit EFI"? I

Re: [PATCH 1/3] push/pop errno in initrd read file path

2016-03-11 Thread Vladimir 'phcoder' Serbinenko
On Friday, March 11, 2016, Josef Bacik wrote: > If you try to load an initrd from http and it errors out we will free the > initrd > context but continue on because net_tcp_socket_close() will reset the > grub_errno > as will grub_initrd_close(). So we'll lose the errno and return > GRUB_ERR_NON

Fedora patches [was Re: Bugs and tasks for 2.02[~rc1]]

2016-03-11 Thread Vladimir 'phcoder' Serbinenko
On Friday, March 4, 2016, Peter Jones wrote: > On Wed, Mar 02, 2016 at 03:01:03PM +, Vladimir 'phcoder' Serbinenko > wrote: > > Hello, all. I went through the list of bugs and created a shortlist of > bugs > > that need to be looked at for 2.02. I have marked them with > plan_release_id > > s

[PATCH 1/3] push/pop errno in initrd read file path

2016-03-11 Thread Josef Bacik
If you try to load an initrd from http and it errors out we will free the initrd context but continue on because net_tcp_socket_close() will reset the grub_errno as will grub_initrd_close(). So we'll lose the errno and return GRUB_ERR_NONE instead of the original error. Add push/pulls to the appr

[PATCH 3/3] pxenet: process transmit interrupts when out of resources

2016-03-11 Thread Josef Bacik
We were hitting a problem in production where our bios based machines would sometimes timeout while pulling down either the kernel/initrd. It turned out that sometimes we'd run out of transmit buffers and would then error out while sending packets. This is because we don't actually have an interr

[PATCH 2/3] tcp: add a dprintf for opening tcp connections

2016-03-11 Thread Josef Bacik
In debugging strange timeouts and other network problems it has been helpful to see when we're opening new connections to get an idea of where we're having a breakdown. Signed-off-by: Josef Bacik --- grub-core/net/tcp.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/grub-core/net/tcp

Re: 2.02~beta3 release

2016-03-11 Thread adrian15
Super Grub2 Disk 2.02s4 which it's based on: 2.02~beta3 is available. More information at: http://www.supergrubdisk.org/2016/03/11/super-grub2-disk-2-02s4-released/ . Well, I usually don't make those announcements here but I wanted to let you know that I have told my users: " If Super Grub

Re: Bugs and tasks for 2.02[~rc1]

2016-03-11 Thread Vladimir 'phcoder' Serbinenko
On Wednesday, March 9, 2016, Olaf Hering wrote: > On Wed, Mar 02, Vladimir 'phcoder' Serbinenko wrote: > > > I would like to come up with a complete list of 2.02 blockers in one > week time, > > so that we can have a reasonable timeline > > Did anyone took the time to fix btrfs support (convert i

Re: Bugs and tasks for 2.02[~rc1]

2016-03-11 Thread Juergen Gross
On 11/03/16 16:47, Vladimir 'phcoder' Serbinenko wrote: > > > On Wednesday, March 9, 2016, Daniel Kiper > wrote: > > On Thu, Mar 03, 2016 at 03:47:17PM +0100, Juergen Gross wrote: > > Hi Vladimir, > > > > would it be possible to get "grub-xen: sup

Re: Bugs and tasks for 2.02[~rc1]

2016-03-11 Thread Vladimir 'phcoder' Serbinenko
On Monday, March 7, 2016, Matt Fleming wrote: > On Mon, 07 Mar, at 04:20:00PM, Peter Jones wrote: > > On Mon, Mar 07, 2016 at 11:57:33PM +0300, Andrei Borzenkov wrote: > > > > > > > How big part of it is related to secure boot? Just > > > > changing Linux boot protocol doesn't need FSF involvemen

Re: Bugs and tasks for 2.02[~rc1]

2016-03-11 Thread Vladimir 'phcoder' Serbinenko
On Wednesday, March 9, 2016, Daniel Kiper wrote: > On Thu, Mar 03, 2016 at 03:47:17PM +0100, Juergen Gross wrote: > > Hi Vladimir, > > > > would it be possible to get "grub-xen: support booting huge pv-domains" > > (http://lists.gnu.org/archive/html/grub-devel/2016-03/msg00071.html) > > patch ser

Re: [GRUB2 PATCH v3 2/4] multiboot2: Add tags used to pass ImageHandle to loaded image

2016-03-11 Thread Daniel Kiper
On Thu, Mar 10, 2016 at 09:26:06PM +0100, Vladimir 'phcoder' Serbinenko wrote: > On Wednesday, March 2, 2016, Daniel Kiper wrote: > > > Add tags used to pass ImageHandle to loaded image if requested. > > It is used by at least ExitBootServices() function. > > > > Signed-off-by: Daniel Kiper > > >

Re: [GRUB2 PATCH v3 3/4] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2016-03-11 Thread Daniel Kiper
On Thu, Mar 10, 2016 at 09:28:25PM +0100, Vladimir 'phcoder' Serbinenko wrote: > On Wednesday, March 2, 2016, Daniel Kiper wrote: > > > Do not pass memory maps to image if it asked for EFI boot services. > > Main reason for not providing maps is because they will likely be > > invalid. We do a few

Re: [GRUB2 PATCH v3 0/4] multiboot2: Add two extensions

2016-03-11 Thread Vladimir 'phcoder' Serbinenko
On Wednesday, March 9, 2016, Daniel Kiper wrote: > On Wed, Mar 02, 2016 at 05:51:36PM +0100, Daniel Kiper wrote: > > Hi, > > > > This patch series: > > - enables EFI boot services usage in loaded images > > by multiboot2 protocol, > > - add support for multiboot2 protocol compatible > >

Re: [GRUB2 PATCH v3 1/4] i386/relocator: Add grub_relocator64_efi relocator

2016-03-11 Thread Daniel Kiper
On Thu, Mar 10, 2016 at 09:23:23PM +0100, Vladimir 'phcoder' Serbinenko wrote: > On Wednesday, March 2, 2016, Daniel Kiper wrote: > > > Add grub_relocator64_efi relocator. It will be used on EFI 64-bit platforms > > when multiboot2 compatible image requests MULTIBOOT_TAG_TYPE_EFI_BS. > > Relocator

Re: [GRUB2 PATCH v3 0/4] multiboot2: Add two extensions

2016-03-11 Thread Daniel Kiper
On Fri, Mar 11, 2016 at 01:27:32PM +0100, Vladimir 'phcoder' Serbinenko wrote: > On Wednesday, March 9, 2016, Daniel Kiper wrote: > > > On Wed, Mar 02, 2016 at 05:51:36PM +0100, Daniel Kiper wrote: > > > Hi, > > > > > > This patch series: > > > - enables EFI boot services usage in loaded images