On 03/11/2016 12:23 PM, Vladimir 'phcoder' Serbinenko wrote:
On Friday, March 11, 2016, Josef Bacik <jba...@fb.com <mailto:jba...@fb.com>> wrote: If you try to load an initrd from http and it errors out we will free the initrd context but continue on because net_tcp_socket_close() will reset the grub_errno as will grub_initrd_close(). So we'll lose the errno and return GRUB_ERR_NONE instead of the original error. Add push/pulls to the appropriate places so we don't lose our errno. Thanks, Close functions shouldn't do this. Can you fix them instead? Also please add [2.02] to the subjectwhen appropriate, like in this case.
So do we not want close functions to do grub_error() at all? Seems like there may be some cases where we want to know there was an error closing a tcp socket or the initrd? Maybe not, just want to make sure before I go make these two functions void. Thanks,
Josef _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
