Re: [PATCH 4/4] efi: On x86-64, align the stack to a 16-byte boundary as required by ABI

2013-11-14 Thread Jordan Justen
On Tue, Nov 12, 2013 at 6:27 PM, Josh Triplett wrote: > The x86-64 ABI specification requires a 16-byte-aligned stack. In some > cases, GCC emits code that assumes this alignment, which crashes if not > aligned. The EFI firmware is also entitled to assume that stack > alignment without checking,

PPC build failure with undefined symbols __ashldi3, _restgpr_14_x, ...

2013-11-14 Thread Andrey Borzenkov
Sources at 6fcec439545c817fbc8e2f51c667a70037a34a76 Building RPM for PPC (32 or 64 bits) I get [ 187s] cat syminfo.lst | sort | gawk -f ../../grub-core/genmoddep.awk > moddep.lst || (rm -f moddep.lst; exit 1) [ 187s] __ashldi3 in affs is not defined [ 187s] _restgpr_14_x in affs is not define

Re: [Xen-devel] pvgrub2 is merged

2013-11-14 Thread Dario Faggioli
On lun, 2013-11-11 at 10:10 +, Ian Campbell wrote: > On Sat, 2013-11-09 at 21:52 +0100, Vladimir 'φ-coder/phcoder' Serbinenko > wrote: > > Hello, all. pvgrub2 has just became part of upstream grub as ports i386-xen > > and x86_64-xen. > > This is super cool, thanks! > Indeed! Actually, it w

Re: [Xen-devel] pvgrub2 is merged

2013-11-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 14.11.2013 22:11, M A Young wrote: > On Thu, 14 Nov 2013, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > >> On 14.11.2013 19:57, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >>> On 14.11.2013 19:48, M A Young wrote: On Thu, 14 Nov 2013, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >>>

Re: [Xen-devel] pvgrub2 is merged

2013-11-14 Thread M A Young
On Thu, 14 Nov 2013, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 14.11.2013 19:57, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 14.11.2013 19:48, M A Young wrote: On Thu, 14 Nov 2013, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 14.11.2013 18:03, M A Young wrote: On Thu, 14 Nov

Re: [PATCH] add grub-core/tests/signatures.h to distfiles

2013-11-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Go ahead. On 14.11.2013 20:59, Andrey Borzenkov wrote: > --- > grub-core/Makefile.core.def | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def > index 6114519..4fff57f 100644 > --- a/grub-core/Makefile.core.def > +++ b/grub-core/Makef

[PATCH] add grub-core/tests/signatures.h to distfiles

2013-11-14 Thread Andrey Borzenkov
--- grub-core/Makefile.core.def | 1 + 1 file changed, 1 insertion(+) diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def index 6114519..4fff57f 100644 --- a/grub-core/Makefile.core.def +++ b/grub-core/Makefile.core.def @@ -1914,6 +1914,7 @@ module = { module = { name = sig

Re: [Xen-devel] pvgrub2 is merged

2013-11-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 14.11.2013 19:57, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 14.11.2013 19:48, M A Young wrote: >> On Thu, 14 Nov 2013, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> >>> On 14.11.2013 18:03, M A Young wrote: On Thu, 14 Nov 2013, M A Young wrote: > On Wed, 13 Nov

Re: [Xen-devel] pvgrub2 is merged

2013-11-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 14.11.2013 19:48, M A Young wrote: > On Thu, 14 Nov 2013, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > >> On 14.11.2013 18:03, M A Young wrote: >>> >>> >>> On Thu, 14 Nov 2013, M A Young wrote: >>> On Wed, 13 Nov 2013, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 13.11.2013

Re: [Xen-devel] pvgrub2 is merged

2013-11-14 Thread M A Young
On Thu, 14 Nov 2013, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 14.11.2013 18:03, M A Young wrote: On Thu, 14 Nov 2013, M A Young wrote: On Wed, 13 Nov 2013, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 13.11.2013 20:06, M A Young wrote: It doesn't seem to understand sub-partitio

Re: [Xen-devel] pvgrub2 is merged

2013-11-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 14.11.2013 18:03, M A Young wrote: > > > On Thu, 14 Nov 2013, M A Young wrote: > >> On Wed, 13 Nov 2013, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> >>> On 13.11.2013 20:06, M A Young wrote: It doesn't seem to understand sub-partitions. I can get it to work if the boot files are

Re: [Xen-devel] pvgrub2 is merged

2013-11-14 Thread M A Young
On Thu, 14 Nov 2013, M A Young wrote: On Wed, 13 Nov 2013, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 13.11.2013 20:06, M A Young wrote: It doesn't seem to understand sub-partitions. I can get it to work if the boot files are in /dev/xvda but not in /dev/xvda1 . insmod part_msdos ins

Re: [RFC] New port to arm64-efi

2013-11-14 Thread Leif Lindholm
On Thu, Nov 14, 2013 at 03:06:25PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Good work. Few minor problems: > On 14.11.2013 13:35, Leif Lindholm wrote: > > + > > + grub_arch_sync_caches_real (address, len); > Why not do alignment here? You could align for both dcache and icache, > thi

Re: [RFC] New port to arm64-efi

2013-11-14 Thread Leif Lindholm
On Thu, Nov 14, 2013 at 03:12:28PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > > It depends on Vladimir's __ctz[sd]i2 implementation, without which > > grub-mkimage will fail with a "missing symbol" error. > > > I haven't seen ctz? Is it not needed after all or do you use my patch? Apo

Re: [RFC] New port to arm64-efi

2013-11-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 14.11.2013 13:35, Leif Lindholm wrote: > This patch brings support for UEFI on the 64-bit ARM architecture. > It does not yet include a Linux loader, as the boot protocol for > UEFI platforms is not yet fully agreed. The chainloader can be used > to load a kernel with an integrated UEFI stub loa

Re: [RFC] New port to arm64-efi

2013-11-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Good work. Few minor problems: On 14.11.2013 13:35, Leif Lindholm wrote: > + > + grub_arch_sync_caches_real (address, len); Why not do alignment here? You could align for both dcache and icache, this simplifies asm part and makes it a bit more robust. > + grub_uint32_t insword, insmask; > + grub

Re: GIT workflow

2013-11-14 Thread Mikko Rantalainen
Vladimir 'φ-coder/phcoder' Serbinenko, 2013-11-10 19:01 (Europe/Helsinki): Hello, all. We've switched to git some time ago, now we should have some kind of workflow documents. In particular I think of following points: - Developpers with commit access can create branches as they see fit as long a

[RFC] New port to arm64-efi

2013-11-14 Thread Leif Lindholm
This patch brings support for UEFI on the 64-bit ARM architecture. It does not yet include a Linux loader, as the boot protocol for UEFI platforms is not yet fully agreed. The chainloader can be used to load a kernel with an integrated UEFI stub loader. Instructions for how to build and set up UEF

Re: [Xen-devel] pvgrub2 is merged

2013-11-14 Thread M A Young
On Wed, 13 Nov 2013, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 13.11.2013 20:06, M A Young wrote: It doesn't seem to understand sub-partitions. I can get it to work if the boot files are in /dev/xvda but not in /dev/xvda1 . insmod part_msdos insmod part_gpt Right, if I add those to th

Re: [PATCH] remove dependency on /boot/config-* in grub.d/20_linux_xen

2013-11-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 13.11.2013 14:56, Konrad Rzeszutek Wilk wrote: > On Sun, Nov 10, 2013 at 09:40:29PM +0100, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: >> On 15.07.2013 20:00, Konrad Rzeszutek Wilk wrote: >>> Hey, >>> >>> There is a discussion on the linux-kernel mailing list in which the >>> Linus states th

Re: arm-uboot: misc.S:56: Error: r13 not allowed here -- `sub sp, fp, #4'

2013-11-14 Thread Leif Lindholm
On Thu, Nov 14, 2013 at 01:24:02AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > >> Hm. I'm confused. According to > >> http://stuff.mit.edu/afs/sipb/project/egcs/src/egcs/gcc/config/arm/README-interworking: > >> "Note that specifying -mthumb-interwork does result in slightly larger, > >>

Re: [Xen-devel] pvgrub2 is merged

2013-11-14 Thread Ian Campbell
On Wed, 2013-11-13 at 19:25 +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 13.11.2013 17:36, Ian Campbell wrote: > > On Sat, 2013-11-09 at 21:52 +0100, Vladimir 'φ-coder/phcoder' Serbinenko > > wrote: > >> Hello, all. pvgrub2 has just became part of upstream grub as ports > >> i386-xen a

Re: [PATCH 3/4] efi: Support GRUB_MMAP_MALLOC_LOW in the EFI firmware allocator

2013-11-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 13.11.2013 04:59, Andrey Borzenkov wrote: > В Tue, 12 Nov 2013 18:26:39 -0800 > Josh Triplett пишет: > >> EFI supports allocating memory below a specified address; use that to >> implement GRUB_MMAP_MALLOC_LOW by requesting memory below 1M. > > Out of curiosity - why would you need it on EFI?

Re: [PATCH 3/4] efi: Support GRUB_MMAP_MALLOC_LOW in the EFI firmware allocator

2013-11-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 13.11.2013 03:26, Josh Triplett wrote: > EFI supports allocating memory below a specified address; use that to > implement GRUB_MMAP_MALLOC_LOW by requesting memory below 1M. As discussed on the IRC, using mmap isn't right way to allocate transient low memory space. This would merit a separate f

Re: [PATCH 4/4] efi: On x86-64, align the stack to a 16-byte boundary as required by ABI

2013-11-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
> > diff --git a/grub-core/kern/x86_64/efi/startup.S > b/grub-core/kern/x86_64/efi/startup.S > index f86f019..94bd6ae 100644 > --- a/grub-core/kern/x86_64/efi/startup.S > +++ b/grub-core/kern/x86_64/efi/startup.S > @@ -29,7 +29,11 @@ start: > _start: > movq%rcx, EXT_C(grub_efi_image_ha