> 
> diff --git a/grub-core/kern/x86_64/efi/startup.S 
> b/grub-core/kern/x86_64/efi/startup.S
> index f86f019..94bd6ae 100644
> --- a/grub-core/kern/x86_64/efi/startup.S
> +++ b/grub-core/kern/x86_64/efi/startup.S
> @@ -29,7 +29,11 @@ start:
>  _start:
>       movq    %rcx, EXT_C(grub_efi_image_handle)(%rip)
>       movq    %rdx, EXT_C(grub_efi_system_table)(%rip)
> -
> +     mov     %rsp, %rax
> +     subq    $8, %rsp
> +     and     $~0xf, %rsp
> +     mov     %rax, (%rsp)
>       call    EXT_C(grub_main)
> +     mov     (%rsp), %rsp
This would be useful if we ever returned but we never do (we call
boot_services->exit instead). Could you instead prepare a patch which
does stack alignment and removed the "ret" putting instead a comment /*
Doesn't return.  */ ?
>       ret
>  
> 


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to