Re: Re: [patch] GRUB possible patches

2010-02-16 Thread gburanov
> First part applied Thanks! > Please don't put unrelated patches into single file. Fast look on the > joliet.c of mkisofs suggests that it's not the case for its joliet. It > seems there is more to it. Can you find some normative documents? I searched a bit and found the following information: D

Re: Re: What's the point of allocating the protected mode code on 0x100000 only (UEFI)

2010-02-16 Thread gburanov
> As I already said I have a working prototype for this in newreloc branch. Thanks you, it works! -- Regards Vladimir 'φ-coder/phcoder' Serbinenko -- This message was sent on behalf of gbura...@gmail.com at openSubscriber.com http://www.opensubscriber.com/message/grub-devel@gnu.org/13437030.h

[patch] scrolling bug

2010-02-16 Thread Michal Suchanek
Apparently it is the case. Please test/apply. Thanks Michal === modified file 'video/fb/video_fb.c' --- video/fb/video_fb.c 2010-02-03 00:24:07 + +++ video/fb/video_fb.c 2010-02-16 23:44:09 + @@ -985,6 +985,13 @@ grub_video_fb_scroll (grub_video_color_t linedelta = target.mode_inf

Re: scrolling bug

2010-02-16 Thread Michal Suchanek
Hello is it by any chance possible that while the tests in grub_fb_scroll check if the start is aligned the (width -1) which is added when scrolling backwards is not? This would explain why scrolling backwards is misaligned. This would require to run non-32bpp mode but I am not sure how to tell

Re: [RFC] Framebuffer rotation patch

2010-02-16 Thread Michal Suchanek
On 16 February 2010 22:14, richardvo...@gmail.com wrote: > On Tue, Feb 16, 2010 at 3:05 PM, Michal Suchanek wrote: >> 2010/2/16 Vladimir 'φ-coder/phcoder' Serbinenko : >>> Michal Suchanek wrote: > With typeof macro this can be made type-neutral avoiding potential > mistakes. > +stati

Re: [PATCH][UPDATED] support for xz compression format

2010-02-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Szymon Janc wrote: > Dnia wtorek 16 luty 2010 o 22:11:50 richardvo...@gmail.com napisał(a): > > >> Since gzip format allows decompression in pipeline mode, it's a >> virtual certainty that nothing from the footer is required for >> processing. >> >> And of course this is true of the xz format as

Re: [PATCH][UPDATED] support for xz compression format

2010-02-16 Thread Szymon Janc
Dnia wtorek 16 luty 2010 o 22:11:50 richardvo...@gmail.com napisał(a): > Since gzip format allows decompression in pipeline mode, it's a > virtual certainty that nothing from the footer is required for > processing. > > And of course this is true of the xz format as well. I quote from the > docu

Re: [RFC] Framebuffer rotation patch

2010-02-16 Thread Michal Suchanek
On 16 February 2010 22:05, Michal Suchanek wrote: > 2010/2/16 Vladimir 'φ-coder/phcoder' Serbinenko : >> Michal Suchanek wrote: With typeof macro this can be made type-neutral avoiding potential mistakes. +static inline long +grub_min (long x, long y) +{ +  if (x > y

Re: [PATCH][UPDATED] support for xz compression format

2010-02-16 Thread richardvo...@gmail.com
On Tue, Feb 16, 2010 at 3:28 PM, Seth Goldberg wrote: > y > > Quoting richardvo...@gmail.com, who wrote the following on Tue, 16 Feb 2010: > >> On Tue, Feb 16, 2010 at 12:58 PM, Szymon Janc wrote: >>> >>> Dnia wtorek 16 luty 2010 o 14:44:45 Vladimir 'φ-coder/phcoder' Serbinenko >>> napisał(a): >>

Re: [PATCH][UPDATED] support for xz compression format

2010-02-16 Thread Seth Goldberg
y Quoting richardvo...@gmail.com, who wrote the following on Tue, 16 Feb 2010: On Tue, Feb 16, 2010 at 12:58 PM, Szymon Janc wrote: Dnia wtorek 16 luty 2010 o 14:44:45 Vladimir 'φ-coder/phcoder' Serbinenko napisał(a): + #define VLI_MAX_DIGITS 9 Are you sure it's 9? It gives only 63 and not

Re: [RFC] Framebuffer rotation patch

2010-02-16 Thread richardvo...@gmail.com
On Tue, Feb 16, 2010 at 3:05 PM, Michal Suchanek wrote: > 2010/2/16 Vladimir 'φ-coder/phcoder' Serbinenko : >> Michal Suchanek wrote: With typeof macro this can be made type-neutral avoiding potential mistakes. +static inline long +grub_min (long x, long y) +{ +  if

Re: [PATCH][UPDATED] support for xz compression format

2010-02-16 Thread richardvo...@gmail.com
On Tue, Feb 16, 2010 at 12:58 PM, Szymon Janc wrote: > Dnia wtorek 16 luty 2010 o 14:44:45 Vladimir 'φ-coder/phcoder' Serbinenko > napisał(a): > >> + #define VLI_MAX_DIGITS 9 >> Are you sure it's 9? It gives only 63 and not 64 bits > It is a limitation of xz format. > >> +   if (! test_header(file

Re: [RFC] Framebuffer rotation patch

2010-02-16 Thread Michal Suchanek
2010/2/16 Vladimir 'φ-coder/phcoder' Serbinenko : > Michal Suchanek wrote: >>> With typeof macro this can be made type-neutral avoiding potential mistakes. >>> +static inline long >>> +grub_min (long x, long y) >>> +{ >>> +  if (x > y) >>> +    return y; >>> +  else >>> +    return x; >>> +} >>> +

Re: [RFC] Framebuffer rotation patch, or why 'unsigned' fails us

2010-02-16 Thread Michal Suchanek
2010/2/16 Vladimir 'φ-coder/phcoder' Serbinenko : > Michal Suchanek wrote: >> This also enhances the video interface so that drawing at negative >> position is representable in the arguments. Iit is then possible to >> blit a bitmap without first clipping the topleft part by just blitting >> at neg

Re: [PATCH] transparent file reader

2010-02-16 Thread Szymon Janc
Dnia wtorek 16 luty 2010 o 20:38:28 Seth Goldberg napisał(a): > How do consumers of this interface determine the underlying cause of the > problem? Sometimes, more layering creates more problems than it solves. > Think about how you determine the message to display when getting a return > value

Re: [PATCH] transparent file reader

2010-02-16 Thread Seth Goldberg
How do consumers of this interface determine the underlying cause of the problem? Sometimes, more layering creates more problems than it solves. Think about how you determine the message to display when getting a return value from a function. --S Quoting Szymon Janc, who wrote the follow

Re: [PATCH] transparent file reader

2010-02-16 Thread Szymon Janc
Dnia wtorek 16 luty 2010 o 19:16:19 Vladimir 'φ-coder/phcoder' Serbinenko napisał(a): > I like the patch however few comments: > 1) How are filters ordered? Filters are tested in order that last registered filter is tested first. First match stop further tests. > 2) How would I selectively dis

Re: [PATCH][UPDATED] support for xz compression format

2010-02-16 Thread Szymon Janc
Dnia wtorek 16 luty 2010 o 14:44:45 Vladimir 'φ-coder/phcoder' Serbinenko napisał(a): > + #define VLI_MAX_DIGITS 9 > Are you sure it's 9? It gives only 63 and not 64 bits It is a limitation of xz format. > + if (! test_header(file) || ! test_footer(file)) > + { > Seeking to the end of file i

[Off-topic] C++ enums

2010-02-16 Thread Isaac Dupree
On 02/16/10 13:15, richardvo...@gmail.com wrote: On Tue, Feb 16, 2010 at 12:03 PM, Isaac Dupree wrote: On 02/16/10 10:52, Michal Suchanek wrote: enum allows it just fine Not here: typedef enum t1 { BTI1 = 1, typo, should be "BIT1". then it works. (In C. Also remember not to get confuse

Re: [PATCH] transparent file reader

2010-02-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Szymon Janc wrote: > Hello, > > Attached patch makes file reader transparent. It should make adding new > filters > to file reader easier. > > - gzio.h is gone > - gzio is no more transparent, transparency is handled in grub_file_open() > - renamed GRUB_ERR_BAD_GZIP_DATA to GRUB_ERR_BAD_IOFILTER_

Re: [RFC] Framebuffer rotation patch

2010-02-16 Thread richardvo...@gmail.com
On Tue, Feb 16, 2010 at 12:03 PM, Isaac Dupree wrote: > On 02/16/10 10:52, Michal Suchanek wrote: >>> >>> enum allows it just fine >> >> Not here: >> >> typedef enum t1 { BTI1 = 1, > > typo, should be "BIT1". then it works. (In C.  Also remember not to get > confused by the fact that it doesn't wo

[PATCH] transparent file reader

2010-02-16 Thread Szymon Janc
Hello, Attached patch makes file reader transparent. It should make adding new filters to file reader easier. - gzio.h is gone - gzio is no more transparent, transparency is handled in grub_file_open() - renamed GRUB_ERR_BAD_GZIP_DATA to GRUB_ERR_BAD_IOFILTER_DATA, it will be used by other ios

Re: [RFC] Framebuffer rotation patch

2010-02-16 Thread Isaac Dupree
On 02/16/10 10:52, Michal Suchanek wrote: enum allows it just fine Not here: typedef enum t1 { BTI1 = 1, typo, should be "BIT1". then it works. (In C. Also remember not to get confused by the fact that it doesn't work in C++, for type-related reasons that we don't need to get into here be

Re: [PATCH] delete and backspace; unimplemented keys

2010-02-16 Thread Manoel Rebelo Abraches
Hi. As talked with phcoder in #grub on freenode, there is a cleaner version of the first patch, taking in consideration the recent changes in ofconsole. There is also a little fix to get the "~" character when the "DEL" key is pressed. On Thu, 2010-02-11 at 16:36 -0200, Manoel Rebelo Abraches wro

Re: [RFC] Framebuffer rotation patch

2010-02-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Michal Suchanek wrote: >> With typeof macro this can be made type-neutral avoiding potential mistakes. >> +static inline long >> +grub_min (long x, long y) >> +{ >> + if (x > y) >> +return y; >> + else >> +return x; >> +} >> + >> > > I don't see how typeof would be used. As I underst

Re: [RFC] Framebuffer rotation patch

2010-02-16 Thread Michal Suchanek
2010/2/11 Vladimir 'φ-coder/phcoder' Serbinenko : > Michal Suchanek wrote: >> Hello >> >> Sending a preliminary framebuffer rotation patch. >> >> You can use videotest to see 4 tiles rotated from the same bitmap data. >> >> > +char leaf_data[] = { 0x00, 0x0f, 0xe0, 0x00, > +                     0x0

Re: [RFC] Framebuffer rotation patch

2010-02-16 Thread Michal Suchanek
2010/2/16 Vladimir 'φ-coder/phcoder' Serbinenko : > Michal Suchanek wrote: >> 2010/2/11 Vladimir 'φ-coder/phcoder' Serbinenko : >> >>> Michal Suchanek wrote: >> This requires that both u and w be in the chosen set of generators >> because otherwise use of v or s twice is required to get one from t

Re: [PATCH][UPDATED] support for xz compression format

2010-02-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Szymon Janc wrote: > On Tue, 16 Feb 2010 14:12:04 +0100 Vladimir 'φ-coder/phcoder' Serbinenko > wrote > > >> First of all: could you use unified diff? (-u option) >> > > Sure, will use that in future. > > >> grub2-1.98~experimental.20100120/conf/xzembed.rmk >> I don't see a need for e

Re: avoid possible overflow?

2010-02-16 Thread richardvo...@gmail.com
2010/2/16 Vladimir 'φ-coder/phcoder' Serbinenko : > Carles Pina i Estany wrote: >> Hello, >> >> The common pattern when doing a search by bisection is something like: >> +      current = min + (max - min) / 2; >> >> Instead of the first natural idea: >> -      current = (max + min) / 2; >> >> To av

Re: [PATCH][UPDATED] support for xz compression format

2010-02-16 Thread Szymon Janc
On Tue, 16 Feb 2010 14:12:04 +0100 Vladimir 'φ-coder/phcoder' Serbinenko wrote > First of all: could you use unified diff? (-u option) Sure, will use that in future. > grub2-1.98~experimental.20100120/conf/xzembed.rmk > I don't see a need for either separate .rmk or separate module > > + sta

Re: [PATCH][UPDATED] support for xz compression format

2010-02-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Szymon Janc wrote: > Hello, > > New version of xz compression patch. > Changes since then: > - it works now :-) > - decoder dictionary can be enlarge up to DICT_BIT_SIZE defined in xz_lzma2.h > (currently set to 30 = 128MiB) > - xz uses crc32 from libgcrypt-grub, internal crc implementation remove

Re: beep support?

2010-02-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Samuel Thibault wrote: > Samuel Thibault, le Fri 05 Feb 2010 19:11:18 +0100, a écrit : > >> Vladimir 'φ-coder/phcoder' Serbinenko, le Fri 05 Feb 2010 17:52:02 +0100, a >> écrit : >> >>> Could you detail at which events beep should be produced and propose a >>> patch to add appropriate hook

Re: avoid possible overflow?

2010-02-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Carles Pina i Estany wrote: > Hello, > > The common pattern when doing a search by bisection is something like: > + current = min + (max - min) / 2; > > Instead of the first natural idea: > - current = (max + min) / 2; > > To avoid overflows. > > In gettext/gettext.c it's used in the "inc

Re: [RFC] Framebuffer rotation patch, or why 'unsigned' fails us

2010-02-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Michal Suchanek wrote: > This also enhances the video interface so that drawing at negative > position is representable in the arguments. Iit is then possible to > blit a bitmap without first clipping the topleft part by just blitting > at negative position which should make some operations easier

Re: [RFC] Framebuffer rotation patch

2010-02-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Michal Suchanek wrote: > 2010/2/11 Vladimir 'φ-coder/phcoder' Serbinenko : > >> Michal Suchanek wrote: >> >>> 2010/2/11 Vladimir 'φ-coder/phcoder' Serbinenko : >>> >>> Michal Suchanek wrote: > Hello > > Sending a preliminary framebuffer rotation pa

Re: [patch] GRUB possible patches

2010-02-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
gbura...@gmail.com wrote: > Hello, > > >> It is. Can you write a ChangeLog entry? >> > Done > > First part applied >> ;1 is so called version. Basically all terminating ; have to be >> stripped but only if filename doesn't come from rockridge or joliet. >> Apparently nobody uses grub2

Contributing patches (Re: freeze announcement)

2010-02-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
gbura...@gmail.com wrote: >> Hi, >> trunk repository is now frozen in preparation for GRUB 1.98, which will be >> released soon, most likely this month. >> I leave Vladimir in charge of this freeze process. Please ask him for >> approval when in doubt. >> > > Hello, > I am really newbie to th

Re: freeze announcement

2010-02-16 Thread gburanov
> Hi, > trunk repository is now frozen in preparation for GRUB 1.98, which will be > released soon, most likely this month. > I leave Vladimir in charge of this freeze process. Please ask him for > approval when in doubt. Hello, I am really newbie to the process of reviewing/comming code to GNU r

Re: [PATCH] Trim a few bytes from boot.img

2010-02-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Colin Watson wrote: > A while back, I was looking for eight extra bytes in boot.img so that I > could put a keyboard modifier check in there, allowing me to avoid > printing "GRUB loading" by default, which my boss^3 has been asking me > for, without crippling debugging in the process. I knew I co

Re: What's the point of allocating the protected mode code on 0x100000 only (UEFI)

2010-02-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
George Buranov wrote: > Hello, > > I just found another computer with working UEFI (I was testing on UEFI > simulation) and just found that the kernel load does not work. I found > out that the problem is in code > > /* Next, find free pages for the protected mode code. */ > /* XXX what happen

What's the point of allocating the protected mode code on 0x100000 only (UEFI)

2010-02-16 Thread George Buranov
Hello, I just found another computer with working UEFI (I was testing on UEFI simulation) and just found that the kernel load does not work. I found out that the problem is in code /* Next, find free pages for the protected mode code. */ /* XXX what happens if anything is using this address?