On 25 Jul, 2009, at 09:21 , Robert Millan wrote:
On Thu, Jul 23, 2009 at 04:05:00PM -0700, Joe Auricchio wrote:
How's this?
The ChangeLog entry is incomplete. It should be e.g.:
* commands/minicmd.c (grub_mini_cmd_clear): New function.
etc. See other entries as an example.
Upd
Hi,
Eine kleine gfxterm.c cleanup
Index: src/term/gfxterm.c
===
--- src.orig/term/gfxterm.c 2009-07-22 16:54:01.0 -0700
+++ src/term/gfxterm.c 2009-07-24 17:15:15.0 -0700
@@ -151,6 +151,16 @@
}
static void
+
On Wed, Jul 29, 2009 at 1:42 AM, Robert Millan wrote:
> On Tue, Jul 28, 2009 at 11:15:09PM +0800, Bean wrote:
>> - buf2 = grub_zalloc (size);
>> + buf2 = grub_malloc (size);
>> if (!buf2)
>> return grub_errno;
>>
>> + grub_memset (buf, 0, size);
>
> We just received 'buf' as parameter.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Robert Millan escribió:
> First of all, please don't call them far pointers. They're an i8086 legacy
> cruft, which have nothing to do with far or close really (although we seem to
> have some code that makes this reference already).
So... how do we c
On Sat, Apr 11, 2009 at 8:56 PM, phcoder wrote:
> Yoshinori K. Okuji wrote:
>>
>> On Tuesday 07 April 2009 10:18:30 phcoder wrote:
>>>
>>> Yoshinori K. Okuji wrote:
>>
>> 1) double the size of flags. 8 features per category seems to be few.
I do not agree on this. As you can see,
On Tue, Jul 28, 2009 at 7:33 PM, Robert Millan wrote:
> On Sun, Jul 26, 2009 at 03:54:41PM +0200, Vladimir 'phcoder' Serbinenko wrote:
>> + for (i = 0; i < 4; i++)
>> + if (mbr.entries[i].flag & 0x7f)
>> + break;
>> +
>> + if (i != 4)
>> + return grub_error (GRUB_ERR_BAD_PAR
Am Dienstag, den 28.07.2009, 19:42 +0200 schrieb Robert Millan:
> On Tue, Jul 28, 2009 at 11:15:09PM +0800, Bean wrote:
>
> > +static int
> > +probe_raid_level (grub_disk_t disk)
> > +{
> > + if (disk->dev->id != GRUB_DISK_DEVICE_RAID_ID)
> > +return -1;
> > +
> > + return ((struct grub_raid
>
> I am thinking about the rotation which is required to turn a landscape
> monitor into a portrait one which is commonly used.
>
> It is technically possible to arbitrarily rotate the picture but then
> you would need support for arbitrary screen shapes (shapes other than
> rectangles parallel wi
On Sun, Jul 26, 2009 at 03:54:41PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> + for (i = 0; i < 4; i++)
> + if (mbr.entries[i].flag & 0x7f)
> + break;
> +
> + if (i != 4)
> + return grub_error (GRUB_ERR_BAD_PART_TABLE, "bad boot flag");
Why not just return directly?
--
On Tue, Jul 28, 2009 at 11:15:09PM +0800, Bean wrote:
> - buf2 = grub_zalloc (size);
> + buf2 = grub_malloc (size);
>if (!buf2)
> return grub_errno;
>
> + grub_memset (buf, 0, size);
We just received 'buf' as parameter. Why do we have to zero it here?
> +static int
> +probe_raid_le
2009/7/28 Robert Millan :
> On Sat, Jul 25, 2009 at 10:03:50PM +0200, Michal Suchanek wrote:
>> 2009/7/25 Robert Millan :
>> > On Fri, Jul 24, 2009 at 09:33:45PM +0200, Michal Suchanek wrote:
>> >> Hello
>> >>
>> >> Is there some chance that the grub menu could be drawn rotated on
>> >> graphical d
On Tue, Jul 28, 2009 at 7:50 PM, Robert Millan wrote:
> On Mon, Jul 27, 2009 at 12:06:17AM +0200, Vladimir 'phcoder' Serbinenko wrote:
>> Removed parts which are purely moving code around (of course it will
>> be restored on commit).
>
> This is not a full review of the patch, just a quick overview
On Tue, Jul 28, 2009 at 7:57 PM, Robert Millan wrote:
> On Sat, Jul 25, 2009 at 10:03:50PM +0200, Michal Suchanek wrote:
>> 2009/7/25 Robert Millan :
>> > On Fri, Jul 24, 2009 at 09:33:45PM +0200, Michal Suchanek wrote:
>> >> Hello
>> >>
>> >> Is there some chance that the grub menu could be drawn
Am Dienstag, den 28.07.2009, 20:00 +0200 schrieb Robert Millan:
> On Sat, Jul 25, 2009 at 07:47:31PM +0200, Felix Zielcke wrote:
> > Currently help output of search says that --file option is the default
> > but a `search /file' fails with `unspecified search type'.
> > So which behaviour do we wan
On Tue, Jul 28, 2009 at 8:16 PM, Robert Millan wrote:
> On Tue, Jul 28, 2009 at 12:40:32PM +0200, Vladimir 'phcoder' Serbinenko wrote:
>> --- a/partmap/apple.c
>> +++ b/partmap/apple.c
>> @@ -30,6 +30,7 @@ struct grub_apple_header
>> /* The magic number to identify the partition map, it should h
Am Dienstag, den 28.07.2009, 20:19 +0200 schrieb Robert Millan:
> On Wed, Jun 10, 2009 at 11:04:56PM +0200, Felix Zielcke wrote:
> > Am Samstag, den 06.06.2009, 21:53 -0400 schrieb Pavel Roskin:
> > > On Sat, 2009-06-06 at 12:25 +0200, Felix Zielcke wrote:
> > > > f...@fz:~/grub/grub2.git$ rgrep -E
On Tue, Jul 28, 2009 at 8:15 PM, Robert Millan wrote:
> On Tue, Jul 28, 2009 at 01:03:51AM +0200, Vladimir 'phcoder' Serbinenko wrote:
>> Hello. CPUID command currently doesn't return a real grub_err_t and
>> errors aren't set which doesn't fit in grub2's design.
>> Addirionally "help cpuid" doesn'
On Mon, Jul 27, 2009 at 09:53:29PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> diff --git a/ChangeLog b/ChangeLog
> index 752bde8..bb8aff3 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,9 @@
> +2009-07-27 Vladimir Serbinenko
> +
> + * loader/i386/multiboot_helper.S (grub_multiboot
On Mon, Jul 27, 2009 at 12:06:17AM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Removed parts which are purely moving code around (of course it will
> be restored on commit).
This is not a full review of the patch, just a quick overview. But I have
a few comments:
- The "fb" naming is confusi
On Sat, Jul 25, 2009 at 10:03:50PM +0200, Michal Suchanek wrote:
> 2009/7/25 Robert Millan :
> > On Fri, Jul 24, 2009 at 09:33:45PM +0200, Michal Suchanek wrote:
> >> Hello
> >>
> >> Is there some chance that the grub menu could be drawn rotated on
> >> graphical devices like the efi graphics inter
On Sat, Jul 25, 2009 at 07:47:31PM +0200, Felix Zielcke wrote:
> Currently help output of search says that --file option is the default
> but a `search /file' fails with `unspecified search type'.
> So which behaviour do we want?
I'd stick with what we used to have, unless it's trouble supporting
On Sun, Jul 26, 2009 at 12:58:59AM +0200, Vladimir 'phcoder' Serbinenko wrote:
> + /* This is our loop-detection algorithm. It works the following way:
> + It saves last position which was a power of two. Then it compares the
> + saved value with a current one. This way it's guarante
On Sun, Jul 26, 2009 at 04:05:31PM +0200, Felix Zielcke wrote:
> As requested by Robert on IRC, this is a split from my dmraid patch.
> On dmraid devices HDIO_GETGEO returns 0 for all fields, so the current
> way of grub_util_biosdisk_get_grub_dev just can't work.
> So I use blkid to get the UUID o
On Wed, Jun 10, 2009 at 11:04:56PM +0200, Felix Zielcke wrote:
> Am Samstag, den 06.06.2009, 21:53 -0400 schrieb Pavel Roskin:
> > On Sat, 2009-06-06 at 12:25 +0200, Felix Zielcke wrote:
> > > f...@fz:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|wc -l
> > > 2273
> > > f...@fz:~/grub/grub2.git$ rgr
On Tue, Jul 28, 2009 at 12:40:32PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> --- a/partmap/apple.c
> +++ b/partmap/apple.c
> @@ -30,6 +30,7 @@ struct grub_apple_header
>/* The magic number to identify the partition map, it should have
> the value `0x4552'. */
>grub_uint16_t magic
On Sun, Jul 26, 2009 at 12:32:28AM +0200, Javier Martín wrote:
> This patch modifies the machine-specific memory.h (currently, just the
> i386-specific file), adding a new type grub_machine_farptr and two
> functions to convert between such far pointers and normal C pointers.
>
> The code performi
On Tue, Jul 28, 2009 at 01:03:51AM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Hello. CPUID command currently doesn't return a real grub_err_t and
> errors aren't set which doesn't fit in grub2's design.
> Addirionally "help cpuid" doesn't give really useful info. So for
> future expandability an
Hi,
Oh, the link should be:
http://svn.savannah.gnu.org/viewvc/trunk/grub2/disk/raid5_recover.c?root=grub&r1=2197&r2=2421
On Tue, Jul 28, 2009 at 11:15 PM, Bean wrote:
> Hi,
>
> BTW, I found a regression on r2421 that cause raid5rec to fail:
>
> http://svn.savannah.gnu.org/viewvc/trunk/grub2/dis
Hi,
BTW, I found a regression on r2421 that cause raid5rec to fail:
http://svn.savannah.gnu.org/viewvc/trunk/grub2/disk/raid6_recover.c?root=grub&r1=2197&r2=2421
buf and buf2 are two different variable.
This new patch include the revert raid5_recover.c to r1828.
On Tue, Jul 28, 2009 at 9:57 PM
Hi,
Oh, I've found the problem. The abstraction is ok, but now partmap is
wrong. The original code assumes at most one level of abstraction when
detecting partmap, and it doesn't work on two level abstraction like
LVM on RAID. If you add module minicmd, you can use lsmod and see pc
module is missi
Reading specs revealed further problems. Here is a fix
--
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git
diff --git a/ChangeLog b/ChangeLog
index 752bde8..2c46f76 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2009-07-28 Vladimir
Hi,
Update:
Now global symbol must be defined using GRUB_EXPORT macro, otherwise
it'd be removed from the module symbol list. I also add GRUB_EXPORT to
modules in i386-pc platform.
Some reason to define global symbols explicitly:
For modules that consists of multiple files, some external functi
--
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git
diff --git a/ChangeLog b/ChangeLog
index 752bde8..1502765 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2009-07-28 Vladimir Serbinenko
+
+ Support Apple partition map with s
33 matches
Mail list logo
