Re: [PATCH] framework for building modules externally

2008-11-05 Thread Christian Franke
use of __FILE__ may also add extra unexpected size: For packaging, configure is often run outside of $srcdir with a absolute path name. This may result in long __FILE__ strings, like /home/maintainer/packaging/grub/tmp/grub-1.96+20081105-1/src/grub-1.96/kern/disk.c ___

Re: PPC64 mlongcall gcc flag

2008-11-05 Thread Manoel
On Wed, 2008-11-05 at 11:25 -0600, Hollis Blanchard wrote: > On Tue, 2008-11-04 at 18:48 -0500, Pavel Roskin wrote: > > > > However, it would be nice to have a better explanation why "-mlongcall" > > is needed. If it's only needed for modules and has significant > > overhead, we may want to intro

Re: Multiboot2 header

2008-11-05 Thread Tomáš Ebenlendr
Dne 4 Listopad 2008, 21:36, Robert Millan napsal(a): > > The Multiboot2 draft says a Multiboot2 header must be included in the OS > image. However, our code assumes (in code itself and in comments) that > for MB2 this is optional. > > > As a consequence, if you feed GRUB's multiboot loader any E

Re: PPC64 mlongcall gcc flag

2008-11-05 Thread Hollis Blanchard
On Tue, 2008-11-04 at 18:48 -0500, Pavel Roskin wrote: > > However, it would be nice to have a better explanation why "-mlongcall" > is needed. If it's only needed for modules and has significant > overhead, we may want to introduce MODULE_CFLAGS, which would only be > used for modules. It absol

RE: [PATCH] PCI serial card support

2008-11-05 Thread Dugger, Donald D
>-Original Message- >... >> what happens if you have 2 different PCI cards installed, > >Then serial.mod can handle multiple terminals (it already >does, just not for PCI cards) via `serial' command, and use >the PCI calls to gather info about them whenever they're to be used. > Hmmm, t

Re: PPC64 mlongcall gcc flag

2008-11-05 Thread Pavel Roskin
On Wed, 2008-11-05 at 10:43 +0100, Robert Millan wrote: > On Tue, Nov 04, 2008 at 06:48:26PM -0500, Pavel Roskin wrote: > > Index: configure.ac > > === > > --- configure.ac(revision 1893) > > +++ configure.ac(working copy) > >

Re: [PATCH] framework for building modules externally

2008-11-05 Thread Robert Millan
On Wed, Nov 05, 2008 at 07:57:38AM +0100, Christian Franke wrote: > > Alternative: Export a symbol describing the ABI version in kernel > ("grub_abi_3_14"). That requires more bytes than a 32-bit integer. > Access this symbol in each module (this can be hidden > in GRUB_MOD_INIT). And this ad

Re: [PATCH] framework for building modules externally

2008-11-05 Thread Robert Millan
Hi, Since it looks like the ABI part inspires more need for debate/discussion, I propose merging the rest first. Support for ABI tracking is not essential for building external modules (in Debian, it's barely necessary). Here's a new patch. If nobody objects, I'll commit it in a few days. --

Re: [PATCH] PCI serial card support

2008-11-05 Thread Robert Millan
On Tue, Nov 04, 2008 at 10:24:38AM -0800, Dugger, Donald D wrote: > You can create an internal table that maps PCI ID to base baud[1] I'd prefer that a lot. Users don't necessarily have an idea on what magic value they need. > but now you are tied to the PCI subsystem and you get into issues of

Re: PPC64 mlongcall gcc flag

2008-11-05 Thread Robert Millan
On Tue, Nov 04, 2008 at 06:48:26PM -0500, Pavel Roskin wrote: > Index: configure.ac > === > --- configure.ac (revision 1893) > +++ configure.ac (working copy) > @@ -291,6 +291,11 @@ >TARGET_CFLAGS="$TARGET_CFLAGS -mal