On Wed, 2008-11-05 at 10:43 +0100, Robert Millan wrote: > On Tue, Nov 04, 2008 at 06:48:26PM -0500, Pavel Roskin wrote: > > Index: configure.ac > > =================================================================== > > --- configure.ac (revision 1893) > > +++ configure.ac (working copy) > > @@ -291,6 +291,11 @@ > > TARGET_CFLAGS="$TARGET_CFLAGS -malign-jumps=1 -malign-loops=1 > > -malign-functions=1" > > fi > > fi > > + > > + # Force long calls on PowerPC. > > + if test "x$target_cpu" = xpowerpc; then > > + TARGET_CFLAGS="$TARGET_CFLAGS -mlongcall" > > + fi > > fi > > IIRC we had a case/esac stanza for $target_cpu already. Shouldn't this be > added > there instead?
I would prefer that we handle similar flags in the same place. It's more reliable (especially in context of further changes) than grouping changes in different flags by conditions. The real question is of course how to avoid or limit -mlongcall, as it makes the modules bigger. We should not need more that 32 Mb for code. -- Regards, Pavel Roskin _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
