Re: IA64 port

2008-02-10 Thread Alexandre Boeglin
Le mer 30 jan 2008 à 06:48:11 +0100, Tristan Gingold a écrit : > * loader/ia64/efi/linux_normal.c: New file. > * loader/ia64/efi/linux.c: New file. Hello, Wouldn't it be possible to merge these and the current loader/i386/efi/linux* into one single loader/efi/linux.c and linux_normal.

Re: [PATCH] a.out support for multiboot and freebsd

2008-02-10 Thread Bean
Hi, The following patch support freebsd a.out and elf, now you can load the kernel directly. 1. Boot through loader: set root=(hd0,0,a) freebsd /boot/loader It should be able to deduce the root device from the root variable. 2. Booting directly: freebsd (hd0,0,a)/boot/kernel/kernel freebsd_loa

Re: Generic halt and reboot commands (was: Re: grub2 efi patches)

2008-02-10 Thread Alexandre Boeglin
Le dim 10 fév 2008 à 22:05:46 +0100, Robert Millan a écrit : > For consistency with similar code elsewhere in GRUB, I think it's better if > you made this: > > #if defined(foo) > #elif defined(bar) > #endif No whitespace before the opening bracket in this case ? By the way, this case is a good e

Re: [PATCH] erase variable data on user unset

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 04:38:37PM -0500, Isaac Dupree wrote: > on second thought, if grub is going to be able to boot kernels that are > on encrypted partitions, the password might go more places in grub > and/or have to be retained until boot time, depending how it works... Not until boot time

Re: [PATCH] erase variable data on user unset

2008-02-10 Thread Isaac Dupree
on second thought, if grub is going to be able to boot kernels that are on encrypted partitions, the password might go more places in grub and/or have to be retained until boot time, depending how it works... ___ Grub-devel mailing list Grub-devel@gn

Re: [PATCH] erase variable data on user unset

2008-02-10 Thread Isaac Dupree
Robert Millan wrote: On Sun, Feb 10, 2008 at 03:00:31PM -0500, Isaac Dupree wrote: Robert Millan wrote: On Sun, Feb 10, 2008 at 01:00:50PM -0500, Isaac Dupree wrote: anyway if a hash is used that takes (by design) around one second on the machine (e.g. sha256 repeated thousands? millions? of t

Re: [PATCH] implement menu_lock

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 09:59:48PM +0100, Robert Millan wrote: > > menuentry "Only users who unlocked the menu can boot this" { > if ! test $menu_lock=1 ; then > multiboot /bar > fi > } > > menuentry "Only a few selected ones can boot this" { > echo -n "Password: " > read password >

Re: Generic halt and reboot commands (was: Re: grub2 efi patches)

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 08:54:08PM +0100, Alexandre Boeglin wrote: > +#ifdef GRUB_MACHINE_IEEE1275 > #include > +#elif defined GRUB_MACHINE_EFI > +#include > +#endif For consistency with similar code elsewhere in GRUB, I think it's better if you made this: #if defined(foo) #elif defined(bar) #

Re: [PATCH] erase variable data on user unset

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 09:47:38PM +0100, Robert Millan wrote: > > This should address your concern. As to why I propose to put this in unset > command rather than kernel, since GRUB itself doesn't have any mechanisms > where a variable would contain sensible information, I think it's better to >

Re: [PATCH] implement menu_lock

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 09:13:01PM +0100, Yoshinori K. Okuji wrote: > On Sunday 10 February 2008 14:09, Robert Millan wrote: > > Implement menu_lock. This is a variable that locks the menu when set. > > > > It can be used by users to lock the menu, although there's no way to > > authenticate users

Re: [PATCH] read --echo=[yes|no|wildcard]

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 09:16:59PM +0100, Yoshinori K. Okuji wrote: > On Sunday 10 February 2008 14:16, Robert Millan wrote: > > Adds a parameter to define echoing behaviour in read. Then one can use > > --echo=no or --echo=wildcard to make it suitable for reading passwords. > > Can you describe

[PATCH] erase variable data on user unset

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 03:00:31PM -0500, Isaac Dupree wrote: > Robert Millan wrote: > >On Sun, Feb 10, 2008 at 01:00:50PM -0500, Isaac Dupree wrote: > >>anyway if a hash is used that takes (by design) around one second on the > >>machine (e.g. sha256 repeated thousands? millions? of times), then

Re: [PATCH] if timeout is set to zero, don't bother drawing the menu

2008-02-10 Thread Isaac Dupree
Yoshinori K. Okuji wrote: On Sunday 10 February 2008 13:55, Robert Millan wrote: We could make the behaviour be, that if ESC is pressed at any time before an input line is completed, the operation is aborted, read returns non-zero, and it doesn't save the line to any variable. What do you think

Re: [PATCH] read --echo=[yes|no|wildcard]

2008-02-10 Thread Yoshinori K. Okuji
On Sunday 10 February 2008 14:16, Robert Millan wrote: > Adds a parameter to define echoing behaviour in read. Then one can use > --echo=no or --echo=wildcard to make it suitable for reading passwords. Can you describe how you are planning to use it? Okuji _

Re: [PATCH] implement menu_lock

2008-02-10 Thread Yoshinori K. Okuji
On Sunday 10 February 2008 14:09, Robert Millan wrote: > Implement menu_lock. This is a variable that locks the menu when set. > > It can be used by users to lock the menu, although there's no way to > authenticate users for unlocking it, yet (but the procedure would be > independant from this int

Re: [PATCH] if timeout is set to zero, don't bother drawing the menu

2008-02-10 Thread Yoshinori K. Okuji
On Sunday 10 February 2008 13:55, Robert Millan wrote: > We could make the behaviour be, that if ESC is pressed at any time before > an input line is completed, the operation is aborted, read returns > non-zero, and it doesn't save the line to any variable. What do you think? Not bad. :) > > In

Re: [PATCH] read --echo=[yes|no|wildcard]

2008-02-10 Thread Isaac Dupree
Robert Millan wrote: On Sun, Feb 10, 2008 at 01:00:50PM -0500, Isaac Dupree wrote: anyway if a hash is used that takes (by design) around one second on the machine (e.g. sha256 repeated thousands? millions? of times), then I suppose the time taken to erase the memory used by GRUB would be trivi

Re: Generic halt and reboot commands (was: Re: grub2 efi patches)

2008-02-10 Thread Alexandre Boeglin
Le dim 10 fév 2008 à 17:56:12 +0100, Robert Millan a écrit : > On Sun, Feb 10, 2008 at 05:37:27PM +0100, Alexandre Boeglin wrote: > > > > * commands/halt.c: ... to here. > > Add some precompiler directive to include the correct header for each > > machine. > > Can we simplify this? Since gru

Re: [PATCH] read --echo=[yes|no|wildcard]

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 01:00:50PM -0500, Isaac Dupree wrote: > anyway if a hash is used that takes (by design) around one second on the > machine (e.g. sha256 repeated thousands? millions? of times), then I > suppose the time taken to erase the memory used by GRUB would be trivial > in comparis

Re: [PATCH] a.out support for multiboot and freebsd

2008-02-10 Thread walt
Bean wrote: On Feb 10, 2008 5:57 AM, walt<[EMAIL PROTECTED]> wrote: Bean wrote: Hi, This patch add a.out support for multiboot. It also support the boot2 loader (a.out format) of freebsd: set root=(hd0,0,a) aout_freebsd /boot/loader boot ... i'm using the web interface to send patch, maybe

Re: [PATCH] read --echo=[yes|no|wildcard]

2008-02-10 Thread Isaac Dupree
Robert Millan wrote: I think that it'd be better to just erase all our environment in grub_machine_fini() or a similar routine, than to give read specific knowledge that its data needs this kind of special protection. Besides, it wouldn't be that simple since the data is controlled by the user v

Re: [PATCH] tell the user why they are in rescue mode

2008-02-10 Thread Robert Millan
On Sat, Feb 09, 2008 at 03:42:24PM +, Sam Morris wrote: > > > > Agreed. See attached patch. Does this work as expected ? > > Yes, it works fine. Ok, committed. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.

Re: [PATCH] read --echo=[yes|no|wildcard]

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 11:41:35AM -0500, Isaac Dupree wrote: > Robert Millan wrote: > >On Sun, Feb 10, 2008 at 08:56:18AM -0500, Isaac Dupree wrote: > >>Robert Millan wrote: > >>>Adds a parameter to define echoing behaviour in read. Then one can use > >>>--echo=no or --echo=wildcard to make it su

Re: Generic halt and reboot commands (was: Re: grub2 efi patches)

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 05:37:27PM +0100, Alexandre Boeglin wrote: > > * commands/halt.c: ... to here. > Add some precompiler directive to include the correct header for each > machine. Can we simplify this? Since grub_halt() is put in kernel anyway, why not always export it from kernel.h ?

Re: [PATCH] read --echo=[yes|no|wildcard]

2008-02-10 Thread Isaac Dupree
Robert Millan wrote: On Sun, Feb 10, 2008 at 08:56:18AM -0500, Isaac Dupree wrote: Robert Millan wrote: Adds a parameter to define echoing behaviour in read. Then one can use --echo=no or --echo=wildcard to make it suitable for reading passwords. I wonder how suitable it is for passwords -- is

Generic halt and reboot commands (was: Re: grub2 efi patches)

2008-02-10 Thread Alexandre Boeglin
Le mar 05 fév 2008 à 23:10:23 +0100, Robert Millan a écrit : > On Tue, Feb 05, 2008 at 10:39:29PM +0100, Alexandre Boeglin wrote: > > Le mer 23 jan 2008 à 12:43:31 +0100, Robert Millan a écrit : > > > commands/ieee1275/halt.c looks like the same thing to me. Perhaps it'd > > > make > > > more sen

Re: [PATCH] read --echo=[yes|no|wildcard]

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 08:56:18AM -0500, Isaac Dupree wrote: > Robert Millan wrote: > >Adds a parameter to define echoing behaviour in read. Then one can use > >--echo=no or --echo=wildcard to make it suitable for reading passwords. > > I wonder how suitable it is for passwords -- is the memory

Re: [PATCH] Create floppy emulation boot CD with grub-mkimage

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 02:43:40PM +0100, Christian Franke wrote: > > This results in 6 possible image variants: > > 1. Floppy: --image-type=floppy > 2. CD, no emulation: --image-type=cdrom [--emulation=none] > 3. CD, floppy emulation: --image-type=cdrom --emulation=floppy

Re: [PATCH] Ensure boot CD can be accessed

2008-02-10 Thread Christian Franke
Bean wrote: On Feb 10, 2008 8:47 PM, Christian Franke <...> wrote: Bean wrote: On Feb 10, 2008 8:23 PM, Christian Franke <...> wrote: ... i think we can assume grub_boot_drive as (cd0) if it's within range, and start scanning from grub_boot_drive + 1. Yes, I

Re: [PATCH] read --echo=[yes|no|wildcard]

2008-02-10 Thread Isaac Dupree
Robert Millan wrote: Adds a parameter to define echoing behaviour in read. Then one can use --echo=no or --echo=wildcard to make it suitable for reading passwords. I wonder how suitable it is for passwords -- is the memory always erased before jumping to e.g. Linux? (and is it important to hi

Re: [PATCH] Create floppy emulation boot CD with grub-mkimage

2008-02-10 Thread Christian Franke
Pavel Roskin wrote: On Sat, 2008-02-09 at 22:59 +0100, Robert Millan wrote: --boot-type=(native|emulation) select cdrom native (default) or floppy emulation boot type Since it is a flag for enabling a compatibility option, I think it's more like a boolean.

[PATCH] read --echo=[yes|no|wildcard]

2008-02-10 Thread Robert Millan
Adds a parameter to define echoing behaviour in read. Then one can use --echo=no or --echo=wildcard to make it suitable for reading passwords. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.) 2008-02-10 Robert Mil

Re: [PATCH] implement menu_lock

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 02:09:40PM +0100, Robert Millan wrote: > diff -x configure -x config.h.in -x CVS -x '*~' -x '*.mk' -urp > ../grub2/normal/misc.c ./normal/misc.c > --- ../grub2/normal/misc.c2007-10-15 12:59:38.0 +0200 > +++ ./normal/misc.c 2008-02-09 21:32:39.0 +0100

[PATCH] implement menu_lock

2008-02-10 Thread Robert Millan
Implement menu_lock. This is a variable that locks the menu when set. It can be used by users to lock the menu, although there's no way to authenticate users for unlocking it, yet (but the procedure would be independant from this interface). -- Robert Millan I know my rights; I want my phone

Re: [PATCH] if timeout is set to zero, don't bother drawing the menu

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 08:10:13AM +0100, Yoshinori K. Okuji wrote: > On Saturday 09 February 2008 23:09, Robert Millan wrote: > > On Sat, Feb 09, 2008 at 09:03:09PM +0100, Yoshinori K. Okuji wrote: > > > On Friday 08 February 2008 17:18, Robert Millan wrote: > > > > Fixes an ugly result of setting

Re: [PATCH] Ensure boot CD can be accessed

2008-02-10 Thread Bean
On Feb 10, 2008 8:47 PM, Christian Franke <[EMAIL PROTECTED]> wrote: > Bean wrote: > > On Feb 10, 2008 8:23 PM, Christian Franke <...> wrote: > > > >> ... > >> 2008-02-10 Christian Franke <[EMAIL PROTECTED]> > >> > >> * disk/i386/pc/biosdisk.c: Include . > >> (GRUB_MOD_INIT): Make

Re: [PATCH] Ensure boot CD can be accessed

2008-02-10 Thread Christian Franke
Bean wrote: On Feb 10, 2008 8:23 PM, Christian Franke <...> wrote: ... 2008-02-10 Christian Franke <[EMAIL PROTECTED]> * disk/i386/pc/biosdisk.c: Include . (GRUB_MOD_INIT): Make boot CD accessible even if BIOS does not report INT13 Extensions for grub_boot_drive.

Re: [PATCH] Ensure boot CD can be accessed

2008-02-10 Thread Bean
On Feb 10, 2008 8:23 PM, Christian Franke <[EMAIL PROTECTED]> wrote: > Detecting BIOS CD device by INT13 "Check Extensions" (AH=42) call does > not work for all BIOSes. > > This patch fixes this to allow access to the boot CD. > > See also thread "[PATCH] Create floppy emulation boot CD with > grub

[PATCH] Ensure boot CD can be accessed

2008-02-10 Thread Christian Franke
Detecting BIOS CD device by INT13 "Check Extensions" (AH=42) call does not work for all BIOSes. This patch fixes this to allow access to the boot CD. See also thread "[PATCH] Create floppy emulation boot CD with grub-mkimage". The "(cd0" patch from Bean is not included here but should also be

Re: [PATCH] Create floppy emulation boot CD with grub-mkimage

2008-02-10 Thread Christian Franke
Bean wrote: On Feb 10, 2008 12:53 AM, Christian Franke <...> wrote: ... Results: PC: grub_boot_drive=0x9f, but INT13 Extensions reported for 0x9f VMware: grub_boot_drive=0x9f VirtualPC: grub_boot_drive=0xef VirtualBox: grub_boot_drive=0xe0 GRUB_MOD_INIT(biosdisk) detects INT13 Extensions

Re: parser eats '=' after variable names

2008-02-10 Thread Bean
On Feb 10, 2008 8:10 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > > On Sun, Feb 10, 2008 at 05:55:25PM +0800, Bean wrote: > > On Feb 10, 2008 5:15 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > > > > > > It seems that the parser eats the extra '=' when used after a variable > > > evaluation: > >

Re: help-grub

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 11:24:40AM +0100, Yoshinori K. Okuji wrote: > > Was it intentional to not have reply-to set? > > Yes. help-grub is not a member-only list, as well as bug-grub, so it is > better > to reply to all. IIRC the last time you explained why using reply-to, you also mentioned pr

Re: [OT] A help-grub mailing is now there.

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 11:44:40AM +0530, shirish wrote: > Hi all, > Somebody has made a help-grub mailing list so users like me can > get their queries asked & solved. I would request some of the whizzes > to also subscribe to the same so queries can be solved. Thanks for pointing this out.

Re: [patch] more descriptive unknown glyph picture

2008-02-10 Thread Robert Millan
On Sat, Feb 09, 2008 at 06:01:31PM -0500, Pavel Roskin wrote: > On Sat, 2008-02-09 at 23:06 +0100, Robert Millan wrote: > > > I think using system fonts is fine. Current update-grub has logic to detect > > them, and enable them when present. It checks (via grub-probe) that GRUB > > will > > be

Re: parser eats '=' after variable names

2008-02-10 Thread Robert Millan
On Sun, Feb 10, 2008 at 05:55:25PM +0800, Bean wrote: > On Feb 10, 2008 5:15 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > > > > It seems that the parser eats the extra '=' when used after a variable > > evaluation: > > > > grub> set a=a > > grub> echo $a > > a > > grub> echo $a= > > > > grub> > >

Re: [patch] more descriptive unknown glyph picture

2008-02-10 Thread Vesa Jääskeläinen
Pavel Roskin wrote: On Sat, 2008-02-09 at 23:06 +0100, Robert Millan wrote: I think using system fonts is fine. Current update-grub has logic to detect them, and enable them when present. It checks (via grub-probe) that GRUB will be able to read them before doing so. Additionaly, the grub.cf

Re: [patch] more descriptive unknown glyph picture

2008-02-10 Thread Vesa Jääskeläinen
Vesa Jääskeläinen wrote: Here is a patch that changes this gray pattern for unknown glyphs to rounded question mark. This way user knows that something is missing :) (and it is easily visible). Committed. ___ Grub-devel mailing list Grub-devel@gnu.

Re: help-grub

2008-02-10 Thread Yoshinori K. Okuji
On Sunday 10 February 2008 10:26, Vesa Jääskeläinen wrote: > Yoshinori K. Okuji wrote: > > We have created a new mailing list specific to support requests: > > help-grub. From now on, if you need help on how to use GRUB, please post > > a message to help-grub instead of bug-grub or grub-devel. > >

Re: parser eats '=' after variable names

2008-02-10 Thread Bean
On Feb 10, 2008 5:15 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > > It seems that the parser eats the extra '=' when used after a variable > evaluation: > > grub> set a=a > grub> echo $a > a > grub> echo $a= > > grub> > > This breaks e.g. variable comparison via "test $a=b". Does someone have an

Re: [PATCH] a.out support for multiboot and freebsd

2008-02-10 Thread Bean
On Feb 10, 2008 5:22 PM, Vesa Jääskeläinen <[EMAIL PROTECTED]> wrote: > > Bean wrote: > > On Feb 10, 2008 5:57 AM, walt <[EMAIL PROTECTED]> wrote: > >> Bean wrote: > >>> Hi, > >>> > >>> This patch add a.out support for multiboot. It also support the boot2 > >>> loader (a.out format) of freebsd: > >

Re: help-grub

2008-02-10 Thread Vesa Jääskeläinen
Yoshinori K. Okuji wrote: We have created a new mailing list specific to support requests: help-grub. From now on, if you need help on how to use GRUB, please post a message to help-grub instead of bug-grub or grub-devel. http://lists.gnu.org/mailman/listinfo/help-grub Hi Okuji, Was it inte

Re: [PATCH] a.out support for multiboot and freebsd

2008-02-10 Thread Vesa Jääskeläinen
Bean wrote: On Feb 10, 2008 5:57 AM, walt <[EMAIL PROTECTED]> wrote: Bean wrote: Hi, This patch add a.out support for multiboot. It also support the boot2 loader (a.out format) of freebsd: set root=(hd0,0,a) aout_freebsd /boot/loader boot 2008-02-10 Bean<[EMAIL PROTECTED]> ... Hi Bean, and