Re: aout support almost working now

2008-02-06 Thread Robert Millan
On Wed, Feb 06, 2008 at 04:26:15PM -0800, walt wrote: > >diff --git a/kern/i386/loader.S b/kern/i386/loader.S > >index 266f4ef..88f3045 100644 > >--- a/kern/i386/loader.S > >+++ b/kern/i386/loader.S > >@@ -137,6 +137,7 @@ FUNCTION(grub_multiboot_real_boot) > > cli > > > > /* Move the m

Re: aout support almost working now

2008-02-06 Thread walt
Bean wrote: On Feb 7, 2008 3:23 AM, walt<[EMAIL PROTECTED]> wrote: With Bean's last two commits I can almost replace legacy with grub2 at least on x86. I have still one problem with the aout support that Bean posted as a patch on Jan 27. Using legacy, which loads the FreeBSD /boot/loader as t

Re: grub2 and Linux software RAID devices

2008-02-06 Thread Yoshinori K. Okuji
On Thursday 07 February 2008 00:19, Sam Morris wrote: > On Wed, 06 Feb 2008 00:49:24 +, Sam Morris wrote: > > Then the screen blanks, and the next thing printed is: > > > > Welcome to GRUB! > > > > Entering into rescue mode... > > grub rescue> > > > > Whereupon I can enter 'insmod normal' an

[PATCH] sanity checks for RAID

2008-02-06 Thread Robert Millan
A pair of sanity checks for RAID. Jeroen, I'd appreciate if you could have a quick look. The second case I haven't run into, but the first I have (in a single-disk RAID0 I setup for testing). I wonder if I'm fixing the symptoms of a bug rather than the bug, but I really don't see what could be

Re: grub2 and Linux software RAID devices

2008-02-06 Thread Sam Morris
On Wed, 06 Feb 2008 00:49:24 +, Sam Morris wrote: > Then the screen blanks, and the next thing printed is: > > Welcome to GRUB! > > Entering into rescue mode... > grub rescue> > > Whereupon I can enter 'insmod normal' and then 'normal' to get to the > regular boot menu. I modified the g

Re: [PATCH] fix for partmap detection on RAID/LVM

2008-02-06 Thread Robert Millan
On Wed, Feb 06, 2008 at 10:18:40PM +0100, Robert Millan wrote: > + while (list) > + { > + probe_partmap (list->disk); > + list = list->next; > + } Ah yes, I forgot to free() the structure here. -- Robert Millan I know my rights; I want my phone call! What use is a pho

Re: [PATCH] simplify grub_raid_array

2008-02-06 Thread Robert Millan
On Wed, Feb 06, 2008 at 11:43:39PM +0100, Jeroen Dekkers wrote: > At Wed, 6 Feb 2008 17:45:07 +0100, > Robert Millan wrote: > > Unless I missed something, it seems that grub_raid_array contains redundant > > information (`name' is already present via `disk->name'). I propose to > > simplify it thi

Re: [PATCH] simplify grub_raid_array

2008-02-06 Thread Jeroen Dekkers
At Wed, 6 Feb 2008 17:45:07 +0100, Robert Millan wrote: > Unless I missed something, it seems that grub_raid_array contains redundant > information (`name' is already present via `disk->name'). I propose to > simplify it this way. No idea why, I don't have the time to look at the actual code, but

[PATCH] fix for partmap detection on RAID/LVM

2008-02-06 Thread Robert Millan
This is my proposed approach for fixing the partmap detection problem in LVM/RAID. The problem: grub-probe just tests for partmap in the target drive directly (which usually doesn't have any), and not in the physical drives that make the RAID array (or LVM volume). My proposed solution: RAID im

Re: [PATCH] simplify partmap probe

2008-02-06 Thread Robert Millan
On Wed, Feb 06, 2008 at 05:43:21PM +0100, Robert Millan wrote: > > Simplification for partmap probing function. Committed. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)

Re: [PATCH] Fix crash on open of nonexisting tar/cpio file, fix cpio trailer detection

2008-02-06 Thread Bean
On Feb 7, 2008 3:18 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Wed, Feb 06, 2008 at 03:29:45PM +0800, Bean wrote: > > > This patch fixes both issues. > > > > Actually, the first version of grub_cpio_find_file returned > > GRUB_ERR_FILE_NONE when the end of file is encounter, but then, > > so

Re: aout support almost working now

2008-02-06 Thread Bean
On Feb 7, 2008 3:23 AM, walt <[EMAIL PROTECTED]> wrote: > With Bean's last two commits I can almost replace legacy with grub2 > at least on x86. I have still one problem with the aout support that > Bean posted as a patch on Jan 27. > > Using legacy, which loads the FreeBSD /boot/loader as the 'ke

aout support almost working now

2008-02-06 Thread walt
With Bean's last two commits I can almost replace legacy with grub2 at least on x86. I have still one problem with the aout support that Bean posted as a patch on Jan 27. Using legacy, which loads the FreeBSD /boot/loader as the 'kernel', loader then reads its config files from the /boot directo

Re: [PATCH] Fix crash on open of nonexisting tar/cpio file, fix cpio trailer detection

2008-02-06 Thread Robert Millan
On Wed, Feb 06, 2008 at 03:29:45PM +0800, Bean wrote: > > This patch fixes both issues. > > Actually, the first version of grub_cpio_find_file returned > GRUB_ERR_FILE_NONE when the end of file is encounter, but then, > somebody find out that opening non existent file have problem, and the > resul

Re: [PATCH] Fix crash on open of nonexisting tar/cpio file, fix cpio trailer detection

2008-02-06 Thread Christian Franke
Robert Millan wrote: 2008-02-05 Christian Franke <[EMAIL PROTECTED]> * fs/cpio.c (grub_cpio_find_file): Return GRUB_ERR_NONE and (*ofs = 0) instead of GRUB_ERR_FILE_NOT_FOUND on last I would suggest "(and set *ofs = 0)" here to make it clearer. OK. 2008-02-06

[PATCH] use debug=all in util/ to increase verbosity

2008-02-06 Thread Robert Millan
What do you think of this? It worked very well for me when I just wanted to debug a problem with disk/raid.c. Should we add the same to other util/ commands like grub-setup ? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as s

[PATCH] simplify partmap probe

2008-02-06 Thread Robert Millan
Simplification for partmap probing function. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.) * util/grub-probe.c (probe): Simplify partmap probing (with the assumption that the first word up to the underscore eq

[PATCH] simplify grub_raid_array

2008-02-06 Thread Robert Millan
Unless I missed something, it seems that grub_raid_array contains redundant information (`name' is already present via `disk->name'). I propose to simplify it this way. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on

Re: multiboot2 vs. grub2 implementation

2008-02-06 Thread Robert Millan
On Sun, Feb 03, 2008 at 10:39:33AM -0600, [EMAIL PROTECTED] wrote: > Hi, > > In the course of actually trying to use the MultibootDraft, I've discovered > some places where the draft and the grub2 implementation differ. > > * Multiboot Information Tags > * Start Tag > The Draft says key is

[PATCH] improve error messages

2008-02-06 Thread Robert Millan
Just a few error message improvements. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.) * disk/raid.c (grub_raid_open, grub_raid_scan_device): Add a few grub_dprintf() calls. * kern/disk.c (grub_disk_read): Incl

Re: booting kernel of NetBSD (Re: UFS (FFS) support seems broken in grub2)

2008-02-06 Thread Bean
On Feb 6, 2008 11:32 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Sat, Jan 26, 2008 at 11:01:49PM +0800, Bean wrote: > > > > * loader/i386/pc/multiboot.c (grub_multiboot_load_elf32): Get physical > > address of entry. > > (grub_multiboot_load_elf64): Likewise. > > (grub

Re: multiboot2 vs. grub2 implementation

2008-02-06 Thread Robert Millan
On Wed, Feb 06, 2008 at 11:18:10PM +0800, Bean wrote: > On Feb 6, 2008 8:14 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > > On Tue, Feb 05, 2008 at 05:23:44PM -0800, walt wrote: > > > > > > On Tue, 2008-02-05 at 14:23 -0600, [EMAIL PROTECTED] wrote: > > > > On Sun, Feb 03, 2008 at 09:11:23AM -0800

Re: booting kernel of NetBSD (Re: UFS (FFS) support seems broken in grub2)

2008-02-06 Thread Robert Millan
On Sat, Jan 26, 2008 at 11:01:49PM +0800, Bean wrote: > > * loader/i386/pc/multiboot.c (grub_multiboot_load_elf32): Get physical > address of entry. > (grub_multiboot_load_elf64): Likewise. > (grub_multiboot): Initialize mbi structure. > > > diff --git a/loader/i386/pc/mu

Re: multiboot2 vs. grub2 implementation

2008-02-06 Thread Bean
On Feb 6, 2008 8:14 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Tue, Feb 05, 2008 at 05:23:44PM -0800, walt wrote: > > > > On Tue, 2008-02-05 at 14:23 -0600, [EMAIL PROTECTED] wrote: > > > On Sun, Feb 03, 2008 at 09:11:23AM -0800, walt wrote: > > > > [EMAIL PROTECTED] wrote: > > > >> Hi, > >

Re: multiboot2 vs. grub2 implementation

2008-02-06 Thread Robert Millan
On Tue, Feb 05, 2008 at 05:23:44PM -0800, walt wrote: > > On Tue, 2008-02-05 at 14:23 -0600, [EMAIL PROTECTED] wrote: > > On Sun, Feb 03, 2008 at 09:11:23AM -0800, walt wrote: > > > [EMAIL PROTECTED] wrote: > > >> Hi, > > >> > > >> In the course of actually trying to use the MultibootDraft, I've

Re: Testing Grub2 on EFI

2008-02-06 Thread Robert Millan
On Wed, Feb 06, 2008 at 09:01:36AM +0530, G vijaya Bhaskar Muppana wrote: > > I am not using Mac Machine. I have created EFI environment in USB disk using > DUET, given in https://www.tianocore.org/ I wouldn't recommend going for EFI is you can avoid it. -- Robert Millan I know my rights; I w

Re: Bug#461442: detection of other OSes in update-grub

2008-02-06 Thread Robert Millan
On Wed, Feb 06, 2008 at 11:12:44AM +0100, Fabian Greffrath wrote: > I do not believe this is an overkill. Do you want grub-probe to print > "i-dont-check-my-arguments" (grub-probe --target=device --device > i-dont-check-my-arguments) ? > Even worse, if you select another target than 'device' and

Re: Bug#461442: detection of other OSes in update-grub

2008-02-06 Thread Fabian Greffrath
Hi! From: Marco Gerards Thanks for this patch, however you didn't really describe the problem you are solving. I am not sure if this patch replaces your patch. This thread was initiated with a follow up to a mail Robert sent off-list. So can you please describe what you are doing and why,

Re: [PATCH] Fix crash on open of nonexisting tar/cpio file, fix cpio trailer detection

2008-02-06 Thread Christian Franke
Hi Robert, you wrote: > On Wed, Feb 06, 2008 at 12:02:37AM +0100, Christian Franke wrote: > > Two issues found in current CVS: > > > > 1. Booting a grub2-mkrescue floppy crashes if > > "(memdisk)/boot/grub/grub.cfg" does not exist. This is because > > grub_cpio_open does not set grub_errno if a f