On Thu, 2008-01-24 at 21:43 +, Oleg Strikov wrote:
> But is it correct to check and handle errno in some `library`
> function (now we do) ? I CAN, but i do not have to examine
> errno after each non-error-free call; is it right?
I don't know how grub_errno is suppos
On Thu, Jan 24, 2008 at 10:19:55PM +0100, Yoshinori K. Okuji wrote:
> On Thursday 24 January 2008 19:34, Pavel Roskin wrote:
> > On Thu, 2008-01-24 at 20:08 +0200, Vesa Jääskeläinen wrote:
> > > Previous behavior was working correctly. You have to handle
> > > errorcodes
> > > at some point and tha
On Thu, Jan 24, 2008 at 11:09:17PM +0100, Marco Gerards wrote:
>
> It's nice when people say I am right (it should happen more often).
You're right.
--
Robert Millan
I know my rights; I want my phone call!
What use is a phone call… if you are unable to speak?
(as seen on /.)
__
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes:
> On Thursday 24 January 2008 19:34, Pavel Roskin wrote:
>> On Thu, 2008-01-24 at 20:08 +0200, Vesa Jääskeläinen wrote:
>> > Previous behavior was working correctly. You have to handle
>> > errorcodes
>> > at some point and that means when error is
On Thu, Jan 24, 2008 at 10:26:48PM +0100, Yoshinori K. Okuji wrote:
> On Thursday 24 January 2008 13:39, Robert Millan wrote:
> > So perhaps it's a good idea to release 1.96 with known regressions after
> > all.
>
> I think that would be a nicer approach at this stage. Anyway, nobody expects
> th
On Jan 24, 2008 9:42 PM, Oleg Strikov <[EMAIL PROTECTED]> wrote:
>
> >> Previous behavior was working correctly. You have to handle
> > >> errorcodes
> > >> at some point and that means when error is handled it is zeroed (or
> > >> GRUB_ERR_NONE). So code is in callee where that loop was.
> >
> >
> >> Previous behavior was working correctly. You have to handle
> >> errorcodes
> >> at some point and that means when error is handled it is zeroed (or
> >> GRUB_ERR_NONE). So code is in callee where that loop was.
>
> >I suggest that we never set grub_errno to 0 (except the initialization).
> >T
On Thursday 24 January 2008 20:57, Bean wrote:
> this is the patch, it can list all files.
>
> the main problem of the original code is that it assume that the next
> offset will be current offset + 1, this is not true. the offset is a
> hash value. it can be extracted when going through the B+ tre
On Thursday 24 January 2008 13:40, Robert Millan wrote:
> On Thu, Jan 24, 2008 at 09:46:09AM +0100, Yoshinori K. Okuji wrote:
> > > The multiboot module on i386-ieee1275 was using variables that only
> > > have a meaning on i386-pc (and i386-linuxbios): grub_os_area_addr,
> > > grub_os_area_size,
On Thursday 24 January 2008 13:39, Robert Millan wrote:
> So perhaps it's a good idea to release 1.96 with known regressions after
> all.
I think that would be a nicer approach at this stage. Anyway, nobody expects
that GRUB 2 is rock-solid (am I wrong?), so it would be more convenient for
the d
On Thursday 24 January 2008 12:49, Bean wrote:
> On Jan 24, 2008 7:32 PM, Robert Millan <[EMAIL PROTECTED]> wrote:
> > Sorry, my question was confusing; what I meant is, where is it located
> > when core.img is started. But Just checked in our Linux loader, and it
> > seems to be at a very high a
On Thursday 24 January 2008 19:34, Pavel Roskin wrote:
> On Thu, 2008-01-24 at 20:08 +0200, Vesa Jääskeläinen wrote:
> > Previous behavior was working correctly. You have to handle
> > errorcodes
> > at some point and that means when error is handled it is zeroed (or
> > GRUB_ERR_NONE). So code is
On Thursday 24 January 2008 13:42, Robert Millan wrote:
> Well, if we can collaborate by sharing the same driver collection that's
> even better, of course. This was done for GRUB Legacy, right?
Sure. I had a very short conversation with gpxe developers last year, and we
have agreed that we shou
On Fri, Jan 25, 2008, Bean wrote:
> this is the patch, it can list all files.
>
> the main problem of the original code is that it assume that the next
> offset will be current offset + 1, this is not true. the offset is a
> hash value. it can be extracted when going through the B+ tree.
>
>
this is the patch, it can list all files.
the main problem of the original code is that it assume that the next
offset will be current offset + 1, this is not true. the offset is a
hash value. it can be extracted when going through the B+ tree.
* fs/reiserfs.c (grub_fshelp_node): New membe
On Thu, 2008-01-24 at 13:56 +0100, Robert Millan wrote:
> On Thu, Jan 24, 2008 at 10:21:01AM +0100, Marco Gerards wrote:
> Franklin, implementing grub-set-default is relatively easy, and a good way
> to learn about how GRUB works.
> Basicaly, you just need to do something like ...
I hope that some
On Jan 25, 2008 12:11 AM, Marco Gerards <[EMAIL PROTECTED]> wrote:
this is the patch, it can list all files.
the main problem of the original code is that it assume that the next
offset will be current offset + 1, this is not true. the offset is a
hash value. it can be extracted when going throug
On Thu, 2008-01-24 at 20:08 +0200, Vesa Jääskeläinen wrote:
> Previous behavior was working correctly. You have to handle
> errorcodes
> at some point and that means when error is handled it is zeroed (or
> GRUB_ERR_NONE). So code is in callee where that loop was.
I suggest that we never set gr
On Thu, Jan 24, 2008 at 07:16:06PM +0100, Marco Gerards wrote:
>
> The error cannot be found in the sourcecode. Can you provide the
> *exact* error? Providing a kernel might help as well.
He did: "free magic is broken at 0x5cb60: 0xbb"
Memory corruption, it seems.
> Read how the loader shoul
walt <[EMAIL PROTECTED]> writes:
> Marco Gerards wrote:
>> walt<[EMAIL PROTECTED]> writes:
>>
> ...
>>> I recompiled my NetBSD kernel with the MULTIBOOT option enabled, but
>>> I still get a 'magic broken' error when doing 'multiboot /netbsd'.
>
>> Can it be loaded from GRUB Legacy using its mult
Robert Millan wrote:
On Wed, Jan 23, 2008 at 11:00:57PM +, Oleg Strikov wrote:
Incorrect behavior of grub_file_open () function in e.g. loop context:
char *file_names[] =
{
"(hd0,1)/file1", //file do not exist
"(hd0,1)/file2" //file exist
};
grub_file_t file;
int i;
for (i = 0; i < 2; i++)
Robert Millan <[EMAIL PROTECTED]> writes:
> On Fri, Jan 25, 2008 at 01:04:34AM +0800, Bean wrote:
>> On Jan 25, 2008 12:55 AM, Robert Millan <[EMAIL PROTECTED]> wrote:
>> > On Thu, Jan 24, 2008 at 03:25:51PM +0100, Robert Millan wrote:
>> > >
>> > > You want to add a feature that only works when y
As discussed on two other threads, this patch is a proof of concept of
relocation in the loader.
Some comments:
- grub_protected_malloc() is like malloc, but with the garantee that
it won't overlap with a particular region. Do you think this is the
right approach? Should this be kept
On Fri, Jan 25, 2008 at 01:04:34AM +0800, Bean wrote:
> On Jan 25, 2008 12:55 AM, Robert Millan <[EMAIL PROTECTED]> wrote:
> > On Thu, Jan 24, 2008 at 03:25:51PM +0100, Robert Millan wrote:
> > >
> > > You want to add a feature that only works when you have the ability to
> > > load
> > > images o
On Thu, Jan 24, 2008 at 08:47:52AM -0800, walt wrote:
>
> On Thu, 2008-01-24 at 15:53 +0100, Robert Millan wrote:
> > Btw, if you put that kernel image somewhere, chances are higher that someone
> > gives it a try...
>
> http://rapidshare.com/files/86269193/netbsd.html
Ouch, what an horrid downl
On Jan 25, 2008 12:55 AM, Robert Millan <[EMAIL PROTECTED]> wrote:
> On Thu, Jan 24, 2008 at 03:25:51PM +0100, Robert Millan wrote:
> >
> > You want to add a feature that only works when you have the ability to load
> > images of an arbitrary size. However, if we had this ability we wouldn't
> >
On Thu, Jan 24, 2008 at 03:25:51PM +0100, Robert Millan wrote:
>
> You want to add a feature that only works when you have the ability to load
> images of an arbitrary size. However, if we had this ability we wouldn't have
> to compress core.img, or make it small in the first place. We would the
On Thu, 2008-01-24 at 15:53 +0100, Robert Millan wrote:
> Btw, if you put that kernel image somewhere, chances are higher that someone
> gives it a try...
http://rapidshare.com/files/86269193/netbsd.html
grub2 will certainly get fixed faster if one of you does the fixing :o)
___
Bean <[EMAIL PROTECTED]> writes:
> On Jan 24, 2008 2:30 AM, Antoine Cellerier <[EMAIL PROTECTED]> wrote:
>> Hello,
>>
>> I've been trying to use grub2 with a reiserfs partition and noticed that
>> it couldn't find all my files and folders. nyu and marco_g on IRC
>> suggested that I send a small te
On Jan 24, 2008 2:30 AM, Antoine Cellerier <[EMAIL PROTECTED]> wrote:
> Hello,
>
> I've been trying to use grub2 with a reiserfs partition and noticed that
> it couldn't find all my files and folders. nyu and marco_g on IRC
> suggested that I send a small test case. So here it comes.
>
> The attach
Fabian Greffrath <[EMAIL PROTECTED]> writes:
> At the moment there is still one problem left: os-prober returns the
> partition on which it finds the OS as a system device name,
> e.g. /dev/hda2. At the moment, GRUB does not provide an (easy) way to
> translate these into GRUB drives, e.g. (hd0,1)
On Thu, Jan 24, 2008 at 10:57:46PM +0800, Bean wrote:
> >
> > However, my point is more about the loadee than the loader. We provide a
> > multiboot image, which can also be a linux image with lnxboot.img, however,
> > this image needs to be very small, because it's intended usage is with
> > grub
On Jan 24, 2008 10:25 PM, Robert Millan <[EMAIL PROTECTED]> wrote:
>
> On Thu, Jan 24, 2008 at 07:49:23PM +0800, Bean wrote:
> > On Jan 24, 2008 7:32 PM, Robert Millan <[EMAIL PROTECTED]> wrote:
> > > Sorry, my question was confusing; what I meant is, where is it located
> > > when
> > > core.img
Btw, if you put that kernel image somewhere, chances are higher that someone
gives it a try. Setting up a NetBSD system (and figuring out how to play with
kernel options) just to test that can be too much of a hassle for most of us.
--
Robert Millan
I know my rights; I want my phone call!
Wh
On Thu, Jan 24, 2008 at 06:20:07AM -0800, walt wrote:
> >Do you want to work on a loader for BSD? That would be the ideal
> >solution and a nice opportunity for you to learn :-)
>
> Sure, but don't expect very much :o) We know that grub legacy can
> boot NetBSD, so maybe I can get grub2 to do th
On Thu, Jan 24, 2008 at 07:49:23PM +0800, Bean wrote:
> On Jan 24, 2008 7:32 PM, Robert Millan <[EMAIL PROTECTED]> wrote:
> > Sorry, my question was confusing; what I meant is, where is it located when
> > core.img is started. But Just checked in our Linux loader, and it seems to
> > be
> > at a
Marco Gerards wrote:
walt<[EMAIL PROTECTED]> writes:
...
I recompiled my NetBSD kernel with the MULTIBOOT option enabled, but
I still get a 'magic broken' error when doing 'multiboot /netbsd'.
Can it be loaded from GRUB Legacy using its multiboot capabilities?
Yes!
Do you want to work
Anyone could have a look at this?
I can't verify that the code is right, but it doesn't modify or remove
existing code, so if it's unlikely that it will introduce regressions.
Btw, Mikhail, your code doesn't seem to do anything about "self-loading"
(i.e. preventing code from overwriting itself,
On Jan 24, 2008 8:14 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> It would be nice, not required. I don't expect too much problems
> here...
>
> Perhaps a better approach would be possible to do a check after
> reading a size:
>
> int size = foo();
>
> Check the size of the file here
>
> while (
On Thu, Jan 24, 2008 at 10:21:01AM +0100, Marco Gerards wrote:
>
> Robert, do you know if Guillem is still willing to work on this? I
> thought you know him quite well, so I start asking you here. He had
> some code two years ago when I met him at FOSDEM. IIRC the problem
> was that we didn't h
Robert Millan <[EMAIL PROTECTED]> writes:
> On Thu, Jan 24, 2008 at 09:40:31AM +0100, Yoshinori K. Okuji wrote:
>>
>> All I need is ping from Robert. My preference is to publish a new version
>> regularly, no matter whatever bugs remain (yeah, I am very aggressive in
>> GRUB
>> 2), but he stop
On Thu, Jan 24, 2008 at 01:26:47PM +0100, Robert Millan wrote:
>
> I had preliminar (working!) code to implement this, but it's a hack. We
> really
> need to think this over first, as it might imply some redesign of the memory
> manager, etc.
In the meantime what do you think of doing the same
On Thu, Jan 24, 2008 at 09:49:22AM +0100, Yoshinori K. Okuji wrote:
> On Wednesday 23 January 2008 16:46, Douglas Ward wrote:
> > Robert Millan wrote:
> > > On Wed, Jan 23, 2008 at 12:38:31PM +0100, Marco Gerards wrote:
> > >> But to be honest, there are more important issues than networking in
> >
On Thu, Jan 24, 2008 at 09:46:09AM +0100, Yoshinori K. Okuji wrote:
> >
> > The multiboot module on i386-ieee1275 was using variables that only have a
> > meaning on i386-pc (and i386-linuxbios): grub_os_area_addr,
> > grub_os_area_size, grub_lower_mem and grub_upper_mem. A bunch of
> > unnecessa
On Thu, Jan 24, 2008 at 09:40:31AM +0100, Yoshinori K. Okuji wrote:
>
> All I need is ping from Robert. My preference is to publish a new version
> regularly, no matter whatever bugs remain (yeah, I am very aggressive in GRUB
> 2), but he stopped me releasing 1.96 previosly, IIRC.
I didn't mean
On Wed, Jan 23, 2008 at 05:21:26PM -0800, walt wrote:
> Robert Millan wrote:
> >On Wed, Jan 23, 2008 at 02:49:55PM -0800, walt wrote:
> >>I recompiled my NetBSD kernel with the MULTIBOOT option enabled, but
> >>I still get a 'magic broken' error when doing 'multiboot /netbsd'.
> >
> >The kernel of
On Thu, Jan 24, 2008 at 12:59:44PM +0100, Marco Gerards wrote:
> >
> > I remember about the video mode issue, but IIRC it only affects i386-pc.
> > Also,
> > I don't think anyone will assume serial port to be in a particular state
> > during
> > boot. Do we have similar concerns on ieee1275 ?
>
Dear GRUB-developers,
I recently had a discussion with the GRUB-maintainers in Debian if it
will be possible to add other (maybe proprietary, preinstalled) OSes to
the GRUB boot menu when update-grub is run [1]. This happens
automatically when Debian is installed (via the Debian-Installer) usi
Bean <[EMAIL PROTECTED]> writes:
> On Jan 24, 2008 4:29 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
>> Bean <[EMAIL PROTECTED]> writes:
>>
>> > On Jan 23, 2008 6:36 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
>> >> > static grub_uint32_t
>> >> > grub_png_get_dword (struct grub_png_data *data)
>>
On Thu, Jan 24, 2008 at 01:21:18AM +0100, Franklin PIAT wrote:
> I've just had a look at yesterday's commit, which introduces --overlay.
> great ! (Debian's Unstable is a few day behind cvs)
>
> Since I wanted to test splashscreen, I needed to put unicode.pff
> (1480KiB) + a tga image (1200KiB unc
On Jan 24, 2008 4:29 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> Bean <[EMAIL PROTECTED]> writes:
>
> > On Jan 23, 2008 6:36 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> >> > static grub_uint32_t
> >> > grub_png_get_dword (struct grub_png_data *data)
> >> > {
> >> > grub_uint32_t r;
> >> >
>
"Franklin PIAT" <[EMAIL PROTECTED]> writes:
> On Thu, January 24, 2008 10:05, Yoshinori K. Okuji wrote:
>> On Wednesday 23 January 2008 23:27, Robert Millan wrote:
>>> On Wed, Jan 23, 2008 at 10:50:50PM +0100, Franklin PIAT wrote:
>>> > Hello,
>>> >
>>> > I've started more manpages :
> [..]
>>> >
Robert Millan <[EMAIL PROTECTED]> writes:
> On Thu, Jan 24, 2008 at 09:57:45AM +0100, Yoshinori K. Okuji wrote:
>> > How important is it to unload all modules? What do you suggest? Do we fix
>> > everything to unload all modules (is that even possible?)? Do we unload
>> > all modules on i386-pc
On Jan 24, 2008 7:32 PM, Robert Millan <[EMAIL PROTECTED]> wrote:
> Sorry, my question was confusing; what I meant is, where is it located when
> core.img is started. But Just checked in our Linux loader, and it seems to be
> at a very high address.
>
> However, a very high address doesn't garant
On Thu, Jan 24, 2008 at 09:57:45AM +0100, Yoshinori K. Okuji wrote:
> > How important is it to unload all modules? What do you suggest? Do we fix
> > everything to unload all modules (is that even possible?)? Do we unload
> > all modules on i386-pc "because we can" and not do this on ieee1275
>
On Thu, Jan 24, 2008 at 11:40:25AM +0800, Bean wrote:
> On Jan 24, 2008 5:15 AM, Robert Millan <[EMAIL PROTECTED]> wrote:
> >
> > On Thu, Jan 24, 2008 at 05:04:56AM +0800, Bean wrote:
> > > On Jan 24, 2008 4:15 AM, Robert Millan <[EMAIL PROTECTED]> wrote:
> > > > The region where memdisk is normall
On Thu, January 24, 2008 10:05, Yoshinori K. Okuji wrote:
> On Wednesday 23 January 2008 23:27, Robert Millan wrote:
>> On Wed, Jan 23, 2008 at 10:50:50PM +0100, Franklin PIAT wrote:
>> > Hello,
>> >
>> > I've started more manpages :
[..]
>> > What would be your preferred file format ?
> Info is ma
Robert Millan <[EMAIL PROTECTED]> writes:
> On Wed, Jan 23, 2008 at 10:33:24PM +0100, Franklin PIAT wrote:
>> Hello,
>>
>> For my personal needs, i've written a script to build floppy or
>> hard-disk images.
>>
>> It's very similar to mkgrub-rescue.sh (and slightly based on it),
>> except the im
Robert Millan <[EMAIL PROTECTED]> writes:
> On Wed, Jan 23, 2008 at 10:50:50PM +0100, Franklin PIAT wrote:
>> Hello,
>>
>> I've started more manpages :
>> http://wiki.debian.org/Grub/grub-install.manpage
>> http://wiki.debian.org/Grub/grub-mkimage.manpage
>> http://wiki.debian.org/Grub/grub-mkres
Franklin PIAT <[EMAIL PROTECTED]> writes:
Hi,
> On Thu, 2008-01-24 at 09:35 +0100, Marco Gerards wrote:
>> Franklin PIAT <[EMAIL PROTECTED]> writes:
>> > Grub2 doesn't seems to have a feature similar to grub1 "default=saved"
>> > in menu.lst, does it ?
>>
>> Not yet, but we want it. Do you want
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes:
[...]
>> Not at all. Christian can be added to as far as I am concerned.
>> Would you mind?
>
> You know, I like to give write access to everybody, whenever legally
> allowed. ;)
Yeah, I know I am way more conservative as a maintainer than you
a
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes:
> On Wednesday 23 January 2008 12:44, Robert Millan wrote:
>> On Wed, Jan 23, 2008 at 12:39:35PM +0100, Marco Gerards wrote:
>> > Alexandre Boeglin <[EMAIL PROTECTED]> writes:
>> > > On Sun, 18 Nov 2007 19:14:03 +0100, Alexandre Boeglin
>> > > <[EMA
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes:
> On Wednesday 23 January 2008 12:32, Marco Gerards wrote:
>> > Which reminds me, is 1.96 coming soon? When lvm/raid, reiserfs and
>> > powerpc issues are fixed, it might be a good time. What do you think?
>>
>> Fine for me, we didn't have a relea
On Wednesday 23 January 2008 23:27, Robert Millan wrote:
> On Wed, Jan 23, 2008 at 10:50:50PM +0100, Franklin PIAT wrote:
> > Hello,
> >
> > I've started more manpages :
> > http://wiki.debian.org/Grub/grub-install.manpage
> > http://wiki.debian.org/Grub/grub-mkimage.manpage
> > http://wiki.debian.
Marco,
On Thu, 2008-01-24 at 09:35 +0100, Marco Gerards wrote:
> Franklin PIAT <[EMAIL PROTECTED]> writes:
> > Grub2 doesn't seems to have a feature similar to grub1 "default=saved"
> > in menu.lst, does it ?
>
> Not yet, but we want it. Do you want to work on this?
I wish I could ;) I haven't
On Wednesday 23 January 2008 20:58, Robert Millan wrote:
> Is GRUB supposed to always call grub_dl_unload_all() when preparing to
> jump into a loaded multiboot image?
Yes.
> How important is it to unload all modules? What do you suggest? Do we fix
> everything to unload all modules (is that ev
On Wednesday 23 January 2008 16:46, Douglas Ward wrote:
> Robert Millan wrote:
> > On Wed, Jan 23, 2008 at 12:38:31PM +0100, Marco Gerards wrote:
> >> But to be honest, there are more important issues than networking in
> >> the short term...
> >
> > ACK. Let's focus on what GRUB excels at, instea
On Wednesday 23 January 2008 15:53, Robert Millan wrote:
> On Wed, Jan 23, 2008 at 03:05:31PM +0100, Marco Gerards wrote:
> > Robert Millan <[EMAIL PROTECTED]> writes:
> > > Some cleanup for i386-ieee1275.
> >
> > Can you please give a bit more information?
>
> The multiboot module on i386-ieee1275
On Wednesday 23 January 2008 13:25, Marco Gerards wrote:
> "Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes:
>
> Hi,
>
> > I think it would be more convenient to allow Bean and Alexandre to check
> > in changes themselves. Is there any objection?
>
> Not at all. Christian can be added to as far as
On Wednesday 23 January 2008 12:32, Marco Gerards wrote:
> > Which reminds me, is 1.96 coming soon? When lvm/raid, reiserfs and
> > powerpc issues are fixed, it might be a good time. What do you think?
>
> Fine for me, we didn't have a release for quite a while. To be
> honest, I just hate the u
On Wednesday 23 January 2008 12:44, Robert Millan wrote:
> On Wed, Jan 23, 2008 at 12:39:35PM +0100, Marco Gerards wrote:
> > Alexandre Boeglin <[EMAIL PROTECTED]> writes:
> > > On Sun, 18 Nov 2007 19:14:03 +0100, Alexandre Boeglin
> > > <[EMAIL PROTECTED]>
> > >
> > > wrote:
> > >> I also still ha
Franklin PIAT <[EMAIL PROTECTED]> writes:
Hi,
> Grub2 doesn't seems to have a feature similar to grub1 "default=saved"
> in menu.lst, does it ?
Not yet, but we want it. Do you want to work on this?
--
Marco
___
Grub-devel mailing list
Grub-devel@g
walt <[EMAIL PROTECTED]> writes:
> Bean wrote:
>> On Jan 24, 2008 12:15 AM, walt<[EMAIL PROTECTED]> wrote:
>>> Bean wrote:
This patch should fix the problem...
>>> Yes, thanks! I had to use the -l flag before patch would use it,
>>> and even then the last hunk needed increased fuzz.
>>>
>>>
Bean <[EMAIL PROTECTED]> writes:
> On Jan 23, 2008 6:36 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
>> > static grub_uint32_t
>> > grub_png_get_dword (struct grub_png_data *data)
>> > {
>> > grub_uint32_t r;
>> >
>> > r = 0;
>>
>> Why this?
>
> just to make sure if grub_file_read fails, this
74 matches
Mail list logo