Re: [go-nuts] Re: RFC - Review request for a project done in Golang

2018-05-15 Thread Sankar P
In case someone is curios, I did refactor the code a lot more, to bring down the gocyclo complexity from 23 to 11. I feel that this should be in a better shape now. Thanks everyone for the comments. Let me know if you still find any scope for optimisation or cleanup. I would add some test cases to

Re: [go-nuts] Re: RFC - Review request for a project done in Golang

2018-05-14 Thread Sankar P
2018-05-14 20:39 GMT+05:30 : > They might have been looking for something like this: > > github.com/psankar/network-monitor > package monitor code files > cmd/ > minion/ > package main code files > server/ > package main code files > The reviewer me

Re: [go-nuts] Re: RFC - Review request for a project done in Golang

2018-05-14 Thread Sankar P
2018-05-14 17:28 GMT+05:30 Tamás Gulácsi : > Minion/minion? For what? > So that the minion package structs can be shared between Minion/Minion.go server and the APIServer.go server. > > Also APIServer.go has some goroutine starting loops that are very similar > - should be a function. > I'd pre