Re: [go-nuts] A treemap implemented in go

2018-10-03 Thread Uzondu Enudeme
I've taken note of all your comments. I've added some to my todo list as per the package and made a few improvements. Note that none of these are "the right way", they give you options to make > the code more reusable. I completely get this. Thanks for your time. Uzondu On Wed, Oct 3, 2018 at

Re: [go-nuts] A treemap implemented in go

2018-10-03 Thread Tristan Colgate
In case you haven't already checked it out, you can now see your package at: https://godoc.org/github.com/willpoint/treemap You can do a sort of "GoDoc Driven Design" here, look at the godoc, and decide if the interface is something you would like to use. Some suggestions: - A destination io.Wr

Re: [go-nuts] A treemap implemented in go

2018-10-03 Thread Uzondu Enudeme
Hi Tristan, Thanks again for your helpful feedback. Based on your observations, here's what I've done so far: This would be more useful as a package than a single program. You could > move main into an example/ folder and keep the rest of the content in the > top level as a package. Move the expl

Re: [go-nuts] A treemap implemented in go

2018-10-03 Thread Uzondu Enudeme
Thanks a lot Tristan, The points you mentioned are really all very important ones. I'm currently following all your suggestions and would repost the link to the updated code in case I missed some points. On Wed, Oct 3, 2018, 06:52 Tristan Colgate wrote: > A couple of quick observations. > > T

Re: [go-nuts] A treemap implemented in go

2018-10-02 Thread Tristan Colgate
A couple of quick observations. This would be more useful as a package than a single program. You could move main into an example/ folder and keep the rest of the content in the top level as a package. Move the explanatory comment up as a Package comment. The standard library includes color handl