A couple of quick observations.

This would be more useful as a package than a single program. You could
move main into an example/ folder and keep the rest of the content in the
top level as a package. Move the explanatory comment up as a Package
comment.

The standard library includes color handling, check the image package.

The strconv wrapper is probably a bit excessive for the sake of the cast
(you might not need it if you use color.Color anyway)

The orientation might be better off as a tyoed parameter, look for docs on
typed constants.





On Tue, 2 Oct 2018, 23:06 Uzondu Enudeme, <willpo...@gmail.com> wrote:

> Hi everyone,
>
> I've been following the golang-nuts' email threads for a while now and I'm
> amazed at how much I've learnt seeing ways solutions are profferred.
>
> I implemented a treemap for data visualization, and wrote a process.md
> file giving some sort of background and detail.
>
> I want to use this opportunity to learn what I could have done better by
> asking that the code be reviewed, it's in a single main.go file at
> github.com/willpoint/treemap
>
> Thanks in advance for the time that would be spent and any advice given.
>
>
> Uzondu
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-nuts" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-nuts+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to golang-nuts+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to