Thanks. This will give me a chance to check the new GitHub PR process:
https://github.com/golang/go/pull/24255
On Mon, Mar 5, 2018 at 11:40 AM, Ian Lance Taylor wrote:
> On Mon, Mar 5, 2018 at 10:10 AM, andrey mirtchovski
> wrote:
>>
>> I finally found some time to work on this and I think I fig
On Mon, Mar 5, 2018 at 10:10 AM, andrey mirtchovski
wrote:
>
> I finally found some time to work on this and I think I figured out
> why it fails. I run a very large history file (my HISTSIZE is set to
> 10) and on this particular machine I'm at the limit. This causes
> the os/signal test to r
Hi,
I finally found some time to work on this and I think I figured out
why it fails. I run a very large history file (my HISTSIZE is set to
10) and on this particular machine I'm at the limit. This causes
the os/signal test to run an average 6-7 seconds. The test timeout as
shown in my second
On Tue, Feb 6, 2018 at 2:54 PM, andrey mirtchovski
wrote:
> $ go test -c os/signal
> $ ./signal.test
> PASS
> $ go tool dist test -v
>
> # Testing packages.
> # go tool dist test -run=^go_test:archive/tar$
> [...]
> ok net/url (cached)
> ok os 0.677s
> ok os/exec 1.414s
> --- FAIL: TestTerm
$ go test -c os/signal
$ ./signal.test
PASS
$ go tool dist test -v
# Testing packages.
# go tool dist test -run=^go_test:archive/tar$
[...]
ok net/url (cached)
ok os 0.677s
ok os/exec 1.414s
--- FAIL: TestTerminalSignal (5.01s)
signal_cgo_test.go:138: "PS1='prompt> '\r\n"
signal_cgo_test.go
On Tue, Feb 6, 2018 at 2:28 PM, andrey mirtchovski
wrote:
>
> I'm trying to understand why os/signal tests fail on my 10.12 macbook
> pro at tip:
>
> $ ./all.bash
> [...]
> ok net/textproto (cached)
> ok net/url (cached)
> ok os 0.678s
> ok os/exec 1.185s
> --- FAIL: TestTerminalSignal (5.01s)
I'm trying to understand why os/signal tests fail on my 10.12 macbook
pro at tip:
$ ./all.bash
[...]
ok net/textproto (cached)
ok net/url (cached)
ok os 0.678s
ok os/exec 1.185s
--- FAIL: TestTerminalSignal (5.01s)
signal_cgo_test.go:138: "PS1='prompt> '\r\n"
signal_cgo_test.go:163: timed out
