On Tue, Feb 6, 2018 at 2:28 PM, andrey mirtchovski <mirtchov...@gmail.com> wrote: > > I'm trying to understand why os/signal tests fail on my 10.12 macbook > pro at tip: > > $ ./all.bash > [...] > ok net/textproto (cached) > ok net/url (cached) > ok os 0.678s > ok os/exec 1.185s > --- FAIL: TestTerminalSignal (5.01s) > signal_cgo_test.go:138: "PS1='prompt> '\r\n" > signal_cgo_test.go:163: timed out waiting for shell prompt > FAIL > FAIL os/signal 9.920s > ok os/user (cached) > [...] > > If I run 'go tool dist test -v' the test will fail again: > $ go tool dist test -v > > ##### Testing packages. > # go tool dist test -run=^go_test:archive/tar$ > [...] > ok net/url (cached) > ok os 0.722s > ok os/exec 1.596s > --- FAIL: TestTerminalSignal (5.01s) > signal_cgo_test.go:138: "PS1='prompt> '\r\n" > signal_cgo_test.go:163: timed out waiting for shell prompt > FAIL > FAIL os/signal 9.770s > > > > however if I run the following the test passes and is now cached: > > $ go tool dist test -v -run=^go_test:os/signal$ > > ##### Testing packages. > # go tool dist test -run=^go_test:os/signal$ > ok os/signal 6.468s > > ALL TESTS PASSED (some were excluded) > $ > > and now 'go tool dist test -v' > > $ go tool dist test -v > > ##### Testing packages. > # go tool dist test -run=^go_test:archive/tar$ > [...] > ok net/url (cached) > ok os (cached) > ok os/exec (cached) > ok os/signal (cached) > ok os/user (cached) > [...] > $ > > this lasts until the next all.bash invocation.
I have no idea why this is happening. If you run `go test -c os/signal` and then run `./signal.test`, does the test pass or fail? Is there something specific to how cmd/dist invokes it that causes it to fail? The test is using a pseudo-terminal so it could fail various system-dependent ways, but I don't understand why it would fail in that way. Ian -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
