Re: [go-nuts] goimports has been updated

+1 to this. Would a vendor folder make sense at the same level as the src folder? Make it an override able default. I guess it doesn't address a monorepo approach though or the collocation of generated files like client/server stubs for protobuf/thrift/etc. On Fri, 15 Jul 2016 at 22:30, Dave Chen

Re: [go-nuts] goimports has been updated

$HOME/local/src usage predates Go usage for me, and besides, the structure and content of a GOPATH has merit stretching beyond languages as a simple method for source organization. On Fri, Jul 15, 2016, 4:30 PM Dave Cheney wrote: > Why not put non go code in another directory tree? That seems mu

Re: [go-nuts] goimports has been updated

On 15 July 2016 at 22:30, Dave Cheney wrote: > Why not put non go code in another directory tree? That seems much simpler. I agree with you and see where you're coming from. That was where my original hesitation came from, but... My $GOPATH is .local/src. Why set it anywhere else? Then, why re

Re: [go-nuts] goimports has been updated

Why not put non go code in another directory tree? That seems much simpler. -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.

Re: [go-nuts] goimports has been updated

Muahah. Well I'm sure I can speak for many people when I say we're grateful it's being improved! :) On 15 July 2016 at 21:03, Brad Fitzpatrick wrote: > I am just as relieved. Imagine the pain and frustration you felt on every > slow save but with an additional feeling of guilt that it's probably

Re: [go-nuts] goimports has been updated

I am just as relieved. Imagine the pain and frustration you felt on every slow save but with an additional feeling of guilt that it's probably your fault and you should fix it, and other people use this thing nowadays. :) On Fri, Jul 15, 2016 at 12:56 PM, Peter Waller wrote: > Just saw this w

Re: [go-nuts] goimports has been updated

Just saw this was merged - this is excellent. These latest changes bring the runtime down to 400ms. Wonderful! I had no idea how much this was interrupting my flow before it was fixed :) On 15 July 2016 at 19:34, Brad Fitzpatrick wrote: > > Done: https://go-review.googlesource.com/24971 > --

Re: [go-nuts] goimports has been updated

On Fri, Jul 15, 2016 at 5:47 AM, Peter Waller wrote: > Awesome! > > For me it brings the CPU time from 6.5s to 3s. Wall from 2.9s to 2s. A > noticable improvement. > > One thing that still makes it slow for me (2s instead of 500ms, I just > tested), is that I have several of deep trees which aren

Re: [go-nuts] goimports has been updated

On Fri, Jul 15, 2016 at 9:19 AM, Nathan Youngman wrote: > Thanks Brad. > > I also use $GOPATH ($HOME/src) for code non-Go projects. > > I'd be in favour of a more automated solution to ignoring folders that > don't contain any *.go files (until such time as they start using *.go). > It already d

Re: [go-nuts] goimports has been updated

Thanks Brad. I also use $GOPATH ($HOME/src) for code non-Go projects. I'd be in favour of a more automated solution to ignoring folders that don't contain any *.go files (until such time as they start using *.go). Nathan. On Friday, 15 July 2016 06:48:12 UTC-6, Peter Waller wrote: > > Awesome

Re: [go-nuts] goimports has been updated

Environment variables like (maybe) GOIMPORTSIGNORE/GORENAMEIGNORE fits better with how go tools are currently configured than config files. On Fri, Jul 15, 2016 at 5:38 PM, Peter Waller wrote: > On 15 July 2016 at 16:35, Sam Whited wrote: > >> On Fri, Jul 15, 2016 at 9:49 AM, Peter Waller >> w

Re: [go-nuts] goimports has been updated

On 15 July 2016 at 16:35, Sam Whited wrote: > On Fri, Jul 15, 2016 at 9:49 AM, Peter Waller wrote: > > Another suggestion which might be even nicer for the implementation: if a > > directory contains `.goimportsignore`, that directory is skipped. > > That would have to be in addition to a file t

Re: [go-nuts] goimports has been updated

On Fri, Jul 15, 2016 at 9:49 AM, Peter Waller wrote: > Another suggestion which might be even nicer for the implementation: if a > directory contains `.goimportsignore`, that directory is skipped. That would have to be in addition to a file that lists directories, otherwise you can't skip submodu

Re: [go-nuts] goimports has been updated

On 15.07.2016 16:31, Jan Mercl wrote: On Fri, Jul 15, 2016 at 4:29 PM Thomas Frössman > wrote: > Yeah. I also have (several) linux trees, gcc's and stuff in my GOPATH.. I would really like some global config way to tell goimports/gorename/... to ignore a bunch of

Re: [go-nuts] goimports has been updated

On 15 July 2016 at 15:31, Jan Mercl <0xj...@gmail.com> wrote: > I do not use goimports. My 2c anyway: What about checking for > .goimportsignore in the root of the subtree that should be skipped? > +1. I was going to suggest this but before seeing support for the idea thought it sounded too unsav

Re: [go-nuts] goimports has been updated

On Fri, Jul 15, 2016 at 4:29 PM Thomas Frössman wrote: > Yeah. I also have (several) linux trees, gcc's and stuff in my GOPATH.. I would really like some global config way to tell goimports/gorename/... to ignore a bunch of subtrees. I do not use goimports. My 2c anyway: What about checking for

Re: [go-nuts] goimports has been updated

Yeah. I also have (several) linux trees, gcc's and stuff in my GOPATH.. I would really like some global config way to tell goimports/gorename/... to ignore a bunch of subtrees. -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe fr

Re: [go-nuts] goimports has been updated

Yeah. I also have (several) linux trees, gcc's and stuff in my GOPATH.. I would really like some global config way to tell goimports/gorename/... to ignore a bunch of subtrees. -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe fr

Re: [go-nuts] goimports has been updated

I'd like to second this! Also have the linux tree in $GOPATH, and ever since I put it there goimports slowed down. Some kind of subtree exclusion mechanism would be great. Nevertheless, thank you for your work on probably the most useful Go tool out there, Brad! I can't imagine programming i

Re: [go-nuts] goimports has been updated

Awesome! For me it brings the CPU time from 6.5s to 3s. Wall from 2.9s to 2s. A noticable improvement. One thing that still makes it slow for me (2s instead of 500ms, I just tested), is that I have several of deep trees which aren't go code in my $GOPATH/src. To name a few: linux, clang, llvm. I

Re: [go-nuts] goimports has been updated

On Fri, Jul 15, 2016, at 06:34 AM, Brad Fitzpatrick wrote: > goimports has been updated. > > If you've been frustrated by its speed lately, run: > >$ go get -u golang.org/x/tools/cmd/goimports > > ... and things should be much nicer. > > Details at https://golang.org/cl/24941 Some really ne

[go-nuts] goimports has been updated

goimports has been updated. If you've been frustrated by its speed lately, run: $ go get -u golang.org/x/tools/cmd/goimports ... and things should be much nicer. Details at https://golang.org/cl/24941 If I broke something, file a bug: https://golang.org/issues/new The general speed trackin