[go-rpm-macros] PR #34: Add BUILDTAGS to %gobuildflags

2021-08-30 Thread Ondřej Budai
obudai commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you are following: `` FTR I think this is a very useful addition for packages for which we need to specify a tag while building them in Fedora. `` To reply, visit the link below or just reply to this email https://pagur

[go-rpm-macros] PR #34: Add BUILDTAGS to %gobuildflags

2021-08-30 Thread Neal Gompa
ngompa commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you are following: `` Please prefix it with a `GO_` namespace. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/34 ___

[go-rpm-macros] PR #34: Add BUILDTAGS to %gobuildflags

2021-08-30 Thread Neal Gompa
ngompa commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you are following: `` Or rather, use `GO` prefix instead... `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/34 ___ go

[go-rpm-macros] PR #34: Add BUILDTAGS to %gobuildflags

2021-08-30 Thread Brian C . Lane
bcl commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you are following: `` No -- this needs to match the go-rpm-macros used in c9s: https://gitlab.com/redhat/centos-stream/rpms/go-rpm-macros/-/blob/c9s/remove-fedora-dependency-automation.patch#L215 `` To reply, visit the lin

[go-rpm-macros] PR #34: Add BUILDTAGS to %gobuildflags

2021-08-30 Thread Neal Gompa
ngompa commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you are following: `` > No -- this needs to match the go-rpm-macros used in c9s: > > https://gitlab.com/redhat/centos-stream/rpms/go-rpm-macros/-/blob/c9s/remove-fedora-dependency-automation.patch#L215 No, `c9s` needs t

[go-rpm-macros] PR #34: Add BUILDTAGS to %gobuildflags

2021-08-30 Thread Brian C . Lane
bcl commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you are following: `` *I* have not done anything other than try to make things match so that I don't have to kludge my spec file. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macr

[go-rpm-macros] PR #34: Add BUILDTAGS to %gobuildflags

2021-08-30 Thread Neal Gompa
ngompa commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you are following: `` :weary: `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/34 ___ golang mailing list -- golang@l

[go-rpm-macros] PR #34: Add BUILDTAGS to %gobuildflags

2021-08-30 Thread Brian C . Lane
bcl commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you are following: `` https://bugzilla.redhat.com/show_bug.cgi?id=1999335 `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/34 __

[go-rpm-macros] PR #34: Add BUILDTAGS to %gobuildflags

2021-08-30 Thread Link Dupont
linkdupont commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you are following: `` +1 to `GOBUILDTAGS`. The macros already make use of `GOBUILDFLAGS`, so this follows convention. It also avoids the (albeit narrow) situation where `BUILDTAGS` is already assumed to mean "C buil