Got a chance to test this yesterday. Your change fixed it indeed.
Regards,
Geert
Op donderdag 2 maart 2023 21:36:00 CET schreef John Ralls:
> Found and fixed it. It turns out that string->number isn't locale-sensitive,
> std::to_string is. I replaced it with ostringstream and pushed.
>
> Regard
Found and fixed it. It turns out that string->number isn't locale-sensitive,
std::to_string is.
I replaced it with ostringstream and pushed.
Regards,
John Ralls
> On Mar 2, 2023, at 9:16 AM, john wrote:
>
> Geert,
>
> Aha! That would certainly explain why I couldn't reproduce it. That change
Geert,
Aha! That would certainly explain why I couldn't reproduce it. That change is
from
https://github.com/Gnucash/gnucash/commit/408b5ec2165fb43bef18b80ff44ba4d2f1b67f5f.
Yes, no doubt string->number expects the number to be represented in the
current locale, so it wants "42,0" and gettin
I still haven't figured out exactly where it goes wrong, but I did discover
it's a locale related
issue. For some reason this particular test has become locale sensitive.
If I run the test as follows:
LC_ALL=C ctest -V -R test-gnc-option-scheme-output
it passes. If however I do this:
LC_ALL=fr_
Geert,
I can't replicate that, tried on Debian 10, Debian Unstable, and Arch. I'm
installing a Fedora 37 VM but I'm out of time for today and won't get to the
point of a test build of GnuCash.
Regards,
John Ralls
> On Feb 28, 2023, at 2:07 PM, Geert Janssens
> wrote:
>
> Hi,
>
> With the c
Hi,
With the current master branch I get the following test failure:
ctest --rerun-failed --output-on-failure
Test project /home/janssege/Development/gnucash/master/build
Start 120: test-gnc-option-scheme-output
1/1 Test #120: test-gnc-option-scheme-output ***Failed0.22 sec
gnc:mak
Hi,
I ran our test suite a few moments ago and I get a test failure for the
finance-quote related
tests. Below is the relevant detail from the test logs:
[ RUN ] GncQuotesTest.online_wiggle
* 22:02:03 WARN [GncFQQuoteSource::GncFQQuoteSource()] No
Alpha
Vantage API key set, currency q
On 1/26/19 11:20 PM, Christopher Lam wrote:
>
> Ok my bad
>
> May be safer to reuse your own gnucash repository
>
> * cd gnucash
> * git remote add chris https://github.com/christopherlam/gnucash.git
> * git fetch --all
> * git checkout chris/maint-chartjs-budget-barchart
> * dpkg etc
>
>
You can do it that way or you can do
git clone https://github.com/christopherlam/gnucash.git -b
maint-chartjs-budget-barchart/
or
git clone https://github.com/christopherlam/gnucash.git
git checkout -b maint-chartjs-budget-barchart/
or the way we do for testing pull requests; this is a bit f
Ok my bad
May be safer to reuse your own gnucash repository
* cd gnucash
* git remote add chris https://github.com/christopherlam/gnucash.git
* git fetch --all
* git checkout chris/maint-chartjs-budget-barchart
* dpkg etc
and to revert to main branch:
* git checkout maint
On 27/1/19 3
On 1/26/19 10:54 PM, Christopher Lam wrote:
> Stephen please spend some CPU burning time on my chartJS branch which
> needs beta testing?
>
> $git clone
> https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart
Thought I'd start this while headed toward some z's. Too tired t
Stephen please spend some CPU burning time on my chartJS branch which
needs beta testing?
$git clone
https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart
On 27/1/19 2:52 pm, Stephen M. Butler wrote:
On 1/26/19 10:29 PM, John Ralls wrote:
Stephen,
By all means learn
On 1/26/19 10:29 PM, John Ralls wrote:
> Stephen,
>
> By all means learn about git bisect, it's an extremely useful troubleshooting
> tool. But don't exercise yourself too much about this particular failure,
> Chris and I know exactly what commit caused it and that the underlying cause
> is a bu
Stephen,
By all means learn about git bisect, it's an extremely useful troubleshooting
tool. But don't exercise yourself too much about this particular failure, Chris
and I know exactly what commit caused it and that the underlying cause is a bug
in ICU (International Components for Unicode, ht
Thank you Stephen for your results.
It would seem that the test-transaction failure is caused by a faulty
libicu-dev whereas my failure caused by some other issue related to Time
zones.
C
On Sun., 27 Jan. 2019, 09:55 Stephen M. Butler On 1/26/19 3:13 AM, Christopher Lam wrote:
> > Another exper
On 1/26/19 3:13 AM, Christopher Lam wrote:
> Another experiment. Try prefix your build with "TZ=UTC " on current
> maint.
>
> Eg if using ninja, it'll be "TZ=UTC ninja check"
TZ=UTC dpkg- -rfakeroot -b -uc
End testing: Jan 27 01:47 UTC
+ exit 2
debian/rules:65: recipe for target 'override_
Another experiment. Try prefix your build with "TZ=UTC " on current maint.
Eg if using ninja, it'll be "TZ=UTC ninja check"
On Fri., 25 Jan. 2019, 11:52 Stephen M. Butler On 1/24/19 7:36 PM, Christopher Lam wrote:
> > Revert is a git terminology, not a gnucash one. Welcome to version
> > control
On 1/24/19 7:36 PM, Christopher Lam wrote:
> Revert is a git terminology, not a gnucash one. Welcome to version
> control.
That's the manual to which I referred. It meant something else to my
mind when I first saw your post. But, after further thought, my
previous thought was faulty.
My first
Revert is a git terminology, not a gnucash one. Welcome to version control.
Please remember this revert is reverting a buggy code with a previous buggy
code, so, cannot be consisted safe to package; best wait until the clever
devs can find a proper fix for gnc-date.
On Fri., 25 Jan. 2019, 05:46 S
OH! Light bulb on!
OK. I understand what you said earlier. I'll put the patches back into
the packaging.
Thanks for clearing that up.
--Steve
PS Looking in manual for 'revert' command.
On 1/24/19 1:06 PM, Christopher Lam wrote:
> Because e31f4c3f9 is causing errors on my build as well in d
Because e31f4c3f9 is causing errors on my build as well in different ways.
PS e31f4c3f9 must not be reverted for your packaging - please be patient
while a proper fix is pending.
On 25/1/19 3:48 am, Stephen M. Butler wrote:
On 1/24/19 2:32 AM, Christopher Lam wrote:
Stephen this bug is in 3.
On 1/24/19 2:32 AM, Christopher Lam wrote:
> Stephen this bug is in 3.4 and was fixed in commit 95bee405c
>
> Could you try "git revert e31f4c3f9" as a test for your "31/12/70"
> test-transaction errors?
That worked. Thank you. BTW, how did you find that it was fixed? I
ask, because there is a
Stephen this bug is in 3.4 and was fixed in commit 95bee405c
Could you try "git revert e31f4c3f9" as a test for your "31/12/70"
test-transaction errors?
On 24/1/19 3:05 am, Stephen M. Butler wrote:
Found this patch on the debian version for 3.4
Origin: upstream, https://bugs.gnucash.org/atta
Found this patch on the debian version for 3.4
Origin: upstream, https://bugs.gnucash.org/attachment.cgi?id=373094
Bug-Upstream: https://bugs.gnucash.org/show_bug.cgi?id=797008
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918057
From: Maxim Cournoyer
Date: Wed, 2 Jan 2019 14:46:2
24 matches
Mail list logo
