Re: build after last update

2017-07-08 Thread John Ralls
> On Jul 8, 2017, at 5:38 PM, Alex Aycinena wrote: > > After the last update, my Fedora 25 system won't build with the following > output: > > [gnucash-dev@HPdv5Fedora gnucash-working-build]$ make > -- Checking for modules 'OPTIONAL;webkit2gtk-4.0' > -- No package 'OPTIONAL' found > -- No

build after last update

2017-07-08 Thread Alex Aycinena
After the last update, my Fedora 25 system won't build with the following output: [gnucash-dev@HPdv5Fedora gnucash-working-build]$ make -- Checking for modules 'OPTIONAL;webkit2gtk-4.0' -- No package 'OPTIONAL' found -- No package 'webkit2gtk-4.0' found -- Checking for module 'webkit2gtk-3.0'

Re: Gtk3

2017-07-08 Thread Robert Fewell
I will have a think about this after I complete all the other required changes. Bob On 8 July 2017 at 17:46, Geert Janssens wrote: > On zaterdag 8 juli 2017 17:25:19 CEST Robert Fewell wrote: > > > The file name can be as you stated, I was thinking about the widget style > > > contexts, maybe a

Re: Gtk3

2017-07-08 Thread Robert Fewell
OK, I will have a go at this on Sunday before I try and make the changes you have mentioned in your feedback. Bob On 8 July 2017 at 17:31, Geert Janssens wrote: > Bob, > > I had a few merge conflicts to resolve during merge. There was one that > wasn't > trivial: > src/import-export/dialog-impo

Re: Gtk3

2017-07-08 Thread John Ralls
Geert, Great, thanks! That was what I was planning to do today, so it moves me up to merging in my mingw64 branch and converting the mingw64 branch of gnucash-on-windows to Gtk3. That blocks windows nightlies so I had it in mind that we’d hold off on merging into the official master until then

Re: Gtk3

2017-07-08 Thread Geert Janssens
On zaterdag 8 juli 2017 17:25:19 CEST Robert Fewell wrote: > The file name can be as you stated, I was thinking about the widget style > contexts, maybe along the lines of GncDenseCal_font_size > > Bob Right. I actually have no idea what is common. The whole css thing is pretty new to me. Did yo

Re: Gtk3

2017-07-08 Thread Geert Janssens
Bob, I had a few merge conflicts to resolve during merge. There was one that wasn't trivial: src/import-export/dialog-import.glade To be able to continue with the merge I have reverted it to the state on master, except for the name changes for the primary dialogs. That way it still builds fine

Re: Gtk3

2017-07-08 Thread Robert Fewell
The file name can be as you stated, I was thinking about the widget style contexts, maybe along the lines of GncDenseCal_font_size Bob On 8 July 2017 at 14:39, Geert Janssens wrote: > On zaterdag 8 juli 2017 15:17:45 CEST Robert Fewell wrote: > > Geert, > > > > That sounds like a good idea, not

Re: Gtk3

2017-07-08 Thread Robert Fewell
Thanks for your comments, I have a few more changes to make and then I will try and get your recomendations done next week. Bob On 8 July 2017 at 15:02, Geert Janssens wrote: > I'm done with reviewing your work. You'll find mi comments directly on the > github commits. > > In general - well don

Re: Gtk3

2017-07-08 Thread Geert Janssens
I'm done with reviewing your work. You'll find mi comments directly on the github commits. In general - well done! This really brings us much closer to a real gtk3 gnucash. As far as I'm concerned your branch is ready for merging: - the tree builds fine - the build executable seems to work barr

Re: Gtk3

2017-07-08 Thread Geert Janssens
On zaterdag 8 juli 2017 15:17:45 CEST Robert Fewell wrote: > Geert, > > That sounds like a good idea, not sure about the location, may be in > share/gnucash/gnucash.css Doh... Indeed share/gnucash/ would be much better than /etc. It's application data, not system configuration. > Some kind of n

Re: Gtk3

2017-07-08 Thread Robert Fewell
Geert, That sounds like a good idea, not sure about the location, may be in share/gnucash/gnucash.css Some kind of naming format will need to be decided that makes sense. I can have a look at that after all your initial thoughts !! Bob On 8 July 2017 at 14:01, Geert Janssens wrote: > Bob, > >

Re: Gtk3

2017-07-08 Thread Geert Janssens
Bob, While reading through your changes I note we have lots of places where we make some small tweaks to the default gui style. It shows in your commits because we have to change from GtkStyle api to GtkStyleContext/GtkCssProvider api. This got me thinking about a future streamlining we should

Re: Gtk3

2017-07-08 Thread Geert Janssens
Hi Bob, I'm evaluating your branch now. Great work so far! If I have comments, I'll add them in your github branch directly to the commits. Thanks! Geert On donderdag 29 juni 2017 11:16:04 CEST Robert Fewell wrote: > This is what I have done so far, may of gone too far but every thing still >