Thanks for your comments, I have a few more changes to make and then I will try and get your recomendations done next week.
Bob On 8 July 2017 at 15:02, Geert Janssens <geert.gnuc...@kobaltwit.be> wrote: > I'm done with reviewing your work. You'll find mi comments directly on the > github commits. > > In general - well done! This really brings us much closer to a real gtk3 > gnucash. > > As far as I'm concerned your branch is ready for merging: > - the tree builds fine > - the build executable seems to work barring a few visual details > > So IMO this is ready to be tested by a bigger audience. > > Regards, > > Geert > > On zaterdag 8 juli 2017 15:01:38 CEST Geert Janssens wrote: > > Bob, > > > > While reading through your changes I note we have lots of places where we > > make some small tweaks to the default gui style. It shows in your commits > > because we have to change from GtkStyle api to > > GtkStyleContext/GtkCssProvider api. > > > > This got me thinking about a future streamlining we should consider: > instead > > of adding code snippets that insert custom CSS, can't we collect all of > > these snippets in one big CSS file we ship with gnucash, to be stored in > > /etc/ gnucash/gnucash.css and which we read at load time ? Much like we > now > > load a custom .gtk3.0-gnucash.css file. > > > > Both can co-exist IMO, with the latter taking precedence over the former. > > The one in etc should be "Application" priority the one in the homedir > > "User" priority. > > > > This would keep the code cleaner and separate function from presentation. > > Especially your initial work of adding style context to most widgets is a > > big step in the right direction. > > > > What do you think ? > > > > Regards, > > > > Geert > _______________________________________________ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
