Re: gnucash master: Add failing unittest for aqbanking lookup of trans_retrieval date.

2014-09-08 Thread John Ralls
On Sep 8, 2014, at 11:16 AM, Christian Stimming wrote: > Am Montag, 8. September 2014, 07:17:47 schrieb John Ralls: >> On Sep 8, 2014, at 5:31 AM, Christian Stimming > wrote: >>> Zitat von John Ralls : > recently I noticed the "trans-retrieval" slot in the aqbanking account > doesn't r

Re: Namespaces, file names,...

2014-09-08 Thread John Ralls
On Sep 8, 2014, at 11:22 AM, Christian Stimming wrote: > Am Sonntag, 7. September 2014, 15:10:13 schrieb John Ralls: >>> I strongly prefer namespaces in all-lowercase. I have somewhat a >>> preference >>> for "gnc" as namespace name, but we are an application anyway and not a >>> library, so we'

Re: Namespaces, file names,...

2014-09-08 Thread Christian Stimming
Am Sonntag, 7. September 2014, 15:10:13 schrieb John Ralls: > > I strongly prefer namespaces in all-lowercase. I have somewhat a > > preference > > for "gnc" as namespace name, but we are an application anyway and not a > > library, so we're basically free to choose whatever we want as interface >

Re: gnucash master: Add failing unittest for aqbanking lookup of trans_retrieval date.

2014-09-08 Thread Christian Stimming
Am Montag, 8. September 2014, 07:17:47 schrieb John Ralls: > On Sep 8, 2014, at 5:31 AM, Christian Stimming wrote: > > Zitat von John Ralls : > >>> recently I noticed the "trans-retrieval" slot in the aqbanking account > >>> doesn't remember its value. > >> > >> Christian, > >> > >> Yeah, fixed

Re: gnucash master: Add failing unittest for aqbanking lookup of trans_retrieval date.

2014-09-08 Thread Derek Atkins
John Ralls writes: > On Sep 8, 2014, at 5:31 AM, Christian Stimming wrote: > >> Zitat von John Ralls : recently I noticed the "trans-retrieval" slot in the aqbanking account doesn't remember its value. >>> >>> Christian, >>> >>> Yeah, fixed and pushed, e210f8c. >>> >>> The diff

Re: Namespaces, file names,...

2014-09-08 Thread Derek Atkins
John Ralls writes: [snip] > Since we want to make the API useful outside of GnuCash we should declare a > namespace to wrap everything in, maybe Gnc. That way an application that > wants to extend our Account class could still call their child class Account, > like so: > class Account : pub

Re: gnucash master: Add failing unittest for aqbanking lookup of trans_retrieval date.

2014-09-08 Thread John Ralls
On Sep 8, 2014, at 5:31 AM, Christian Stimming wrote: > Zitat von John Ralls : >>> recently I noticed the "trans-retrieval" slot in the aqbanking account >>> doesn't >>> remember its value. >> >> Christian, >> >> Yeah, fixed and pushed, e210f8c. >> >> The difference was that your test used t

Re: gnucash master: Add failing unittest for aqbanking lookup of trans_retrieval date.

2014-09-08 Thread Christian Stimming
Zitat von John Ralls : recently I noticed the "trans-retrieval" slot in the aqbanking account doesn't remember its value. Christian, Yeah, fixed and pushed, e210f8c. The difference was that your test used the defective accessor function and mine used qof_instance_get directly with the rig