Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-12 Thread Mario Sanchez Prada
Hi, > [...] > 2. Add a new function that will only need the offset and the > granularity as input parameters: > > gchar* atk_text_get_text_for_offset (AtkText *text, > [...] Just to mention that after some discussion on bugzilla (see [1]), we are thinking that perhaps a better name for this

Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-12 Thread Trevor Saunders
On Sun, Aug 11, 2013 at 08:37:16PM +0200, Piñeiro wrote: > On 08/09/2013 11:02 PM, Trevor Saunders wrote: > > > >> I think that in the end we shouldn't worry too much about this in this > >> scope. I would maintain the temporal wrapper to the old method for this > >> bug (fwiw, bgo#705581) and thin

Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-11 Thread Piñeiro
On 08/09/2013 11:02 PM, Trevor Saunders wrote: > >> I think that in the end we shouldn't worry too much about this in this >> scope. I would maintain the temporal wrapper to the old method for this >> bug (fwiw, bgo#705581) and think about the other problem from a more >> general pov. I wouldn't bl

Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-09 Thread Trevor Saunders
On Fri, Aug 09, 2013 at 11:26:41AM +0200, Piñeiro wrote: > On 08/06/2013 10:11 PM, Trevor Saunders wrote: > > On Tue, Aug 06, 2013 at 04:22:40PM +0200, Mario wrote: > >> Hi Trevor, > >> > >> On 6 August 2013 16:05, Trevor Saunders wrote: > 6. In atspi2-atk bridge, check which version of ATK a

Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-09 Thread Piñeiro
On 08/06/2013 01:21 PM, Joanmarie Diggs wrote: > On 08/06/2013 11:36 AM, Mario Sanchez Prada wrote: > >> typedef enum { >> ATK_TEXT_GRANULARITY_CHAR, >> ATK_TEXT_GRANULARITY_WORD, >> ATK_TEXT_GRANULARITY_LINE, >> ATK_TEXT_GRANULARITY_SENTENCE >> } AtkTextGran

Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-09 Thread Piñeiro
On 08/06/2013 10:11 PM, Trevor Saunders wrote: > On Tue, Aug 06, 2013 at 04:22:40PM +0200, Mario wrote: >> Hi Trevor, >> >> On 6 August 2013 16:05, Trevor Saunders wrote: 6. In atspi2-atk bridge, check which version of ATK a specific application is implementing (using atk_get_version())

Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-06 Thread Trevor Saunders
On Tue, Aug 06, 2013 at 04:22:40PM +0200, Mario wrote: > Hi Trevor, > > On 6 August 2013 16:05, Trevor Saunders wrote: > >> 6. In atspi2-atk bridge, check which version of ATK a specific > >> application is implementing (using atk_get_version()) when > >> implementing this new atk_text_get_text_f

Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-06 Thread Trevor Saunders
> 6. In atspi2-atk bridge, check which version of ATK a specific > application is implementing (using atk_get_version()) when > implementing this new atk_text_get_text_for_offset(), so we know > whether we can call atk_text_get_text_for_offset() or we need to use > the old atk_text_get_text_at_offs

Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-06 Thread Joanmarie Diggs
On 08/06/2013 11:36 AM, Mario Sanchez Prada wrote: > typedef enum { > ATK_TEXT_GRANULARITY_CHAR, > ATK_TEXT_GRANULARITY_WORD, > ATK_TEXT_GRANULARITY_LINE, > ATK_TEXT_GRANULARITY_SENTENCE > } AtkTextGranularity; As long as we're at it How about ATK_TEXT_