Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-12 Thread Mario Sanchez Prada
Hi, > [...] > 2. Add a new function that will only need the offset and the > granularity as input parameters: > > gchar* atk_text_get_text_for_offset (AtkText *text, > [...] Just to mention that after some discussion on bugzilla (see [1]), we are thinking that perhaps a better name for this

Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-12 Thread Trevor Saunders
On Sun, Aug 11, 2013 at 08:37:16PM +0200, Piñeiro wrote: > On 08/09/2013 11:02 PM, Trevor Saunders wrote: > > > >> I think that in the end we shouldn't worry too much about this in this > >> scope. I would maintain the temporal wrapper to the old method for this > >> bug (fwiw, bgo#705581) and thin

Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-11 Thread Piñeiro
On 08/09/2013 11:02 PM, Trevor Saunders wrote: > >> I think that in the end we shouldn't worry too much about this in this >> scope. I would maintain the temporal wrapper to the old method for this >> bug (fwiw, bgo#705581) and think about the other problem from a more >> general pov. I wouldn't bl

Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-09 Thread Trevor Saunders
On Fri, Aug 09, 2013 at 11:26:41AM +0200, Piñeiro wrote: > On 08/06/2013 10:11 PM, Trevor Saunders wrote: > > On Tue, Aug 06, 2013 at 04:22:40PM +0200, Mario wrote: > >> Hi Trevor, > >> > >> On 6 August 2013 16:05, Trevor Saunders wrote: > 6. In atspi2-atk bridge, check which version of ATK a

Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-09 Thread Piñeiro
On 08/06/2013 01:21 PM, Joanmarie Diggs wrote: > On 08/06/2013 11:36 AM, Mario Sanchez Prada wrote: > >> typedef enum { >> ATK_TEXT_GRANULARITY_CHAR, >> ATK_TEXT_GRANULARITY_WORD, >> ATK_TEXT_GRANULARITY_LINE, >> ATK_TEXT_GRANULARITY_SENTENCE >> } AtkTextGran

Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-09 Thread Piñeiro
On 08/06/2013 10:11 PM, Trevor Saunders wrote: > On Tue, Aug 06, 2013 at 04:22:40PM +0200, Mario wrote: >> Hi Trevor, >> >> On 6 August 2013 16:05, Trevor Saunders wrote: 6. In atspi2-atk bridge, check which version of ATK a specific application is implementing (using atk_get_version())

Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-06 Thread Trevor Saunders
On Tue, Aug 06, 2013 at 04:22:40PM +0200, Mario wrote: > Hi Trevor, > > On 6 August 2013 16:05, Trevor Saunders wrote: > >> 6. In atspi2-atk bridge, check which version of ATK a specific > >> application is implementing (using atk_get_version()) when > >> implementing this new atk_text_get_text_f

Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-06 Thread Trevor Saunders
> 6. In atspi2-atk bridge, check which version of ATK a specific > application is implementing (using atk_get_version()) when > implementing this new atk_text_get_text_for_offset(), so we know > whether we can call atk_text_get_text_for_offset() or we need to use > the old atk_text_get_text_at_offs

Re: [g-a-devel] RFC: AtkText simplification (take 3)

2013-08-06 Thread Joanmarie Diggs
On 08/06/2013 11:36 AM, Mario Sanchez Prada wrote: > typedef enum { > ATK_TEXT_GRANULARITY_CHAR, > ATK_TEXT_GRANULARITY_WORD, > ATK_TEXT_GRANULARITY_LINE, > ATK_TEXT_GRANULARITY_SENTENCE > } AtkTextGranularity; As long as we're at it How about ATK_TEXT_

Re: [g-a-devel] RFC: AtkText simplification (take 2)

2013-06-27 Thread Piñeiro
On 06/26/2013 02:40 PM, Mario Sanchez Prada wrote: >> On 06/24/2013 02:26 PM, Mario Sanchez Prada wrote: [...] So, taking into account that you are already working on this, I assume that you would prefer to add the generic boundary now, in order to avoid two updates of the imple

Re: [g-a-devel] RFC: AtkText simplification (take 2)

2013-06-26 Thread Mario Sanchez Prada
> On 06/24/2013 02:26 PM, Mario Sanchez Prada wrote: > >> [...] > >> So, taking into account that you are already working on this, I > >> assume that you would prefer to add the generic boundary now, in > >> order to avoid two updates of the implementation of those APIs. > Right? Yes, that would b

Re: [g-a-devel] RFC: AtkText simplification (take 2)

2013-06-25 Thread Piñeiro
On 06/24/2013 02:26 PM, Mario Sanchez Prada wrote: >> [...] >> So, taking into account that you are already working on this, I assume >> that you would prefer to add the generic boundary now, in order to >> avoid two updates of the implementation of those APIs. Right? > It's not that I prefer to do

Re: [g-a-devel] RFC: AtkText simplification (take 2)

2013-06-25 Thread Piñeiro
On 06/24/2013 01:51 PM, Trevor Saunders wrote: >> b) Add the generic boundary now. The enum would be something like: >> typedef enum { >> ATK_TEXT_BOUNDARY_CHAR, >> ATK_TEXT_BOUNDARY_WORD_START, >> ATK_TEXT_BOUNDARY_WORD_END, >> ATK_TEXT_BOUNDARY_SENTENCE_START, >>

Re: [g-a-devel] RFC: AtkText simplification (take 2)

2013-06-24 Thread Mario Sanchez Prada
> [...] > So, taking into account that you are already working on this, I assume > that you would prefer to add the generic boundary now, in order to > avoid two updates of the implementation of those APIs. Right? It's not that I prefer to do that now in order to avoid two updates of the implement

Re: [g-a-devel] RFC: AtkText simplification (take 2)

2013-06-24 Thread Trevor Saunders
> b) Add the generic boundary now. The enum would be something like: > typedef enum { > ATK_TEXT_BOUNDARY_CHAR, > ATK_TEXT_BOUNDARY_WORD_START, > ATK_TEXT_BOUNDARY_WORD_END, > ATK_TEXT_BOUNDARY_SENTENCE_START, > ATK_TEXT_BOUNDARY_SENTENCE_END, > ATK_TEXT_BO

Re: [g-a-devel] RFC: AtkText simplification (take 2)

2013-06-24 Thread Piñeiro
On 06/24/2013 12:04 PM, Mario Sanchez Prada wrote: >> [...] >> Right now I prefer a). The main problem with b) is that we would have >> three pairs of macros that would mean exactly the same. > I'm sorry to disagree here, but I think b) would be better, all things > considered, and as long as it'

Re: [g-a-devel] RFC: AtkText simplification (take 2)

2013-06-24 Thread Mario Sanchez Prada
> [...] > Right now I prefer a). The main problem with b) is that we would have > three pairs of macros that would mean exactly the same. I'm sorry to disagree here, but I think b) would be better, all things considered, and as long as it's clearly stated that all those _START boundaries are de

Re: [g-a-devel] RFC: AtkText simplification (take 2)

2013-06-24 Thread Mario Sanchez Prada
> [...] > Since Orca is the only AT which had been -- but is no longer -- using > those deprecated methods, I'm not entirely sure what difference it > would make from the point of view of ATs. ;) Probably none, just double checking :) > But it's early and Monday, so if I'm missing something (oth

Re: [g-a-devel] RFC: AtkText simplification (take 2)

2013-06-24 Thread Piñeiro
On 06/22/2013 08:49 PM, Joanmarie Diggs wrote: > On 06/17/2013 02:40 PM, Piñeiro wrote: > > [...] > >> As Joanmarie said on that thread, the idea is not having any _END/_START >> boundaries, and the "surviving" boundary would mimic what _START is >> doing right now. Anyway, as I said this is the fi

Re: [g-a-devel] RFC: AtkText simplification (take 2)

2013-06-24 Thread Joanmarie Diggs
On 06/24/2013 05:06 AM, Mario Sanchez Prada wrote: > And perhaps it would be even worth it to first post a patch to > "deprecate" those methods in WebKitGTK+ too, so we are left with just > the "at" method and the START boundaries, and get that upstream > before pushing the "no pango" patches, but

Re: [g-a-devel] RFC: AtkText simplification (take 2)

2013-06-24 Thread Mario Sanchez Prada
- > From: gnome-accessibility-devel [mailto:gnome-accessibility-devel- > boun...@gnome.org] On Behalf Of Joanmarie Diggs > Sent: 22 June 2013 19:49 > To: gnome-accessibility-devel@gnome.org > Subject: Re: [g-a-devel] RFC: AtkText simplification (take 2) > > On 06/17/2013 0

Re: [g-a-devel] RFC: AtkText simplification (take 2)

2013-06-22 Thread Joanmarie Diggs
On 06/17/2013 02:40 PM, Piñeiro wrote: [...] > As Joanmarie said on that thread, the idea is not having any _END/_START > boundaries, and the "surviving" boundary would mimic what _START is > doing right now. Anyway, as I said this is the first step, and probably > the only thing that we can do o

Re: [g-a-devel] RFC: AtkText simplification

2013-05-12 Thread Trevor Saunders
On Sun, May 12, 2013 at 11:03:14AM -0400, Joanmarie Diggs wrote: > On 05/05/2013 09:37 PM, Trevor Saunders wrote: > > > I wonder if there is a reason you prefer this approach to the ia2 one in > > which after / before varients are kept, but only the actual contents of > > the word / line / whatev

Re: [g-a-devel] RFC: AtkText simplification

2013-05-12 Thread Joanmarie Diggs
On 05/05/2013 09:37 PM, Trevor Saunders wrote: > I wonder if there is a reason you prefer this approach to the ia2 one in > which after / before varients are kept, but only the actual contents of > the word / line / whatever are returned not the word / line and the > whitespace before or after de

Re: [g-a-devel] RFC: AtkText simplification

2013-05-05 Thread Trevor Saunders
On Sun, May 05, 2013 at 09:18:49PM -0400, Joanmarie Diggs wrote: > On 05/05/2013 05:52 PM, Mario Sanchez Prada wrote: > > > So, let me get this straight... does this mean I do not have to > > implement the after/before variants AT ALL in WebKitGTK+ and that I only > > have to consider the START bo

Re: [g-a-devel] RFC: AtkText simplification

2013-05-05 Thread Joanmarie Diggs
On 05/05/2013 05:52 PM, Mario Sanchez Prada wrote: > So, let me get this straight... does this mean I do not have to > implement the after/before variants AT ALL in WebKitGTK+ and that I only > have to consider the START boundary? Piñeiro should officially deprecate the after/before variants in A

Re: [g-a-devel] RFC: AtkText simplification

2013-05-05 Thread Mario Sanchez Prada
Hi, Sorry for the *so* late reply, but I'm suscribed to this mailing from my personal mail only and haven't checked this mailing list until now. On Sat, 2013-04-13 at 15:09 -0400, Joanmarie Diggs wrote: [...] > So I am here to propose we simplify AtkText and do it *now* i.e. while > we are very e

Re: [g-a-devel] RFC: AtkText simplification

2013-04-14 Thread Alexander Surkov
Hey, Joanie. Interesting. Personally I think it's nicer if a given chunk of text can > be chopped up neatly into the various TEXT_BOUNDARY_FOO units with no > scraps left over. Even for words. > I share this thinking but I don't know background of these constants. > It seems it makes > > the pre

Re: [g-a-devel] RFC: AtkText simplification

2013-04-14 Thread Joanmarie Diggs
Hey Alex. On 04/14/2013 09:37 AM, Alexander Surkov wrote: > Hi. For Gecko it's much easier if TEXT_BOUNDARY_FOO constants were the same > with IAccessible2 constants since it allows to have shared implementation. Ok, we'll definitely take that into account. We, of course, are not striving for dif

Re: [g-a-devel] RFC: AtkText simplification

2013-04-14 Thread Alexander Surkov
Hi. For Gecko it's much easier if TEXT_BOUNDARY_FOO constants were the same with IAccessible2 constants since it allows to have shared implementation. I should notice however that IAccessible2 says to return no word for TEXT_BOUNDARY_WORD if the given offset is outside a word. It seems it makes the

Re: [g-a-devel] RFC: AtkText simplification

2013-04-13 Thread Joanmarie Diggs
On 04/13/2013 03:09 PM, Joanmarie Diggs wrote: [...] > In order to facilitate this simplification getting under way, I will > remove Orca's use of atk_text_get_text_{before,after}_offset(). Removal from Orca complete. In addition, I have filed these two bugs: 1. ATK: https://bugzilla.gnome.org/s