Le 07/09/2016 à 11:16, David DURIEUX a écrit :
> Hello,
>
> I propose new coding methods to enhance GLPI (better code, have
> tests, so less bugs):
>
> * NEVER (so no exceptions) commit directly in the repository, always
> create Pull Requests
For PR adding a feature / changing a behavior, I
Hello,
> For PR adding a feature / changing a behavior, I think we need to keep
> it open before merging for some time (1 day ?) so other developpers can
> comment it (e.g. https://github.com/glpi-project/glpi/pull/945)
OK for me, let's say PR will stay opened one day.
++
--
Johan
OK for me
- Mail original -
> De: "Johan Cwiklinski"
> À: "Liste de diffusion des developpeurs GLPI"
> Envoyé: Vendredi 9 Septembre 2016 09:35:37
> Objet: Re: [Glpi-dev] Modify coding methods to enhance code quality
>
> Hello,
>
> > For PR adding a feature / changing a behavior, I thin
1 day can be very long when it's an urgent bug fix
-Original Message-
From: Glpi-dev [mailto:glpi-dev-boun...@gna.org] On Behalf Of Alexandre Delaunay
Sent: Friday, September 09, 2016 10:47 AM
To: Liste de diffusion des developpeurs GLPI
Subject: Re: [Glpi-dev] Modify coding methods to en
Hello,
> 1 day can be very long when it's an urgent bug fix
In that case, let's say that it could be merged if it reaches 3 (or 2) +1?
++
--
Johan
___
Glpi-dev mailing list
Glpi-dev@gna.org
https://mail.gna.org/listinfo/glpi-dev
Ok
-Original Message-
From: Glpi-dev [mailto:glpi-dev-boun...@gna.org] On Behalf Of Johan Cwiklinski
Sent: Friday, September 09, 2016 11:00 AM
To: Liste de diffusion des developpeurs GLPI
Subject: Re: [Glpi-dev] Modify coding methods to enhance code quality
Hello,
> 1 day can be very lon
A fix cause less problem in PR, the only things will be the test
(enough test or not).
But an urgent bug fix not mean a release in urgency, so it can be
opened some hours (not some days :p)
David
++
Le Fri, 9 Sep 2016 08:55:41 +
"Moron, Olivier" a écrit:
>1 day can be very long when it's
Hello,
> A fix cause less problem in PR, the only things will be the test
> (enough test or not).
>
> But an urgent bug fix not mean a release in urgency, so it can be
> opened some hours (not some days :p)
Agree but anyways, bugfix or not, "urgent" or not ; if the PR is OK and has
been reviewe
Hi David,
You have good ideas for GLPI but actually, for me, it's not possible for
many reasons :
- how review the pull request?
For me it's a complete job because you must know very well all
framework of GLPI and we are very few to can do that
and i agree with Olivier: this job must be d
Yep so 2 validations needed (a '+1' is enough) to merge is ok for all ?
David
++
Le Fri, 9 Sep 2016 11:25:09 +0200 (CEST)
Johan Cwiklinski a écrit:
>Hello,
>
>> A fix cause less problem in PR, the only things will be the test
>> (enough test or not).
>>
>> But an urgent bug fix not mean a rele
Le Fri, 9 Sep 2016 11:32:20 +0200
"nini.lasson" a écrit:
>Hi David,
Hi Nelly,
>You have good ideas for GLPI but actually, for me, it's not possible
>for many reasons :
>
>- how review the pull request?
> For me it's a complete job because you must know very well all
>framework of GLPI and we
11 matches
Mail list logo
