1 day can be very long when it's an urgent bug fix
-----Original Message----- From: Glpi-dev [mailto:glpi-dev-boun...@gna.org] On Behalf Of Alexandre Delaunay Sent: Friday, September 09, 2016 10:47 AM To: Liste de diffusion des developpeurs GLPI Subject: Re: [Glpi-dev] Modify coding methods to enhance code quality OK for me ----- Mail original ----- > De: "Johan Cwiklinski" <jcwiklin...@teclib.com> > À: "Liste de diffusion des developpeurs GLPI" <glpi-dev@gna.org> > Envoyé: Vendredi 9 Septembre 2016 09:35:37 > Objet: Re: [Glpi-dev] Modify coding methods to enhance code quality > > Hello, > > > For PR adding a feature / changing a behavior, I think we need to keep > > it open before merging for some time (1 day ?) so other developpers can > > comment it (e.g. https://github.com/glpi-project/glpi/pull/945) > > OK for me, let's say PR will stay opened one day. > > ++ > -- > Johan > > _______________________________________________ > Glpi-dev mailing list > Glpi-dev@gna.org > https://mail.gna.org/listinfo/glpi-dev _______________________________________________ Glpi-dev mailing list Glpi-dev@gna.org https://mail.gna.org/listinfo/glpi-dev _______________________________________________ Glpi-dev mailing list Glpi-dev@gna.org https://mail.gna.org/listinfo/glpi-dev
