Re: [PR] chore: [FOLLOWUP] Drop support for Spark 3.3 (EOL) [datafusion-comet]

2025-03-15 Thread via GitHub
andygrove commented on code in PR #1534: URL: https://github.com/apache/datafusion-comet/pull/1534#discussion_r1996962884 ## spark/src/main/scala/org/apache/comet/serde/aggregates.scala: ## @@ -140,7 +140,7 @@ object CometAverage extends CometAggregateExpressionSerde with ShimQ

Re: [PR] chore: [FOLLOWUP] Drop support for Spark 3.3 (EOL) [datafusion-comet]

2025-03-15 Thread via GitHub
andygrove commented on code in PR #1534: URL: https://github.com/apache/datafusion-comet/pull/1534#discussion_r1996963216 ## spark/src/main/scala/org/apache/comet/serde/aggregates.scala: ## @@ -195,7 +195,7 @@ object CometSum extends CometAggregateExpressionSerde with ShimQuery

Re: [PR] chore: [FOLLOWUP] Drop support for Spark 3.3 (EOL) [datafusion-comet]

2025-03-15 Thread via GitHub
andygrove commented on code in PR #1534: URL: https://github.com/apache/datafusion-comet/pull/1534#discussion_r1996961777 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -438,7 +438,7 @@ class CometSparkSessionExtensions op

Re: [PR] build: bump spark version to 3.3.4, 3.4.4, 3.5.4 for spark-3.3, spark-3.4 and spark-3.5 [datafusion-comet]

2025-03-15 Thread via GitHub
andygrove closed pull request #1243: build: bump spark version to 3.3.4, 3.4.4, 3.5.4 for spark-3.3, spark-3.4 and spark-3.5 URL: https://github.com/apache/datafusion-comet/pull/1243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Support logic optimize rule to pass the case that Utf8view datatype combined with Utf8 datatype [datafusion]

2025-03-15 Thread via GitHub
zhuqi-lucas commented on PR #15239: URL: https://github.com/apache/datafusion/pull/15239#issuecomment-2727177209 > Thanks @zhuqi-lucas -- I have one request otherwise I think this looks good to me Thank you @alamb for review, i change back the original call to equivalent_names_and_ty

Re: [I] (RESPECT NULLS / IGNORE NULLS is syntax for window functions, not aggregate functions [datafusion]

2025-03-15 Thread via GitHub
Garamda commented on issue #15006: URL: https://github.com/apache/datafusion/issues/15006#issuecomment-2727165026 fyi) https://github.com/apache/datafusion/pull/15014#issuecomment-2725690181 -- This is an automated message from the Apache Git Service. To respond to the message, please log

<    1   2   3