andygrove commented on code in PR #1534:
URL: https://github.com/apache/datafusion-comet/pull/1534#discussion_r1996962884
##########
spark/src/main/scala/org/apache/comet/serde/aggregates.scala:
##########
@@ -140,7 +140,7 @@ object CometAverage extends CometAggregateExpressionSerde
with ShimQueryPlanSerd
return None
}
- if (!isLegacyMode(avg)) {
+ if (!avg.evalMode.equals(EvalMode.LEGACY)) {
Review Comment:
No need to use `equals` in Scala.
```suggestion
if (avg.evalMode != EvalMode.LEGACY) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
