kazuyukitanimura merged PR #1565:
URL: https://github.com/apache/datafusion-comet/pull/1565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
YanivKunda commented on code in PR #1565:
URL: https://github.com/apache/datafusion-comet/pull/1565#discussion_r2013820176
##
spark/src/main/spark-3.5/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala:
##
@@ -55,15 +55,15 @@ trait ShimCometScanExec {
protected def isNe
YanivKunda commented on code in PR #1565:
URL: https://github.com/apache/datafusion-comet/pull/1565#discussion_r2013670173
##
spark/src/main/spark-3.5/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala:
##
@@ -55,15 +55,15 @@ trait ShimCometScanExec {
protected def isNe
wForget commented on code in PR #1565:
URL: https://github.com/apache/datafusion-comet/pull/1565#discussion_r2011644208
##
spark/src/main/spark-3.5/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala:
##
@@ -55,15 +55,15 @@ trait ShimCometScanExec {
protected def isNeede
YanivKunda commented on code in PR #1565:
URL: https://github.com/apache/datafusion-comet/pull/1565#discussion_r2011633435
##
spark/src/main/spark-3.5/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala:
##
@@ -55,15 +55,15 @@ trait ShimCometScanExec {
protected def isNe
wForget commented on code in PR #1565:
URL: https://github.com/apache/datafusion-comet/pull/1565#discussion_r2011249870
##
spark/src/main/spark-3.5/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala:
##
@@ -55,15 +55,15 @@ trait ShimCometScanExec {
protected def isNeede
YanivKunda commented on PR #1565:
URL:
https://github.com/apache/datafusion-comet/pull/1565#issuecomment-2749446970
@parthchandra I regenerated the diff file per the instructions in
https://github.com/apache/datafusion-comet/blob/main/docs/source/contributor-guide/spark-sql-tests.md
-
A
codecov-commenter commented on PR #1565:
URL:
https://github.com/apache/datafusion-comet/pull/1565#issuecomment-2749077884
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1565?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca