wForget commented on code in PR #1565:
URL: https://github.com/apache/datafusion-comet/pull/1565#discussion_r2011249870
##########
spark/src/main/spark-3.5/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala:
##########
@@ -55,15 +55,15 @@ trait ShimCometScanExec {
protected def isNeededForSchema(sparkSchema: StructType): Boolean = false
protected def getPartitionedFile(f: FileStatusWithMetadata, p:
PartitionDirectory): PartitionedFile =
- PartitionedFileUtil.getPartitionedFile(f, p.values)
+ PartitionedFileUtil.getPartitionedFile(f, f.getPath, p.values)
protected def splitFiles(sparkSession: SparkSession,
file: FileStatusWithMetadata,
filePath: Path,
isSplitable: Boolean,
maxSplitBytes: Long,
partitionValues: InternalRow): Seq[PartitionedFile]
=
- PartitionedFileUtil.splitFiles(sparkSession, file, isSplitable,
maxSplitBytes, partitionValues)
+ PartitionedFileUtil.splitFiles(sparkSession, file, filePath, isSplitable,
maxSplitBytes, partitionValues)
Review Comment:
This change seems incompatible with versions below 3.5.4 of 3.5.X. Should we
try to maintain compatibility among minor versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
