Re: [PR] implement display for ColumnarValue [datafusion]

2025-01-22 Thread via GitHub
zjregee commented on code in PR #14220: URL: https://github.com/apache/datafusion/pull/14220#discussion_r1926503055 ## datafusion/expr-common/src/columnar_value.rs: ## @@ -329,6 +354,35 @@ mod tests { /// Makes an array of length `len` with all elements set to `val`

Re: [PR] implement display for ColumnarValue [datafusion]

2025-01-22 Thread via GitHub
xudong963 commented on code in PR #14220: URL: https://github.com/apache/datafusion/pull/14220#discussion_r1926469474 ## datafusion/expr-common/src/columnar_value.rs: ## @@ -329,6 +354,35 @@ mod tests { /// Makes an array of length `len` with all elements set to `val`

Re: [PR] implement display for ColumnarValue [datafusion]

2025-01-22 Thread via GitHub
zjregee commented on code in PR #14220: URL: https://github.com/apache/datafusion/pull/14220#discussion_r1926431830 ## datafusion/expr-common/src/columnar_value.rs: ## @@ -329,6 +354,35 @@ mod tests { /// Makes an array of length `len` with all elements set to `val`

Re: [PR] implement display for ColumnarValue [datafusion]

2025-01-22 Thread via GitHub
zjregee commented on code in PR #14220: URL: https://github.com/apache/datafusion/pull/14220#discussion_r1926426256 ## datafusion/expr-common/src/columnar_value.rs: ## @@ -218,6 +220,28 @@ impl ColumnarValue { } } +// Implement Display trait for ColumnarValue +// +// # P

Re: [PR] implement display for ColumnarValue [datafusion]

2025-01-22 Thread via GitHub
xudong963 commented on code in PR #14220: URL: https://github.com/apache/datafusion/pull/14220#discussion_r1926213478 ## datafusion/expr-common/src/columnar_value.rs: ## @@ -329,6 +354,35 @@ mod tests { /// Makes an array of length `len` with all elements set to `val`

Re: [PR] implement display for ColumnarValue [datafusion]

2025-01-22 Thread via GitHub
alamb commented on code in PR #14220: URL: https://github.com/apache/datafusion/pull/14220#discussion_r1926047838 ## datafusion/expr-common/src/columnar_value.rs: ## @@ -218,6 +220,28 @@ impl ColumnarValue { } } +// Implement Display trait for ColumnarValue +// +// # Pan

Re: [PR] implement display for ColumnarValue [datafusion]

2025-01-20 Thread via GitHub
zjregee commented on PR #14220: URL: https://github.com/apache/datafusion/pull/14220#issuecomment-2603613021 cc: @jayzhan211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.