xudong963 commented on code in PR #14220:
URL: https://github.com/apache/datafusion/pull/14220#discussion_r1926469474
##########
datafusion/expr-common/src/columnar_value.rs:
##########
@@ -329,6 +354,35 @@ mod tests {
/// Makes an array of length `len` with all elements set to `val`
fn make_array(val: i32, len: usize) -> ArrayRef {
- Arc::new(arrow::array::Int32Array::from(vec![val; len]))
+ Arc::new(Int32Array::from(vec![val; len]))
+ }
+
+ #[test]
+ fn test_display_scalar() {
+ let column = ColumnarValue::from(ScalarValue::from("foo"));
+ assert_eq!(
+ column.to_string(),
+ "+----------------------------+\n\
+| ColumnarValue(ScalarValue) |\n\
++----------------------------+\n\
+| foo |\n\
++----------------------------+"
Review Comment:
I mean every line here doesn't seem to be aligned?
ideally:
```
"+----------------------------+\n\
| ColumnarValue(ScalarValue) |\n\
+----------------------------+\n\
| foo |\n\
+----------------------------+"
...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
