Re: [PR] fix case_column_or_null with nullable when conditions [datafusion]

2024-12-25 Thread via GitHub
alamb merged PR #13886: URL: https://github.com/apache/datafusion/pull/13886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] fix case_column_or_null with nullable when conditions [datafusion]

2024-12-25 Thread via GitHub
alamb commented on PR #13886: URL: https://github.com/apache/datafusion/pull/13886#issuecomment-2561866508 Thanks @richox and @xudong963 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] fix case_column_or_null with nullable when conditions [datafusion]

2024-12-23 Thread via GitHub
richox commented on code in PR #13886: URL: https://github.com/apache/datafusion/pull/13886#discussion_r1896512603 ## datafusion/sqllogictest/test_files/case.slt: ## @@ -50,7 +50,7 @@ NULL 6 NULL NULL -7 +NULL Review Comment: done -- This is an automated message from

Re: [PR] fix case_column_or_null with nullable when conditions [datafusion]

2024-12-23 Thread via GitHub
alamb commented on code in PR #13886: URL: https://github.com/apache/datafusion/pull/13886#discussion_r1896165275 ## datafusion/sqllogictest/test_files/case.slt: ## @@ -50,7 +50,7 @@ NULL 6 NULL NULL -7 +NULL Review Comment: Can you also please add a test to this file whe