alamb commented on code in PR #13886: URL: https://github.com/apache/datafusion/pull/13886#discussion_r1896165275
########## datafusion/sqllogictest/test_files/case.slt: ########## @@ -50,7 +50,7 @@ NULL 6 NULL NULL -7 +NULL Review Comment: Can you also please add a test to this file where there are no nulls (to ensure the codepath where `null_count = 0` is also covered) ########## datafusion/sqllogictest/test_files/case.slt: ########## @@ -61,7 +61,7 @@ NULL 6 NULL NULL -7 Review Comment: sam thing here, `NULL > 2` is not `true` (it isn't false either, it is NULL) so this should not take the value of `b` ########## datafusion/sqllogictest/test_files/case.slt: ########## @@ -50,7 +50,7 @@ NULL 6 NULL NULL -7 Review Comment: this last row has `a IS NULL`,`b = 7` So the idea is that a > 2 is not true when `a IS NULL` so should fall through to the `ELSE null` clause -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
