andygrove merged PR #1462:
URL: https://github.com/apache/datafusion-comet/pull/1462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
LukMRVC commented on code in PR #1462:
URL: https://github.com/apache/datafusion-comet/pull/1462#discussion_r1979775668
##
spark/src/test/scala/org/apache/spark/CometPluginsSuite.scala:
##
@@ -143,3 +143,36 @@ class CometPluginsNonOverrideSuite extends CometTestBase {
asser
wForget commented on code in PR #1462:
URL: https://github.com/apache/datafusion-comet/pull/1462#discussion_r1979412638
##
spark/src/test/scala/org/apache/spark/CometPluginsSuite.scala:
##
@@ -143,3 +143,36 @@ class CometPluginsNonOverrideSuite extends CometTestBase {
asser
LukMRVC commented on PR #1462:
URL:
https://github.com/apache/datafusion-comet/pull/1462#issuecomment-2697480797
That one should be fine, they passed with current changes to overriding
spark executor memory, but fail without them.
--
This is an automated message from the Apache Git Serv
wForget commented on PR #1462:
URL:
https://github.com/apache/datafusion-comet/pull/1462#issuecomment-2697330290
> Okay, @wForget I reverted some of my changes back to align with your
proposal of overriding executor memory.
Does newly added test case also need to be changed?
--
Th
andygrove commented on PR #1462:
URL:
https://github.com/apache/datafusion-comet/pull/1462#issuecomment-2695094998
PR builds are currently failing. This should be fixed by
https://github.com/apache/datafusion-comet/pull/1465
--
This is an automated message from the Apache Git Service.
To
LukMRVC commented on PR #1462:
URL:
https://github.com/apache/datafusion-comet/pull/1462#issuecomment-269486
Okay, @wForget I reverted some of my changes back to align with your
proposal of overriding executor memory.
--
This is an automated message from the Apache Git Service.
To re
wForget commented on PR #1462:
URL:
https://github.com/apache/datafusion-comet/pull/1462#issuecomment-2693325144
> Thank you for finding this issue, which was introduced in my previous PR
#1379
My initial proposal was:
+ When unified memroy manager is disabled, we should use
`get
wForget commented on code in PR #1462:
URL: https://github.com/apache/datafusion-comet/pull/1462#discussion_r1976892621
##
spark/src/main/scala/org/apache/spark/Plugins.scala:
##
@@ -62,13 +62,9 @@ class CometDriverPlugin extends DriverPlugin with Logging
with ShimCometDriverPl
wForget commented on PR #1462:
URL:
https://github.com/apache/datafusion-comet/pull/1462#issuecomment-2693303635
Thank you for finding this issue, which was introduced in my previous PR
#1379
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
codecov-commenter commented on PR #1462:
URL:
https://github.com/apache/datafusion-comet/pull/1462#issuecomment-2692920843
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1462?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
LukMRVC commented on PR #1462:
URL:
https://github.com/apache/datafusion-comet/pull/1462#issuecomment-2692845799
Yes, it should be fixed by now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove commented on PR #1462:
URL:
https://github.com/apache/datafusion-comet/pull/1462#issuecomment-2692806811
Thanks @LukMRVC. Could you fix the code formatting issue?
There are instructions in
https://datafusion.apache.org/comet/contributor-guide/development.html#submitting-a-p
13 matches
Mail list logo
