drexler-sky commented on PR #1923:
URL:
https://github.com/apache/datafusion-comet/pull/1923#issuecomment-3007078399
I stepped into the code. The reason Comet falls back to Spark for the
literal [] is that it goes to
https://github.com/apache/datafusion-comet/blob/main/spark/src/main/scala
drexler-sky commented on PR #1923:
URL:
https://github.com/apache/datafusion-comet/pull/1923#issuecomment-3007061357
> "spark.sql.optimizer.excludedRules" ->
"org.apache.spark.sql.catalyst.optimizer.ConstantFolding"
I tried this, but it didn't work for me.
--
This is an au
comphead commented on PR #1923:
URL:
https://github.com/apache/datafusion-comet/pull/1923#issuecomment-3006672046
@drexler-sky what if
```
"spark.sql.optimizer.excludedRules" ->
"org.apache.spark.sql.catalyst.optimizer.ConstantFolding",
```
?
--
This is an automated mess
drexler-sky commented on PR #1923:
URL:
https://github.com/apache/datafusion-comet/pull/1923#issuecomment-3006298989
@andygrove Thanks for the suggestion! I have tried
```
checkSparkAnswerAndOperator(spark.sql("""
SELECT array_distinct(
CASE WHEN
andygrove commented on PR #1923:
URL:
https://github.com/apache/datafusion-comet/pull/1923#issuecomment-3004790090
> > ...1 more thing please add tests with empty array.
>
> I tested array_distinct with an empty array.
>
> ```
> SELECT array_distinct(array()) FROM t1;
>
drexler-sky commented on PR #1923:
URL:
https://github.com/apache/datafusion-comet/pull/1923#issuecomment-3002328767
> ...1 more thing please add tests with empty array.
I tested array_distinct with an empty array.
```
SELECT array_distinct(array()) FROM t1;
== Optimized
drexler-sky commented on code in PR #1923:
URL: https://github.com/apache/datafusion-comet/pull/1923#discussion_r2165266799
##
spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala:
##
@@ -232,24 +232,42 @@ class CometArrayExpressionSuite extends CometTestBase
w
andygrove commented on code in PR #1923:
URL: https://github.com/apache/datafusion-comet/pull/1923#discussion_r2164099829
##
spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala:
##
@@ -232,24 +232,42 @@ class CometArrayExpressionSuite extends CometTestBase
wit
drexler-sky commented on PR #1923:
URL:
https://github.com/apache/datafusion-comet/pull/1923#issuecomment-2998998589
@andygrove @parthchandra @comphead Could you please take another look? The
CI failure doesn't seem to be related to this PR.
--
This is an automated message from the Apach
drexler-sky commented on code in PR #1923:
URL: https://github.com/apache/datafusion-comet/pull/1923#discussion_r2162749959
##
spark/src/main/scala/org/apache/comet/serde/arrays.scala:
##
@@ -171,9 +184,9 @@ object CometArrayMax extends CometExpressionSerde {
binding: Boo
comphead commented on code in PR #1923:
URL: https://github.com/apache/datafusion-comet/pull/1923#discussion_r2162734270
##
spark/src/main/scala/org/apache/comet/serde/arrays.scala:
##
@@ -171,9 +184,9 @@ object CometArrayMax extends CometExpressionSerde {
binding: Boolea
drexler-sky commented on code in PR #1923:
URL: https://github.com/apache/datafusion-comet/pull/1923#discussion_r2162673921
##
spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala:
##
@@ -232,24 +232,42 @@ class CometArrayExpressionSuite extends CometTestBase
w
parthchandra commented on code in PR #1923:
URL: https://github.com/apache/datafusion-comet/pull/1923#discussion_r2162015639
##
spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala:
##
@@ -232,24 +232,42 @@ class CometArrayExpressionSuite extends CometTestBase
andygrove commented on PR #1923:
URL:
https://github.com/apache/datafusion-comet/pull/1923#issuecomment-2997098005
The CI test failure is unrelated to changes in this PR and is now fixed in
main branch
--
This is an automated message from the Apache Git Service.
To respond to the message
codecov-commenter commented on PR #1923:
URL:
https://github.com/apache/datafusion-comet/pull/1923#issuecomment-2995032965
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1923?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
15 matches
Mail list logo
