drexler-sky commented on code in PR #1923:
URL: https://github.com/apache/datafusion-comet/pull/1923#discussion_r2162673921
##########
spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala:
##########
@@ -232,24 +232,42 @@ class CometArrayExpressionSuite extends CometTestBase
with AdaptiveSparkPlanHelp
}
}
+ test("array_distinct") {
Review Comment:
Thanks for the comment. While I was testing the nulls, I found out that
datafusion's array_distinct doesn't behave the same as spark's array_distinct.
This is because datafusion first
[sorts](https://github.com/apache/datafusion/blob/main/datafusion/functions-nested/src/set_ops.rs#L541)
then removes duplicates while spark preserves the original order. Therefore I
changed the code to implement `IncompatExpr`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
